Public: anyone can read this; the crew can change it.

.where-sep leaves the stylesheet and docs/DESIGN.md §5d #4434

Parked opened this
Closed without merging

This removes the last of .where-sep, now that part one took it out of the markup. The two rules for it come out of src/web/style/content.ts: .where-sep { color: var(--faint); } and .row-meta .where-sep { margin: 0 3px; }. The name also comes off the end of the "page furniture" list in docs/DESIGN.md §5d.

Notes

stopped parked by the crew deploy e96b93c

opened this

This removes the last of .where-sep, now that part one took it out of the markup. The two rules for it come out of src/web/style/content.ts: .where-sep { color: var(--faint); } and .row-meta .where-sep { margin: 0 3px; }. The name also comes off the end of the "page furniture" list in docs/DESIGN.md §5d. No other rule changes.

grep finds where-sep nowhere under src/. It still appears in two tests, test/web-origins.test.ts and test/pull-check-again.test.ts, which check that the pages don't use it, so they stay as they are. bun scripts/design-lint.ts is clean, bun x tsc --noEmit passes, and bun test test/design-lint.test.ts passes (15 tests).

To try it: open a pull page or a mirrored repo's picker on the preview. The dots between places are drawn by .sep and look the same as before.

🤖 Generated with Claude Code

Closes #4281

4 earlier comments · 1 event
commented

This removes the last of .where-sep, now that part one took it out of the markup. The two rules for it come out of src/web/style/content.ts: .where-sep { color: var(--faint); } and .row-meta .where-sep { margin: 0 3px; }. The name also comes off the end of the "page furniture" list in docs/DESIGN.md §5d. No other rule changes.

grep finds where-sep nowhere under src/. It still appears in two tests, test/web-origins.test.ts and test/pull-check-again.test.ts, which check that the pages don't use it, so they stay as they are. bun scripts/design-lint.ts is clean, bun x tsc --noEmit passes, and bun test test/design-lint.test.ts passes (15 tests).

To try it: open a pull page or a mirrored repo's picker on the preview. The dots between places are drawn by .sep and look the same as before.

🤖 Generated with Claude Code

commented

This removes the last of .where-sep, now that part one took it out of the markup. The two rules for it come out of src/web/style/content.ts: .where-sep { color: var(--faint); } and .row-meta .where-sep { margin: 0 3px; }. The name also comes off the end of the "page furniture" list in docs/DESIGN.md §5d. No other rule changes.

grep finds where-sep nowhere under src/ or docs/. It still appears in two tests, test/web-origins.test.ts and test/pull-check-again.test.ts, which check that the pages don't use it, so they stay as they are.

The first check failed on load, not on this change. "GET /signin names its phases and answers under 10 ms" missed its 10 ms limit at 20 ms, two other shards failed on 3–5 s timeouts, and two more were killed before naming a test. None of those suites touch the stylesheet or the docs. Here test/signin-timing.test.ts passes on repeated runs. No code or test was changed for it. The branch now has main merged in, and the check reran on that push.

bun x tsc --noEmit passes and bun scripts/design-lint.ts is clean. bun test over test/signin-timing.test.ts, test/design-lint.test.ts, test/web-origins.test.ts and test/pull-check-again.test.ts gives 55 pass, 0 fail.

To try it: open a pull page or a mirrored repo's picker on the preview. The dots between places are drawn by .sep and look the same as before.

🤖 Generated with Claude Code

commented

This removes the last of .where-sep, now that part one took it out of the markup. The two rules for it come out of src/web/style/content.ts: .where-sep { color: var(--faint); } and .row-meta .where-sep { margin: 0 3px; }. The name also comes off the end of the "page furniture" list in docs/DESIGN.md §5d. No other rule changes.

main is merged in. It had edited the same "page furniture" line in docs/DESIGN.md, so the conflict was resolved by taking main's line and dropping only .where-sep from it. Against main, the diff is now exactly those two CSS rules and that one class name.

grep finds where-sep nowhere under src/ or docs/. It still appears in two tests, test/web-origins.test.ts and test/pull-check-again.test.ts, which check that the pages don't use it, so they stay as they are. bun x tsc --noEmit passes, bun scripts/design-lint.ts is clean, and bun test test/design-lint.test.ts passes (15 tests).

To try it: open a pull page or a mirrored repo's picker on the preview. The dots between places are drawn by .sep and look the same as before.

🤖 Generated with Claude Code

Approved — before the latest push

Removes the dead .where-sep rules and its §5d entry. The markup no longer uses it, and .sep in components.ts (color faint, .row-meta .sep margin 0 3px) draws the same separators, so nothing visibly changes. The preview answers 200. Tests that assert the class is absent stay valid. Two next steps: (1) add a lint check that fails when a class listed in DESIGN.md §5d has no rule in the stylesheet, so stale names are caught automatically; (2) fold the duplicate .crumbs .sep and .sep faint colour declarations in components.ts into one rule.

commented

.where-sep is no longer in src/web/style/content.ts or in the §5d list of docs/DESIGN.md, so it leaves the system the same way the .app-tile- and .fcard- classes did before it. This branch has origin/main merged in again. The conflict in docs/DESIGN.md was on the "page furniture" line of §5d: this branch had taken .where-sep out of it, and main had taken .terminal-line out of the same line. The merged line drops both. Neither class is left anywhere under src/web or in the docs.

bun scripts/design-lint.ts reports no colour, size or component added outside the system. The design tests pass (design-audit, design-lint, design-map, review-design) and bun x tsc --noEmit is clean. I did not run the full suite here; the forge's check runs it on this push.

To try it, open the preview at https://lab--4434--forge-trevato-apps.open-platform.sh and look at a page that used .where-sep, which should look the same as before.

🤖 Generated with Claude Code

commented

Parked by the crew: the check failed ("(unnamed)") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs