Public: anyone can read this; the crew can change it.
Design: a change's wall of cells uses the design system, and wall-cells leaves §5d #4428
scout/forge:scout/3841-design-a-change-s-wall-of-cells-uses-the → main 13 commits fork
4 files
changed +24
−3
docs/DESIGN.md +1 −1
| @@ -394,7 +394,7 @@ gone, so this list only shrinks. | ||
| 394 | 394 | A `.field` directly inside a `.bar` drops its bottom margin and the bar aligns to the end, so a labelled input and its button share a baseline |
| 395 | 395 | - **`style/components.ts`** — parts of the §5 components that the table does not spell out — the palette's list, the menu's items, a dialog's head and foot, comments, the theme picker — and a few small helpers beside them: `.cat` `.clone` `.clone-text` `.comment` `.comment-body` `.comment-form` `.dash` `.dialog-body` `.dialog-foot` `.dialog-head` `.empty-title` `.error-note` `.field-row` `.form-actions` `.hex` `.ico` `.ico-loader` `.list` `.live-status` `.menu-item` `.menu-panel` `.menu-sep` `.menu-title` `.palette-empty` `.palette-foot` `.palette-group` `.palette-heading` `.palette-input` `.palette-item` `.palette-list` `.passkey` `.passkey-lead` `.passkey-note` `.passkey-off` `.passkey-on` `.preview` `.sep` `.split` `.sprite` `.swatch` `.table-scroll` `.tell-here` `.theme-apply` `.theme-option` `.tick` `.timeline` `.tl-dot` `.toast-body` `.topbar-search` |
| 396 | 396 | - **`style/components.ts`, settings rows** — a list whose rows are settings (limits, capacity): the `<ul class="list setting-list">` lets title and meta wrap instead of ellipsizing, and a row's controls take their own line under 640px. `.row-fields` is the form in that row's trail (input, Save, Default): always visible, never hover-gated, wrapping under the text before it would clip. Use both for any page whose rows show a name, a current value, and a control to change it; use `.row-actions` only for secondary actions (delete, wake, pin, revoke). Flags, telemetry, cloud, people, crew roles and subscription headroom/budget use `.row-fields`. Classes: `.row-fields` `.setting-list` |
| 397 | - **`style/content.ts`, page furniture** — what frames a page's content: page and repo heads, the merge box, the front page and its tiles, explore, backups, boards, the fleet chart's series colours, lineage: `.app-shelf` `.app-tile` `.app-tile-body` `.app-tile-desc` `.app-tile-look` `.app-tile-name` `.backups-drill` `.backups-error` `.backups-now` `.backups-restore` `.bform` `.bgrid` `.big` `.bmanage` `.boards-result` `.bp-h2` `.bp-h3` `.bp-w2` `.bp-w3` `.break` `.bt-bar` `.bt-grid` `.bt-group` `.bt-hist` `.bt-name` `.bt-procs` `.bt-row` `.bt-val` `.chart` `.chart-box` `.commit-body` `.commit-head` `.domain-records` `.explore-filters` `.explore-line` `.explore-main` `.explore-name` `.explore-row` `.fg-s0` `.fg-s1` `.fg-s2` `.fg-s3` `.fg-s4` `.fg-s5` `.fg-s6` `.fg-s7` `.filters` `.flag-form` `.front-admin` `.front-controls` `.front-crew` `.front-featured` `.front-featured-body` `.front-featured-look` `.front-issues` `.front-live` `.front-more` `.front-pick` `.front-pin-any` `.front-weights` `.frozen` `.frozen-form` `.frozen-sentence` `.headroom` `.issue-head` `.issue-meta` `.merge-box` `.merge-form` `.merge-headline` `.merge-sub` `.mirror-form` `.number` `.origin-link` `.origin-mark` `.origin-name` `.origin-row` `.owner` `.page-head` `.path-head` `.policy-line` `.qf` `.repo-actions` `.repo-audience` `.repo-desc` `.repo-layout` `.repo-lineage` `.repo-title` `.search` `.slash` `.stage-detail` `.stage-dot` `.steps` `.sub` `.sys-pair` `.table-wrap` `.terminal-line` `.tok` `.tree-row` `.tree-total` `.wall-cells` `.where-sep` | |
| 397 | - **`style/content.ts`, page furniture** — what frames a page's content: page and repo heads, the merge box, the front page and its tiles, explore, backups, boards, the fleet chart's series colours, lineage: `.app-shelf` `.app-tile` `.app-tile-body` `.app-tile-desc` `.app-tile-look` `.app-tile-name` `.backups-drill` `.backups-error` `.backups-now` `.backups-restore` `.bform` `.bgrid` `.big` `.bmanage` `.boards-result` `.bp-h2` `.bp-h3` `.bp-w2` `.bp-w3` `.break` `.bt-bar` `.bt-grid` `.bt-group` `.bt-hist` `.bt-name` `.bt-procs` `.bt-row` `.bt-val` `.chart` `.chart-box` `.commit-body` `.commit-head` `.domain-records` `.explore-filters` `.explore-line` `.explore-main` `.explore-name` `.explore-row` `.fg-s0` `.fg-s1` `.fg-s2` `.fg-s3` `.fg-s4` `.fg-s5` `.fg-s6` `.fg-s7` `.filters` `.flag-form` `.front-admin` `.front-controls` `.front-crew` `.front-featured` `.front-featured-body` `.front-featured-look` `.front-issues` `.front-live` `.front-more` `.front-pick` `.front-pin-any` `.front-weights` `.frozen` `.frozen-form` `.frozen-sentence` `.headroom` `.issue-head` `.issue-meta` `.merge-box` `.merge-form` `.merge-headline` `.merge-sub` `.mirror-form` `.number` `.origin-link` `.origin-mark` `.origin-name` `.origin-row` `.owner` `.page-head` `.path-head` `.policy-line` `.qf` `.repo-actions` `.repo-audience` `.repo-desc` `.repo-layout` `.repo-lineage` `.repo-title` `.search` `.slash` `.stage-detail` `.stage-dot` `.steps` `.sub` `.sys-pair` `.table-wrap` `.terminal-line` `.tok` `.tree-row` `.tree-total` `.where-sep` | |
| 398 | 398 | - **`style/content.ts`, code view** — the source view and the syntax-highlight token classes `highlight-html.ts` builds as `tok-${kind}`: `.blob-view` `.ln` `.tok-attribute` `.tok-comment` `.tok-constant` `.tok-decorator` `.tok-deleted` `.tok-emphasis` `.tok-function` `.tok-heading` `.tok-inserted` `.tok-keyword` `.tok-link` `.tok-meta` `.tok-number` `.tok-operator` `.tok-plain` `.tok-property` `.tok-punctuation` `.tok-regex` `.tok-string` `.tok-tag` `.tok-type` `.tok-variable` |
| 399 | 399 | - **`style/content.ts`, prose (markdown)** — table cell alignment, built by `markdown.ts` as `ta-${align}`: `.ta-c` `.ta-r` |
| 400 | 400 | - **`style/content.ts`, diff viewer** — the diff table: its gutters, line kinds, file head and inline review comments: `.add` `.del` `.dh` `.diff` `.diff-body` `.diff-head` `.diff-note` `.diff-path` `.diff-stat` `.diff-stub` `.diff-summary` `.diff-table` `.dl` `.dl-review` `.dn` `.dn-comment` `.nonl` `.rc-hidden` `.rc-resolve` `.rc-resolved` `.wd` |
src/web/studio/change.ts +18
| @@ -55,6 +55,7 @@ import { | ||
| 55 | 55 | confirmAction, |
| 56 | 56 | icon, |
| 57 | 57 | originTag, |
| 58 | row, | |
| 58 | 59 | seg, |
| 59 | 60 | stateBadge, |
| 60 | 61 | time, |
| @@ -127,9 +128,26 @@ export function wallCard(wall: Wall): Html { | ||
| 127 | 128 | <strong |
| 128 | 129 | >${wall.unsound !== undefined |
| 129 | 130 | ? "This pull's contract does not read." |
| 131 | <<<<<<< HEAD | |
| 132 | : `This pull changes the policy: ${wall.loosened.length === 1 ? "one door opens" : `${wall.loosened.length} doors open`} wider.`} | |
| 133 | </div> | |
| 134 | <p class="merge-sub"> | |
| 135 | ${wall.unsound !== undefined | |
| 136 | ? "An app built on it does not boot. A person decides this one." | |
| 137 | : "A cell loosened is a decision undone, so the crew leaves this to a person: read the cells, then land or say what is off."} | |
| 138 | </p> | |
| 139 | <ul class="list setting-list"> | |
| 140 | ${(wall.unsound ?? wall.loosened.map(wallSentence)).map((line) => | |
| 141 | row({ title: line }), | |
| 142 | )} | |
| 143 | </ul> | |
| 144 | </div>`, | |
| 145 | { tone: "attn", extra: "merge-box wall" }, | |
| 146 | ======= | |
| 130 | 147 | : `This pull changes the policy: ${wall.loosened.length === 1 ? "one door opens" : `${wall.loosened.length} doors open`} wider.`}</strong |
| 131 | 148 | >`, |
| 132 | 149 | }, |
| 150 | >>>>>>> origin/main | |
| 133 | 151 | ); |
| 134 | 152 | } |
| 135 | 153 |
src/web/style/content.ts −2
| @@ -267,7 +267,6 @@ a.origin-chip:hover { border-color: var(--border-strong); color: var(--fg); } | ||
| 267 | 267 | .frozen-form { display: flex; align-items: flex-end; gap: 8px; flex-wrap: wrap; margin-top: 10px; } |
| 268 | 268 | .frozen-form .field { margin: 0; min-width: 0; flex: 1 1 14rem; max-width: 22rem; } |
| 269 | 269 | |
| 270 | .wall-cells { margin: 8px 0 0; padding-left: 18px; font-family: var(--mono); font-size: 12.5px; } | |
| 271 | 270 | /* A subscription's headroom for people: a small number beside its windows. */ |
| 272 | 271 | .headroom { display: flex; align-items: center; gap: 6px; } |
| 273 | 272 | .headroom .input { width: 5em; } |
| @@ -352,7 +351,6 @@ a.origin-chip:hover { border-color: var(--border-strong); color: var(--fg); } | ||
| 352 | 351 | .policy-line b { color: var(--fg); font-weight: 600; } |
| 353 | 352 | .policy-line[data-tone="mismatch"] .ico { color: var(--danger); } |
| 354 | 353 | .policy-line[data-tone="ok"] .ico { color: var(--success); } |
| 355 | .wall-cells li + li { margin-top: 3px; } | |
| 356 | 354 | form.inline { display: inline; margin-left: auto; } |
| 357 | 355 | |
| 358 | 356 | .terminal-line { display: flex; flex-wrap: wrap; align-items: baseline; gap: 6px 14px; } |
test/policy.test.ts +5
| @@ -244,6 +244,10 @@ describe("a pull at the wall", () => { | ||
| 244 | 244 | "This pull changes the policy: one door opens wider.", |
| 245 | 245 | ); |
| 246 | 246 | expect(body).toContain("note.create as anon: was no, now yes"); |
| 247 | <<<<<<< HEAD | |
| 248 | expect(body).not.toContain("wall-cells"); | |
| 249 | expect(body).toContain("list setting-list"); | |
| 250 | ======= | |
| 247 | 251 | // The wall is §5's card, its headline in the head: no merge-* class. |
| 248 | 252 | for (const name of ["merge-box", "merge-form", "merge-headline", "merge-sub"]) |
| 249 | 253 | expect(body).not.toContain(name); |
| @@ -251,6 +255,7 @@ describe("a pull at the wall", () => { | ||
| 251 | 255 | /<div class="card-head">[\s\S]*?<strong\s*>This pull changes the policy: one door opens wider\.<\/strong/, |
| 252 | 256 | ); |
| 253 | 257 | expect(body).toContain("A cell loosened is a decision undone"); |
| 258 | >>>>>>> origin/main | |
| 254 | 259 | const quiet = await openPull(w.app, w.alice, w.repo, { |
| 255 | 260 | title: "Only the signed-in read", |
| 256 | 261 | baseBranch: "main", |
new above
offline