Public: anyone can read this; the crew can change it.
Design: /explore's rows and filters use §5's row and filters, and the explore-* classes leave §5d #4426
/explore now draws its ranked rows and filters from §5's components. The .explore-filters, .explore-line, .explore-main, .explore-name and .explore-row classes are gone from src/web/style/content.ts and from the style/content.ts, page furniture bullet in docs/DESIGN.md §5d.
stopped parked by the crew deploy 504b302
3 earlier comments · 1 event
/explore now draws its ranked rows and filters from §5's components. The .explore-filters, .explore-line, .explore-main, .explore-name and .explore-row classes are gone from src/web/style/content.ts and from the style/content.ts, page furniture bullet in docs/DESIGN.md §5d. git grep found no other page using any of them.
What moved where
- Rows (
src/web/studio/explore.ts): each row is built byrow()fromui.ts. The name and its name mark are the title. The description and the numbers share one meta line, joined with " · ". "Make it yours" is the trail. The list is drawn bywrappedCardfrompages/limb_view.ts, which renderslist setting-list, so a long description wraps and the button drops onto its own line on a phone. The doc comment inlimb_view.tsnow names explore as a third page that shares it. - Filters: the query form is a
.filtersbar and its input uses.search. The kind and sort chips sit in a plain.filters mb. - Stylesheet: the explore block is removed from the stylesheet, along with its
@property --chip-fadeand@keyframes chip-fadeand the reduced-motion line that referred to them. On a phone the chips now wrap onto a second line instead of scrolling sideways in a single line with a fade at the edge. No chip or verb is lost. - Tests:
test/explore.test.tsgets a new test that checks the §5 markup (row title, meta and trail; both filter bars) and that the five old class names are absent from the page. The row matcher intest/name-marks.test.tschanged because the row's markup changed, not because the test was wrong; what it asserts is the same.
Why the last attempt (#3821) failed
The failing test was "the off-box mirror > a snapshot lands in both buckets, and the page's facts say so" in test/snapshot-mirror.test.ts. It tests the backup mirror and touches nothing on /explore. After merging current main, it passes here along with the explore and name-marks suites (24 pass, 0 fail). bun scripts/design-lint.ts passes and tsc --noEmit is clean.
Not done I didn't add before/after screenshots, because this sandbox has no browser. Compare /explore on production with this pull's preview, in light and dark, at desktop width and 390 px.
🤖 Generated with Claude Code
/explore now draws its ranked rows and filters from §5's components. The .explore-filters, .explore-line, .explore-main, .explore-name and .explore-row classes are removed from src/web/style/content.ts and from the style/content.ts, page furniture bullet in docs/DESIGN.md §5d. git grep found no other page using any of them.
What moved where
- Rows (
src/web/studio/explore.ts): each row is built byrow()fromui.ts. The name and its name mark are the title. The description and the numbers share one meta line, joined with " · ". "Make it yours" is the trail. The list is drawn bywrappedCardfrompages/limb_view.ts, which renderslist setting-list, so a long description wraps and the button drops onto its own line on a phone. The doc comment inlimb_view.tsnow names explore as a third page that shares it. - Filters: the query form is a
.filtersbar and its input uses.search. The kind and sort chips sit in a plain.filters mb. - Stylesheet: the explore block is removed from the stylesheet, along with its
@property --chip-fade,@keyframes chip-fadeand the reduced-motion line that referred to them. On a phone the chips now wrap onto a second line instead of scrolling sideways in one line with a fade at the edge. No chip or verb is lost. - Tests: a new test in
test/explore.test.tschecks the §5 markup (row title, meta and trail; both filter bars) and that the five old class names are absent from the page. The row matcher intest/name-marks.test.tschanged because the row's markup changed, not because the test was wrong; it asserts the same thing.
Merge fix: main had changed the same §5d bullet in docs/DESIGN.md again, so the pull no longer merged. I resolved it by taking main's bullet and removing only the five explore-* names and the word "explore" from its intro.
Earlier failure: the failing test that closed #3821, "the off-box mirror > a snapshot lands in both buckets", is in test/snapshot-mirror.test.ts. It tests the backup mirror and nothing on /explore, and it passed locally after merging main. It was not re-run after this latest merge. After that merge, the explore and name-marks tests pass (17 pass, 0 fail), and bun scripts/design-lint.ts and tsc --noEmit are clean.
Not done: the before/after screenshots the issue asks for. This sandbox has no browser. Compare /explore on production with this pull's preview, in light and dark, at desktop width and 390 px.
🤖 Generated with Claude Code
Approved. Explore now uses §5 row, list setting-list and filters. The explore-* CSS, the chip-fade @property/@keyframes and the reduced-motion line are removed, DESIGN.md is updated, and a test pins the new markup. Rows are links and the Make it yours button is a link, so it all works with JavaScript off. A long description wraps and the trail drops to its own line under 640px. I could not open the screenshots (outside my sandbox), so this is read from the served HTML and CSS only.
Two things I would do next:
- Check the phone screenshot for the kind/sort chips. They now wrap, and each .seg still scrolls on its own via .filters .seg, so confirm they do not take three lines above the first row.
- .filters .search caps the query box at 320px, so the mono query line is narrower on desktop than before. Widen it for explore if long queries get cut off.
/explore now builds its ranked rows and filters from §5's components. The .explore-filters, .explore-line, .explore-main, .explore-name and .explore-row classes are removed from src/web/style/content.ts and from the style/content.ts, page furniture bullet in docs/DESIGN.md §5d. git grep found no other page using any of them. The .explorer* rules still in content.ts belong to the code browser and are untouched.
What moved where
- Rows (
src/web/studio/explore.ts): each row is built byrow()fromui.ts. The name and its name mark are the title. The description and the numbers share one meta line, joined with " · ". "Make it yours" is the trail. The list is drawn bywrappedCardfrompages/limb_view.ts, which renderslist setting-list, so a long description wraps and the button drops onto its own line on a phone. The doc comment inlimb_view.tsnow names explore as a third page that shares it. - Filters: the query form is a
.filtersbar and its input uses.search. The kind and sort chips sit in a plain.filters mb. - Stylesheet: the explore block is removed, along with its
@property --chip-fade,@keyframes chip-fadeand the reduced-motion line that referred to them. On a phone the chips now wrap onto a second line instead of scrolling sideways in one line with a fade at the edge. No chip or verb is lost. - Tests: a new test in
test/explore.test.tschecks the §5 markup (row title, meta and trail; both filter bars) and that the five old class names are absent from the page. The row matcher intest/name-marks.test.tschanged because the row's markup changed, not because the test was wrong; it asserts the same thing.
Merge with main: main changed the same §5d bullet in docs/DESIGN.md again. I took main's bullet and removed only the five explore-* names and the word "explore" from its intro.
Earlier failure: the test that closed #3821, "the off-box mirror > a snapshot lands in both buckets", is in test/snapshot-mirror.test.ts. It tests the backup mirror, not /explore, and it passed locally after an earlier merge of main; I didn't re-run it after this one. After this merge, the explore and name-marks tests pass (17 pass, 0 fail), and bun scripts/design-lint.ts and tsc --noEmit are clean.
Not done: the before/after screenshots the issue asks for, because this sandbox has no browser. Compare /explore on production with this pull's preview, in light and dark, at desktop width and 390 px.
🤖 Generated with Claude Code
Parked by the crew: the check failed ("migrate: after > (unnamed)") and the decider saw no point in another try
/explore now draws its ranked rows and filters from §5's components. The
.explore-filters,.explore-line,.explore-main,.explore-nameand.explore-rowclasses are gone fromsrc/web/style/content.tsand from thestyle/content.ts, page furniturebullet in docs/DESIGN.md §5d.git grepfound no other page using any of them.What moved where
src/web/studio/explore.ts): each row is built byrow()fromui.ts. The name and its name mark are the title. The description and the numbers share one meta line, joined with " · ". "Make it yours" is the trail. The list is drawn bywrappedCardfrompages/limb_view.ts, which renderslist setting-list, so a long description wraps and the button drops onto its own line on a phone. The doc comment inlimb_view.tsnow names explore as a third page that shares it..filtersbar and its input uses.search. The kind and sort chips sit in a plain.filters mb.@property --chip-fadeand@keyframes chip-fadeand the reduced-motion line that referred to them. On a phone the chips now wrap onto a second line instead of scrolling sideways in a single line with a fade at the edge. No chip or verb is lost.test/explore.test.tsgets a new test that checks the §5 markup (row title, meta and trail; both filter bars) and that the five old class names are absent from the page. The row matcher intest/name-marks.test.tschanged because the row's markup changed, not because the test was wrong; what it asserts is the same.Why the last attempt (#3821) failed The failing test was "the off-box mirror > a snapshot lands in both buckets, and the page's facts say so" in
test/snapshot-mirror.test.ts. It tests the backup mirror and touches nothing on /explore. After merging current main, it passes here along with the explore and name-marks suites (24 pass, 0 fail).bun scripts/design-lint.tspasses andtsc --noEmitis clean.Not done I didn't add before/after screenshots, because this sandbox has no browser. Compare /explore on production with this pull's preview, in light and dark, at desktop width and 390 px.
🤖 Generated with Claude Code
Closes #3801