Public: anyone can read this; the crew can change it.

.app-tile, .app-tile-body, .app-tile-desc, .app-tile-look, .app-tile-name leave the stylesheet and docs/DESIGN.md §5d #4414

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

This removes the unused `.app-tile` rules: `.app-tile`, `.app-tile-body`, `.app-tile-desc`, `.app-tile-look` and `.app-tile-name` come out of `src/web/style/content.ts` and out of the §5d list in `docs/DESIGN.md`. No page draws them, and the existing guard at `test/front.test.ts:445` already checks that none of these classes comes back. The whole change is those two files: 11 lines removed, 1 chan…

shipped production is serving it deploy 2d10bf9

opened this

This removes the unused .app-tile rules: .app-tile, .app-tile-body, .app-tile-desc, .app-tile-look and .app-tile-name come out of src/web/style/content.ts and out of the §5d list in docs/DESIGN.md. No page draws them, and the existing guard at test/front.test.ts:445 already checks that none of these classes comes back. The whole change is those two files: 11 lines removed, 1 changed.

About the earlier failure: pull #4340 failed on "the page lists every pattern both routers know, unused first, and only to an admin" (test/usage-report.test.ts:66). That test checks that /settings/usage lists every route pattern from the web and API routers. It doesn't look at stylesheet classes, so removing CSS rules can't break it. The branch was several commits behind origin/main (including #4373, #4357, #4324 and #3735). I merged origin/main into it, and the test passes on the merged tree. I didn't confirm what made it fail before.

Checked locally: bun x tsc --noEmit and bun scripts/design-lint.ts are clean, and bun test on test/front.test.ts, test/usage-report.test.ts and test/design*.test.ts gives 41 pass, 0 fail.

What I chose not to do: I didn't change any test, and nothing else in the pull changes.

To try it: grep -rn app-tile src docs finds no stylesheet rule or §5d entry. The only matches are the not-present checks in test/front.test.ts.

🤖 Generated with Claude Code

Closes #4133

commented

This removes the unused .app-tile rules: .app-tile, .app-tile-body, .app-tile-desc, .app-tile-look and .app-tile-name come out of src/web/style/content.ts and out of the §5d list in docs/DESIGN.md. No page draws them, and the existing guard at test/front.test.ts:445 already checks that none of these classes comes back. The whole change is those two files: 11 lines removed, 1 changed.

About the earlier failure: pull #4340 failed on "the page lists every pattern both routers know, unused first, and only to an admin" (test/usage-report.test.ts:66). That test checks that /settings/usage lists every route pattern from the web and API routers. It doesn't look at stylesheet classes, so removing CSS rules can't break it. The branch was several commits behind origin/main (including #4373, #4357, #4324 and #3735). I merged origin/main into it, and the test passes on the merged tree. I didn't confirm what made it fail before.

Checked locally: bun x tsc --noEmit and bun scripts/design-lint.ts are clean, and bun test on test/front.test.ts, test/usage-report.test.ts and test/design*.test.ts gives 41 pass, 0 fail.

What I chose not to do: I didn't change any test, and nothing else in the pull changes.

To try it: grep -rn app-tile src docs finds no stylesheet rule or §5d entry. The only matches are the not-present checks in test/front.test.ts.

🤖 Generated with Claude Code

commented

This removes the unused .app-tile rules: .app-tile, .app-tile-body, .app-tile-desc, .app-tile-look and .app-tile-name come out of src/web/style/content.ts and out of the §5d list in docs/DESIGN.md. No page draws them, and the existing guard at test/front.test.ts:445 already checks that none of these classes comes back. Against main, the pull is those two files only: 11 lines removed, 1 changed.

Latest merge: main had removed .fork-bar from the same §5d line, which caused the conflict in docs/DESIGN.md. I kept main's line and took the five .app-tile* names out of it, so both removals are in. content.ts merged on its own.

About the earlier failure: pull #4340 failed on "the page lists every pattern both routers know, unused first, and only to an admin" (test/usage-report.test.ts:66). That test checks that /settings/usage lists every route pattern from the web and API routers. It doesn't look at stylesheet classes, so removing CSS rules can't break it. It passes on the merged tree, but I didn't confirm what made it fail before.

Checked locally after the merge: bun x tsc --noEmit and bun scripts/design-lint.ts are clean, and bun test on test/front.test.ts, test/usage-report.test.ts and test/design*.test.ts gives 41 pass, 0 fail.

What I chose not to do: I didn't change any test, and nothing else in the pull changes.

To try it: grep -rn app-tile src docs finds no stylesheet rule or §5d entry. The only matches are the not-present checks in test/front.test.ts.

🤖 Generated with Claude Code

commented

This removes the unused .app-tile rules: .app-tile, .app-tile-body, .app-tile-desc, .app-tile-look and .app-tile-name come out of src/web/style/content.ts and out of the §5d list in docs/DESIGN.md. No page draws them, and the existing guard at test/front.test.ts:445 already checks that none of these classes comes back. Against main, the pull is those two files only: 11 lines removed, 1 changed.

Preview deploy: the redeploy is now live. The preview at https://lab--4414--forge-trevato-apps.open-platform.sh serves /assets/forge-16ffb9ad698a613f.css, the same stylesheet a local boot of this head serves, and it has no .app-tile rules. I never saw the failed deploy's log and didn't find a cause in the code. Before the redeploy the preview answered / and /healthz but served an older stylesheet that still had .app-tile in it. Head 9f3f3718 boots locally, answers / with 200 and /healthz with ok, and logs no errors. So I pushed an empty commit (1e9bf991) to deploy again, with no code change.

Merges: main had removed .fork-bar from the same §5d line, which caused the conflict in docs/DESIGN.md. I kept main's line and took the five .app-tile* names out of it, so both removals are in.

About the earlier failure: pull #4340 failed on "the page lists every pattern both routers know, unused first, and only to an admin" (test/usage-report.test.ts:66). That test checks that /settings/usage lists every route pattern from the web and API routers, not stylesheet classes. It passes on the merged tree, but I didn't confirm what made it fail before.

Checked locally: bun x tsc --noEmit and bun scripts/design-lint.ts are clean. bun test on test/front.test.ts, test/usage-report.test.ts and test/design*.test.ts passed (41 pass), and so did the fast tier for this diff (433 tests across 23 files, 0 fail).

What I chose not to do: I didn't change any test, and nothing else in the pull changes.

To try it: grep -rn app-tile src docs finds no stylesheet rule or §5d entry. The only matches are the not-present checks in test/front.test.ts.

🤖 Generated with Claude Code

Approved — before the latest push

Dead-CSS removal, clean. No src/ markup uses any .app-tile* class (only the not-present guard at test/front.test.ts:445 mentions them). The preview serves a stylesheet with zero app-tile rules, and / answers 200 and renders without them. The DESIGN.md §5d list drops exactly the five names, so the doc and stylesheet agree. The 520px media rule keeps .app-shelf, so nothing is orphaned. Next, if you want: (1) check whether .app-shelf itself is drawn by any page, since the tiles it held are gone; (2) keep sweeping §5d for other classes no page emits.

commented

This removes the unused .app-tile rules: .app-tile, .app-tile-body, .app-tile-desc, .app-tile-look and .app-tile-name come out of src/web/style/content.ts and out of the §5d list in docs/DESIGN.md. No page draws them, and the existing guard at test/front.test.ts:445 already checks that none of these classes comes back. Against main, the pull is those two files only: 11 lines removed, 1 changed.

Latest merge: main had changed docs/DESIGN.md again. It added a chart row to the §5 table and edited three §5d lines: page furniture, apps/runs/crew, and studio/feed_style.ts. I kept main's version of the file and took the five .app-tile* names out of the page-furniture line. A word diff against main shows those five names as the only difference in that file. An earlier merge kept main's .fork-bar removal on the same line the same way.

Preview: an earlier preview deploy failed. I never saw its log and found no cause in the code. An empty commit (1e9bf991) redeployed it, and the preview then served the current stylesheet with no .app-tile rules.

About the earlier failure: pull #4340 failed on "the page lists every pattern both routers know, unused first, and only to an admin" (test/usage-report.test.ts:66). That test checks that /settings/usage lists every route pattern from the web and API routers, not stylesheet classes. It passes on the merged tree, but I didn't confirm what made it fail before.

Checked locally after this merge: bun x tsc --noEmit and bun scripts/design-lint.ts are clean, and bun test on test/front.test.ts, test/usage-report.test.ts and test/design*.test.ts gives 41 pass, 0 fail.

What I chose not to do: I didn't change any test, and nothing else in the pull changes.

To try it: grep -rn app-tile src docs finds no stylesheet rule or §5d entry. The only matches are the not-present checks in test/front.test.ts.

🤖 Generated with Claude Code

Approved

Approved. The preview stylesheet has no .app-tile rules and the front page markup draws none, so nothing visible changes. The removal is complete, DESIGN.md §5d lists match, and test/front.test.ts:445 guards against the classes returning. Next: (1) .app-shelf is still in §5d and styled; confirm the front page still draws it, otherwise remove it as well. (2) Keep trimming the §5d lists the same way, one small pull at a time.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs