Public: anyone can read this; the crew can change it.
Design: the flags page's forms use the design system, and flag-form leaves §5d #4413
Check · Review · Land · Live done — Landed and live in production.
I merged `main` into the branch and pushed it, so #4413 should merge cleanly again. Only `docs/DESIGN.md` conflicted. I ran the design lint, which passes, and 5 test files (design audit, lint and map, flags, flags-settings), which pass. A full `bun test` run timed out in the sandbox, so I didn't see it finish, and the forge's check will run the whole suite on this push.
shipped production is serving it deploy 97ab7b8
The flags page's form now uses row-fields without .flag-form. That change is already pushed, so this run added no new commits.
What changed
src/web/pages/flags.ts: the flag form drops.flag-formand keepsrow-fieldsinside thesetting-listrow. It posts the same fields to/settings/flags:name,forgeand the other selects, unchanged.src/web/style/content.ts: the.flag-formrules are gone.docs/DESIGN.md:.flag-formis struck from §5d.test/flags-settings.test.ts: a test assertsflag-formis absent from the page's HTML.
Checks
git grep flag-formfinds only that test, so no other page borrowed the class.bun scripts/design-lint.tspasses.test/flags-settings.test.tspasses (7 tests).- The full
bun testdid not finish in 600 s here, so I did not see its result. bun x tsc --noEmitran in the same command, but its output was lost when that command timed out.
Not done
- No before/after screenshots (light and dark, desktop and 390 px). The sandbox can't take them; the preview for this pull can.
- I did not run
design-lint --update, since nothing needed re-baselining. - The parked-by-crew comment says the check stayed red twice. I had no access to its log, so I could not tell why.
To try
Open /settings/flags on the preview and submit a flag row.
I merged main into the branch and pushed it, so #4413 should merge cleanly again. Only docs/DESIGN.md conflicted. I ran the design lint, which passes, and 5 test files (design audit, lint and map, flags, flags-settings), which pass. A full bun test run timed out in the sandbox, so I didn't see it finish, and the forge's check will run the whole suite on this push.
The conflict was the §5d "page furniture" class list in docs/DESIGN.md. I kept main's list, which no longer has .fork-bar (removed in #4353), and left out .flag-form, which this pull removes. The branch is now 4 lines changed against main, and the remote head matches local.
The merge commit that went up has an odd message: "The flags page's form now uses row-fields without .flag-form. That change is already pushed, so this run added no new commits." Something other than my commit command created it, because my own commit found nothing left to commit. The content is the merge above.
Pull description: The flags page's forms draw the design system's row-fields instead of a private .flag-form, and the class leaves the stylesheet (src/web/style/content.ts) and the §5d list in docs/DESIGN.md. test/flags-settings.test.ts gains two assertions for it. To try it, open /flags on the preview at https://lab--4413--forge-trevato-apps.open-platform.sh. This update only merges main and resolves the doc conflict; I left nothing else out.
The flags form now uses the shared .row-fields inside .setting-list. components.ts:448-455 already wrap the controls, cap input width, and give the trail its own line under 640px. That replaces everything the private .flag-form rules did, so a 360px phone still works. The mutation is still a POST form, nothing depends on JavaScript, and the class is gone from content.ts and DESIGN.md §5d. The new assertions would fail without the change. I did not render the page: the preview answered 303 to /settings/flags without a session, and I did not run the tests. Next: (1) check the flag row at 360px in the preview, with before/after screenshots in the pull; (2) the 8rem flex-basis for the selects went with the old rule, so give the selects a shared basis in .row-fields if they look cramped.
The work for #3847 is already on the branch and pushed. I added nothing this run, and the branch matches origin.
- What changed: the flags page's form in
src/web/pages/flags.tsnow drawsrow-fieldsinside thesetting-listrow, without.flag-form. It posts the same fields to/settings/flags..flag-form's rules are gone fromsrc/web/style/content.ts, and the name is struck fromdocs/DESIGN.md§5d. - Test:
test/flags-settings.test.tsassertsflag-formis absent from the page's HTML. - Where it's used:
git grep flag-formfinds only that test, so no other page borrowed the class. - Checks:
bun scripts/design-lint.tspassed earlier on this branch. The flags test file passed (7 tests). I did not re-run either this time. - Not run: the full
bun testtimed out here at 600 s on an earlier run, andtscoutput was lost when that command timed out. The forge's check runs both. - Not done:
- No before/after screenshots in light and dark, at desktop and 390 px wide. This sandbox can't take them, so the preview has to supply them. - I could not tell why the check stayed red before the pull was parked, because I can't read its log. The issue carries no new comment since the park note.
- To try: open
/settings/flagson the preview and submit a flag row.
Handed to a person by the crew: this pull is approved, but 2 runs to bring it up to date with main ended without a push, so no more start here. Conflicting files: docs/DESIGN.md. Merge main into it, or say what to try and assign it back to the crew. (The forge posts this under your name; you did not write it.)
The flags page's form change for #3847 is already on the branch and pushed. This run added no commits, and the branch matches origin.
- What changed: the form in
src/web/pages/flags.tsnow drawsrow-fieldsinside thesetting-listrow, without.flag-form. It posts the same fields to/settings/flags..flag-form's rules are gone fromsrc/web/style/content.ts, and the name is struck fromdocs/DESIGN.md§5d.test/flags-settings.test.tsassertsflag-formis absent from the page's HTML. - Where it's used:
git grep flag-formfinds only that test, so no other page borrowed the class and nothing had to be kept. - Checks run this time:
- bun scripts/design-lint.ts passes.
- test/flags-settings.test.ts passes (7 tests).
- I did not re-run tsc or the full bun test; an earlier full run timed out here at 600 s. The forge's check runs both.
- Not done:
- Screenshots: there are no before/after screenshots in light and dark at desktop and 390 px wide, because this sandbox can't take them. The preview has to supply them. - Red check: I can't see why the forge check stayed red before the pull was parked, because its log isn't reachable from here. The issue has no new comment since the park note.
- To try: open
/settings/flagson the preview and submit a flag row.
Steward: this pull is approved but no longer merges into main. #5932 split src/http/mcp.ts into one file per tool, and several other shared files moved. Bring it up to date with main: merge main and resolve keeping this pull's intent. If it adds or changes an MCP tool, move that into its own file in the new layout and regenerate the docs. Then let the check run. If the change is already on main, say so and close the pull.
Steward: this approved pull no longer merges into main (the per-tool mcp split and other landings moved shared files). Merge main and resolve, keeping this pull's intent. If it adds or changes an MCP tool, it goes in its own file in the new layout. Then let the check run. If the change is already on main, say so and close the pull.
The flags page's forms now use the design system's row-fields, and the private .flag-form class is gone from the stylesheet (src/web/style/content.ts). This push merges current main into the branch.
- Conflicts:
mainhad splitdocs/DESIGN.mdintodocs/design/sections/, so I tookmain's index file. Noflag-formmention is left indocs/orsrc/, so nothing in §5d needed editing. Insrc/web/style/content.ts,mainhad already deleted the neighbouring.frozen/.headroom/.backups-block, and I kept that deletion. - Tests:
test/flags-settings.test.tsstill asserts that the flags page markup has noflag-form.test/flags-settings.test.tsandtest/flags.test.tspass (16 tests),bun x tsc --noEmitis clean, andbun scripts/design-lint.tspasses. I did not run the fullbun test, so the forge's check on this push is its first run. - Left out: nothing; this update only brings the branch up to date.
To try it, open /flags on the preview at https://lab--4413--forge-trevato-apps.open-platform.sh.
The pull is now only two test assertions. The flags form already draws row-fields on this head (src/web/pages/flags.ts:91), and no flag-form is left in src or docs. The assertions would fail if the private class came back. The preview answers /settings/flags with a 303 for a signed-out request, which is expected; I could not look at the signed-in form. Next: (1) a before/after screenshot of the form at 360px, so the layout is confirmed on a phone; (2) a test that Save and Default stay keyboard-reachable inside row-fields.
I merged
maininto the branch and pushed it, so #4413 should merge cleanly again. Onlydocs/DESIGN.mdconflicted. I ran the design lint, which passes, and 5 test files (design audit, lint and map, flags, flags-settings), which pass. A fullbun testrun timed out in the sandbox, so I didn't see it finish, and the forge's check will run the whole suite on this push.The conflict was the §5d "page furniture" class list in
docs/DESIGN.md. I keptmain's list, which no longer has.fork-bar(removed in #4353), and left out.flag-form, which this pull removes. The branch is now 4 lines changed againstmain, and the remote head matches local.The merge commit that went up has an odd message: "The flags page's form now uses
row-fieldswithout.flag-form. That change is already pushed, so this run added no new commits." Something other than my commit command created it, because my own commit found nothing left to commit. The content is the merge above.Pull description: The flags page's forms draw the design system's
row-fieldsinstead of a private.flag-form, and the class leaves the stylesheet (src/web/style/content.ts) and the §5d list indocs/DESIGN.md.test/flags-settings.test.tsgains two assertions for it. To try it, open/flagson the preview at https://lab--4413--forge-trevato-apps.open-platform.sh. This update only mergesmainand resolves the doc conflict; I left nothing else out.Continues #4413