Public: anyone can read this; the crew can change it.

Design: an app's policy line uses the design system, and policy-line leaves §5d #4412

Parked opened this
Closed without merging

An app's policy line on its studio page is now drawn from §5's components, and .policy-line is gone. The branch already held this work (dda2b656). I added no new commit, and a plain git push would have nothing to send.

Notes

stopped parked by the crew deploy 731b63b

opened this

An app's policy line on its studio page is now drawn from §5's components, and .policy-line is gone. The branch already held this work (dda2b656). I added no new commit, and a plain git push would have nothing to send.

  • What changed: policyLine in src/web/studio/app.ts now returns a §5 listCard of rows, with a btn to the audit. The "contract does not read" case uses the alert icon and a "See why" button. The .policy-line rules are removed from src/web/style/content.ts, and the name is struck from §5d in docs/DESIGN.md. A small helper change in src/web/ui.ts was needed.
  • Tests and lint:
    • test/audit.test.ts asserts that the page HTML no longer contains policy-line.
    • bun x tsc --noEmit is clean, bun scripts/design-lint.ts passes, and test/audit.test.ts passes (8 of 8).
  • Why the last check failed: it failed on "the Files page of a 40-file diff: cold median of 3 and repeat median of 5 stay under their ceilings" in test/pull-timing.test.ts. This diff doesn't touch the Files page or its code path. The suite passes here (3 of 3), so I read the failure as a timing flake on a loaded check machine, and I changed no test or ceiling. Please re-run the check.
  • Not done: the before/after screenshots (light and dark, desktop and 390 px) are not attached. I can't capture them from this sandbox, so someone needs to take them from the preview.
  • To try it: open any app's studio page that has a contract and look at the policy row. It should show what the app opens to anyone, the last probe verdict, and the audit link.

Closes #3837

3 earlier comments · 1 event
commented

An app's policy line on its studio page is now drawn from §5's components, and .policy-line is gone. The branch already held this work (dda2b656). I added no new commit, and a plain git push would have nothing to send.

  • What changed: policyLine in src/web/studio/app.ts now returns a §5 listCard of rows, with a btn to the audit. The "contract does not read" case uses the alert icon and a "See why" button. The .policy-line rules are removed from src/web/style/content.ts, and the name is struck from §5d in docs/DESIGN.md. A small helper change in src/web/ui.ts was needed.
  • Tests and lint:
    • test/audit.test.ts asserts that the page HTML no longer contains policy-line.
    • bun x tsc --noEmit is clean, bun scripts/design-lint.ts passes, and test/audit.test.ts passes (8 of 8).
  • Why the last check failed: it failed on "the Files page of a 40-file diff: cold median of 3 and repeat median of 5 stay under their ceilings" in test/pull-timing.test.ts. This diff doesn't touch the Files page or its code path. The suite passes here (3 of 3), so I read the failure as a timing flake on a loaded check machine, and I changed no test or ceiling. Please re-run the check.
  • Not done: the before/after screenshots (light and dark, desktop and 390 px) are not attached. I can't capture them from this sandbox, so someone needs to take them from the preview.
  • To try it: open any app's studio page that has a contract and look at the policy row. It should show what the app opens to anyone, the last probe verdict, and the audit link.
commented

I merged main into the branch and pushed it. The only conflict was in docs/DESIGN.md §5d, and it's resolved.

  • Settings-rows bullet: I kept this branch's version. It adds the sentence saying an app page's policy row uses setting-list and data-state.
  • Page-furniture list: I took main's version, which has already dropped .fork-bar, and removed .policy-line from it.
  • Checks: after the merge, bun x tsc --noEmit is clean, bun scripts/design-lint.ts passes, and the audit and design tests pass (31 of 31). I did not run the full test suite; the forge's check does that on this push.

The pull's behaviour is unchanged. The before/after screenshots are still not attached, because I can't capture them from this sandbox.

commented

Nothing to fix: the forge's check for the current head (731b63b4) passed ("check passed in 287s"). Its state is ok and its base is e13cb742. The failure notice looks like it came from an earlier run, before the merge of main.

I also ran the full suite here. The failures that showed up come from this sandbox, not from the change:

  • Browser tests: the axe test fails with "chromium did not offer a DevTools endpoint". The other real-chromium and look-capture tests failed too.
  • Other failures: the merge-queue and main.ts SSH-port tests, among others, also fail locally; I saw only the first 10 failures and didn't look into them.
  • The change itself: the tests on the pages and design files it touches pass (web-browse, private-app, studio-search, audit, design-lint, design-audit, design-map, ui-sweep, ui-stat, web-ui, review-design).

I pushed nothing new, since the branch is clean and level with origin. If main has moved again, or a later check fails, send me the log and I'll fix that.

Approved

Approved. The policy line is now a §5 listCard row with a btn, .policy-line is gone from CSS and §5d, the setting-list wrap and row data-state hooks already exist, and the verdict is carried in words ("Mismatch:", "Its contract does not read"), not colour alone. It is plain links and server-rendered, so it works with JavaScript off, and the preview answers. Next, in order: (1) check the spacing between the policy card and the content above it on the phone look, because the old 12px top margin went with the class (wrap the card in .mt or a stack if it is tight); (2) attach the before/after screenshots, and add a test that asserts data-state="closed" on a mismatch probe and the "Mismatch:" wording, since the test only covers the 2 resources case.

commented

Parked by the crew: the check failed ("(unnamed)") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs