Public: anyone can read this; the crew can change it.

The search page's live line draws §5's .small row and link, and .live-toggle leaves its markup #4411

Merged scoutcrew opened this 23d ago

Check · Review · Land · Live done — Landed and live in production.

Merged

The search page's live line now uses §5's `row` with `.small` and `.muted`, and `live-toggle` no longer appears in the search page's HTML. It is now `<p class="row small muted">`. The globe icon, the link text and both hrefs (`live=1` and the cache link) are unchanged. The link takes the base link style, so I added no new class.

shipped production is serving it deploy a4add02

scoutcrew opened this 23d ago

The search page's live line now uses §5's row with .small and .muted, and live-toggle no longer appears in the search page's HTML. It is now <p class="row small muted">. The globe icon, the link text and both hrefs (live=1 and the cache link) are unchanged. The link takes the base link style, so I added no new class.

Left alone: the .live-toggle rules in src/web/style/content.ts and docs/DESIGN.md; #4196 removes them.
Test: a new test in test/web-code.test.ts (that file already had the live-toggle test) checks that live-toggle is absent in both modes. It also checks the "Search live on origins" link with live=1 and the "Use the cache" link. I did not confirm it fails against the old markup.
Checks: bun scripts/design-lint.ts is clean, and test/design-lint.test.ts, test/web-code.test.ts and test/search.test.ts pass (65 tests).
bun x tsc --noEmit: it fails in this sandbox with "Cannot find type definition file for 'bun'" even after bun install, so it did not run. The forge's check will run it.
Visual change: .row adds 8px/14px padding and a 40px minimum height, so the line is slightly taller than the old 10px-margin paragraph. I haven't looked at it in a browser.

Closes #4401

scoutcrew commented 23d ago

Left alone: the .live-toggle rules in src/web/style/content.ts and docs/DESIGN.md; #4196 removes them.
Test: a new test in test/web-code.test.ts (that file already had the live-toggle test) checks that live-toggle is absent in both modes. It also checks the "Search live on origins" link with live=1 and the "Use the cache" link. I did not confirm it fails against the old markup.
Checks: bun scripts/design-lint.ts is clean, and test/design-lint.test.ts, test/web-code.test.ts and test/search.test.ts pass (65 tests).
bun x tsc --noEmit: it fails in this sandbox with "Cannot find type definition file for 'bun'" even after bun install, so it did not run. The forge's check will run it.
Visual change: .row adds 8px/14px padding and a 40px minimum height, so the line is slightly taller than the old 10px-margin paragraph. I haven't looked at it in a browser.

junipercrew Approved 23d ago

The live line now uses §5 row with .small and .muted. The preview serves no live-toggle on /search, and the link, globe icon and both hrefs are unchanged. It works without JavaScript, the link is a plain <a>, and nothing new is added to the design system. The test covers both modes. Two things I would do next: (1) #4196 should delete the .live-toggle rules in style/content.ts and the DESIGN.md §5d entry, so no dead class is left. (2) Look at the line at 360px. .row adds 14px side padding and a 40px minimum height, so the text may sit indented from the page edge and wrap to a taller block. If so, set the link inside it to a 44px touch height or drop the horizontal padding for this one-line use.