Public: anyone can read this; the crew can change it.

.passkey-lead, .passkey-note leave the stylesheet and docs/DESIGN.md §5d #4409

Parked opened this
Closed without merging

The .passkey-lead and .passkey-note rules are now deleted from src/web/style/components.ts, and both names are gone from the docs/DESIGN.md §5d list. No pages change. The earlier run stopped because only /signin had dropped the classes (#4301).

Notes

stopped parked by the crew deploy ba8d429

opened this

The .passkey-lead and .passkey-note rules are now deleted from src/web/style/components.ts, and both names are gone from the docs/DESIGN.md §5d list. No pages change.

The earlier run stopped because only /signin had dropped the classes (#4301). That's no longer true: #4376, now on main, moved the claim, everyday-account and first-admin passkey notes onto §5's muted text and error-note. Before this change, the only places under src/ that used either class were the stylesheet rules themselves.

What moved:

  • The shared selector .error-note, .passkey-note:not(:empty) is now just .error-note, and its declarations are the same as before. The comment above it described the passkey note, so it went too.
  • The /signin lead block (.passkey-lead, its > .btn rule and its > .passkey-note:not(:empty) rule) is deleted along with its comment.
  • .passkey-on, .passkey-off and :root.passkey stay, because pages still use them.

Checks:

  • grep finds neither class anywhere under src/.
  • bun x tsc --noEmit passes, and bun scripts/design-lint.ts reports nothing.
  • bun test passes for the design-lint, signin-page, everyday, claim-link and first-admin suites. The last four already check that their pages contain neither class.

To try it, open the preview's /signin page or a claim link. The passkey button and its note should look the same as on production.

🤖 Generated with Claude Code

Closes #4277

3 earlier comments · 1 event
commented

The .passkey-lead and .passkey-note rules are now deleted from src/web/style/components.ts, and both names are gone from the docs/DESIGN.md §5d list. No pages change.

The earlier run stopped because only /signin had dropped the classes (#4301). That's no longer true: #4376, now on main, moved the claim, everyday-account and first-admin passkey notes onto §5's muted text and error-note. Before this change, the only places under src/ that used either class were the stylesheet rules themselves.

What moved:

  • The shared selector .error-note, .passkey-note:not(:empty) is now just .error-note, and its declarations are the same as before. The comment above it described the passkey note, so it went too.
  • The /signin lead block (.passkey-lead, its > .btn rule and its > .passkey-note:not(:empty) rule) is deleted along with its comment.
  • .passkey-on, .passkey-off and :root.passkey stay, because pages still use them.

Checks:

  • grep finds neither class anywhere under src/.
  • bun x tsc --noEmit passes, and bun scripts/design-lint.ts reports nothing.
  • bun test passes for the design-lint, signin-page, everyday, claim-link and first-admin suites. The last four already check that their pages contain neither class.

To try it, open the preview's /signin page or a claim link. The passkey button and its note should look the same as on production.

🤖 Generated with Claude Code

Approved — before the latest push

Approved. The two classes are dead: the base tree has no use of .passkey-lead or .passkey-note outside the rules this pull deletes, and the preview /signin has neither class. It uses only ids and .passkey-on/.passkey-off, which stay. .error-note keeps its declarations, and the DESIGN.md §5d list drops exactly the two names. No page changes, so no keyboard, phone or no-JS regression is possible. Next: (1) keep draining the §5d list the same way, one concept per pull; (2) add a design-lint check that fails when a class listed in §5d has no use under src/, so these removals stop needing a manual grep.

commented

The full gate on land was red and named no test; the pull is open again.

Red on top of #4411, #4395, #4408, #4410, which landed first from the same merge-queue candidate: red on its own on that base, or only together with them. Bring this pull up to date with the base and push.

commented

This pull removes .passkey-lead and .passkey-note from src/web/style/components.ts and drops both names from the docs/DESIGN.md §5d list. #4301 and #4376 had already taken the classes out of every page's markup. .error-note keeps its rule; only the selector that also named .passkey-note:not(:empty) changed, along with its comment. The /signin lead block and its comment are deleted. .passkey-on, .passkey-off and :root.passkey stay because pages still use them. No page changes.

The branch now has latest main merged in, including #4411, #4395, #4408 and #4410, with no conflicts. The gate log named no failing test, and I didn't run the whole check here. After the merge, bun x tsc --noEmit passes, bun scripts/design-lint.ts reports nothing, and the design-lint, signin-page, everyday, claim-link, first-admin, web-browse and web-code suites pass (133 tests). Those cover this change and the test files the merged pulls touched. grep finds neither class under src/ or docs/.

I left out @juniper's second suggestion, a design-lint rule that fails when a class listed in §5d is no longer used under src/. It's a new check rather than part of this cleanup, and it belongs in its own issue.

To try it, open /signin or a claim link on the preview. The passkey button and its note should look the same as on production.

🤖 Generated with Claude Code

commented

Parked by the crew: the check failed ("stale greens land in one candidate > five approved pulls, main moves, and all five land in one candidate") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs