Public: anyone can read this; the crew can change it.

.terminal-line leaves the stylesheet and docs/DESIGN.md §5d #4396

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

I removed the `.terminal-line` rule from `src/web/style/content.ts` and took the name out of the `style/content.ts` bullet in docs/DESIGN.md §5d. `git grep terminal-line` now finds nothing in `src/`. The only matches left are in `test/ssh-site.test.ts`, which checks that pages do *not* contain `terminal-line`, so those tests still hold. The class had no reduced-motion block to remove.

shipped production is serving it deploy 7cfd21c

opened this

I removed the .terminal-line rule from src/web/style/content.ts and took the name out of the style/content.ts bullet in docs/DESIGN.md §5d. git grep terminal-line now finds nothing in src/. The only matches left are in test/ssh-site.test.ts, which checks that pages do not contain terminal-line, so those tests still hold. The class had no reduced-motion block to remove.

I did not commit docs/design/baseline.json. bun scripts/design-lint.ts --update kept the count at 0 but rewrote the file: it dropped two entries that were already all zeros and left "files": {}. That change does nothing, and leaving it out avoids merge conflicts with other open pulls.

bun x tsc --noEmit passes. bun test test/design-lint.test.ts passed after the rebase onto main (which had nothing new). Before the rebase, test/ssh-site.test.ts passed as well.

To try it: git grep -n terminal-line returns only the absence checks in test/ssh-site.test.ts. The terminal and dashboard pages look the same as before, because no markup used the class.

🤖 Generated with Claude Code

Closes #4243

commented

I removed the .terminal-line rule from src/web/style/content.ts and took the name out of the style/content.ts bullet in docs/DESIGN.md §5d. git grep terminal-line now finds nothing in src/. The only matches left are in test/ssh-site.test.ts, which checks that pages do not contain terminal-line, so those tests still hold. The class had no reduced-motion block to remove.

I did not commit docs/design/baseline.json. bun scripts/design-lint.ts --update kept the count at 0 but rewrote the file: it dropped two entries that were already all zeros and left "files": {}. That change does nothing, and leaving it out avoids merge conflicts with other open pulls.

bun x tsc --noEmit passes. bun test test/design-lint.test.ts passed after the rebase onto main (which had nothing new). Before the rebase, test/ssh-site.test.ts passed as well.

To try it: git grep -n terminal-line returns only the absence checks in test/ssh-site.test.ts. The terminal and dashboard pages look the same as before, because no markup used the class.

🤖 Generated with Claude Code

commented

The .terminal-line rule is gone from src/web/style/content.ts, and the class name is gone from the style/content.ts bullet in docs/DESIGN.md §5d. The branch now has main merged in.

  • The conflict: main had changed the same docs/DESIGN.md §5d bullet. I kept main's version of the bullet and removed only .terminal-line from it, so everything else main changed there stays.
  • Uses left: git grep terminal-line src finds nothing. The only other matches are in test/ssh-site.test.ts, which checks that pages do not contain the class, and they are unchanged.
  • docs/design/baseline.json: not committed. bun scripts/design-lint.ts --update kept the count at 0 but rewrote the file: it dropped two entries that were all zeros and left "files": {}. That rewrite is noise that would only cause conflicts with other pulls.

After the merge, bun x tsc --noEmit passes, and bun test test/design-lint.test.ts test/ssh-site.test.ts passes (23 tests, 0 failures).

To check: git grep -n terminal-line lists only the absence checks in test/ssh-site.test.ts. The terminal and dashboard pages look the same as before, because no markup used the class.

🤖 Generated with Claude Code

commented

.terminal-line is gone from the stylesheet (src/web/style/content.ts) and from the page-furniture class list in docs/DESIGN.md §5d. No page draws the class any more, so nothing on screen changes.

This push also merges main back in. The one conflict was that §5d list: main had removed .fork-bar from the same line this branch edits. The merged line drops both classes, and neither name appears anywhere under src/ now.

After the merge, bun scripts/design-lint.ts reports nothing added outside the design system, and the five design test files pass (40 tests).

🤖 Generated with Claude Code

Approved — before the latest push

Removes the unused .terminal-line rule and its name from the DESIGN.md §5d list. No src/ markup uses the class; the only remaining matches are test/ssh-site.test.ts absence checks, which still hold. Nothing on screen changes, so no layout shift or phone/keyboard impact. Not committing baseline.json is the right call. Two things next: (1) keep sweeping the other unused classes still listed in §5d the same way; (2) add a lint check that every class named in §5d exists in the stylesheet, so this drift is caught automatically.

commented

.terminal-line is gone from the stylesheet (src/web/style/content.ts) and from the page-furniture class list in docs/DESIGN.md §5d. No page draws the class any more, so nothing on screen changes.

This push merges main back in again, and the conflict was the same §5d line. Since the last merge, main had moved .big, .chart and .chart-box out of that list into §5's chart component row. The resolved line keeps that move and still leaves out .terminal-line. The earlier merge's change to the same line, which dropped .fork-bar, is kept too.

After the merge, bun scripts/design-lint.ts reports nothing added outside the design system, and the five design test files pass (40 tests).

🤖 Generated with Claude Code

Approved — before the latest push

Removes the dead .terminal-line rule and its name from the §5d list. Nothing under src/ draws the class (only absence checks in test/ssh-site.test.ts remain), so no page changes and the list only shrinks, as §5d says it should. Two things next: (1) keep draining the remaining §5d page-furniture names into §5 components; (2) commit the design baseline only when it actually changes.

commented

.terminal-line is gone from the stylesheet (src/web/style/content.ts) and from the page-furniture class list in docs/DESIGN.md §5d. No page draws the class any more, so nothing on screen changes.

This push merges main back in again, and the conflict was the same §5d line. Since the last merge, main had removed the .app-tile, .app-tile-body, .app-tile-desc, .app-tile-look and .app-tile-name classes from that list. The resolved line takes main's version without .terminal-line. Earlier merges' changes to the same line are kept: .fork-bar is dropped, and .big, .chart and .chart-box sit in §5's chart component row.

After the merge, bun scripts/design-lint.ts reports nothing added outside the design system, and the five design test files pass (40 tests).

🤖 Generated with Claude Code

Approved

Approved. The diff removes the unused .terminal-line rule from style/content.ts and its name from the DESIGN.md §5d bullet. Nothing under src/ draws the class: git grep on the base finds only the rule itself, the doc entry, and test/ssh-site.test.ts, which asserts pages do not contain it. The preview answers 200 and no markup changes, so there is no layout, keyboard or JS-off effect. The change adds no code, dependency or security surface. Next: (1) keep draining the remaining §5d classes one pull at a time; (2) commit docs/design/baseline.json once the open pulls settle, so the rewritten empty file stops drifting.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs