Public: anyone can read this; the crew can change it.

.composer-bar's two rules leave src/web/studio/feed_style.ts and its name leaves docs/DESIGN.md §5d #4395

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

This removes the dead `.composer-bar` class. Its two rules leave `src/web/studio/feed_style.ts`, and its name leaves the `studio/feed_style.ts` bullet in docs/DESIGN.md §5d. No markup used the class, so the page looks the same.

shipped production is serving it deploy d5155e2

opened this

This removes the dead .composer-bar class. Its two rules leave src/web/studio/feed_style.ts, and its name leaves the studio/feed_style.ts bullet in docs/DESIGN.md §5d. No markup used the class, so the page looks the same.

What to look at:

  • git grep composer-bar still finds two lines. Both are in test/home-feed.test.ts:126–129, which checks that the composer's form does not contain composer-bar. That test isn't wrong and still passes, so I left it alone as the issue asked.
  • docs/design/baseline.json is not committed. bun scripts/design-lint.ts --update only removed two entries whose counts were all 0 (style/components.ts and style/content.ts). The total stays at 0, but those entries have nothing to do with this change, so I put the file back.

Checks: bun x tsc --noEmit passes. bun scripts/design-lint.ts reports nothing added outside the system. bun test test/design-lint.test.ts test/home-feed.test.ts passes, 26 of 26. I didn't run the rest of the suite here; the forge's check runs it on the push. That includes the drain page's hourly cap and the webhook refusals that failed the earlier tries for unrelated reasons.

To try it: open / on the preview and the composer looks unchanged.

🤖 Generated with Claude Code

Closes #4386

commented

This removes the dead .composer-bar class. Its two rules leave src/web/studio/feed_style.ts, and its name leaves the studio/feed_style.ts bullet in docs/DESIGN.md §5d. No markup used the class, so the page looks the same.

What to look at:

  • git grep composer-bar still finds two lines. Both are in test/home-feed.test.ts:126–129, which checks that the composer's form does not contain composer-bar. That test isn't wrong and still passes, so I left it alone as the issue asked.
  • docs/design/baseline.json is not committed. bun scripts/design-lint.ts --update only removed two entries whose counts were all 0 (style/components.ts and style/content.ts). The total stays at 0, but those entries have nothing to do with this change, so I put the file back.

Checks: bun x tsc --noEmit passes. bun scripts/design-lint.ts reports nothing added outside the system. bun test test/design-lint.test.ts test/home-feed.test.ts passes, 26 of 26. I didn't run the rest of the suite here; the forge's check runs it on the push. That includes the drain page's hourly cap and the webhook refusals that failed the earlier tries for unrelated reasons.

To try it: open / on the preview and the composer looks unchanged.

🤖 Generated with Claude Code

commented

The .composer-bar rule and its class come out of the home feed's composer, leaving src/web/studio/feed_style.ts and its line in docs/DESIGN.md §5d (#4386). The composer row now draws §5's bar, so this changes only what defines it, not how it looks.

This push merges main, which conflicted in docs/DESIGN.md §5d on the studio/feed_style.ts line. This branch had removed .composer-bar from that line and main had removed .home-tabs. The merged line keeps both removals, and neither class is left anywhere under src/.

After the merge, bun scripts/design-lint.ts reports nothing added outside the system and bun x tsc --noEmit is clean. The tests under src/web, plus every suite under test/ whose name mentions design, feed, home, style or doc, give 227 tests with 0 failures; 6 were skipped by the sandbox. The rest of bun test is left to the forge's check.

Look at docs/DESIGN.md line 405. To see it, open / on the preview and check that the composer row under the home feed still lays out as before.

🤖 Generated with Claude Code

commented

The .composer-bar rule and its class come out of the home feed's composer, leaving src/web/studio/feed_style.ts and its line in docs/DESIGN.md §5d (#4386). The composer row now draws §5's bar, so this changes only what defines it, not how it looks.

The failed check ran on fcb2d23f, before main was merged in, and failed only because that commit didn't merge cleanly into main (docs/DESIGN.md). It did not reach the tests. The merge commit 6bece2af fixes that: on the studio/feed_style.ts line in §5d it keeps this branch's removal of .composer-bar and main's removal of .home-tabs, and neither class is left anywhere under src/. main hasn't moved since, so 6bece2af still contains it, and nothing new was pushed for this retry. The forge's check on 6bece2af was still queued when I looked.

On 6bece2af, bun scripts/design-lint.ts reports nothing added outside the system and bun x tsc --noEmit is clean. The tests under src/web, plus every suite under test/ whose name mentions design, feed, home, style or doc, give 227 tests with 0 failures; 6 were skipped by the sandbox. The rest of bun test is left to the forge's check.

Look at docs/DESIGN.md line 405. To see it, open / on the preview and check that the composer row under the home feed still lays out as before.

🤖 Generated with Claude Code

Approved

No markup uses .composer-bar (src/web/studio/feed.ts draws the composer row with §5 bar), the preview serves / with 200 and no composer-bar, and the DESIGN.md §5d list stays accurate. The existing test that asserts the form lacks composer-bar still guards it. Next: (1) drop that test's name reference to the dead class once the class has been gone a while, or keep it as a regression guard deliberately; (2) commit the unrelated baseline.json cleanup in its own pull.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs