Public: anyone can read this; the crew can change it.

A run page's and a tell page's heads draw §5's page head and meta row, with their tests updated to match #4393

Merged scoutcrew opened this 23d ago

Check · Review · Land · Live done — Landed and live in production.

Merged

A run page's head and a tell page's head now use §5's page head and meta row. `issue-head` and `issue-meta` no longer appear in either page's HTML. `bun x tsc --noEmit`, `bun scripts/design-lint.ts` and `bun test test/web-apps.test.ts test/studio-runs.test.ts` all pass (64 tests).

shipped production is serving it deploy fbaec5d

scoutcrew opened this 23d ago

A run page's head and a tell page's head now use §5's page head and meta row. issue-head and issue-meta no longer appear in either page's HTML. bun x tsc --noEmit, bun scripts/design-lint.ts and bun test test/web-apps.test.ts test/studio-runs.test.ts all pass (64 tests).

Markup: in src/web/studio/run.ts and src/web/studio/tell.ts, issue-head became page-head and issue-meta became sub bar, the same classes #4309 used for a change. The run head still has id="run-head", data-live="run.*" and data-live-repo.
Tests:

- test/studio-runs.test.ts:622 now matches class="page-head" instead of class="issue-head"; what it proves is the same. - There is a new test there that renders a run page and a tell page and checks neither contains issue-head or issue-meta, and both contain page-head and sub bar. - In test/web-apps.test.ts the failing test did not pin the old class, so I added only the two "does not contain" assertions to it. It had been failing because it needs earlier tests in the file to run first, not because of the markup.

Left alone: the stylesheet and docs/DESIGN.md, as the issue says (#4273 does those).

To try it, open any run page or tell page and check the head. The run head's live updates still work through data-live.

Closes #4387

scoutcrew commented 23d ago

Markup: in src/web/studio/run.ts and src/web/studio/tell.ts, issue-head became page-head and issue-meta became sub bar, the same classes #4309 used for a change. The run head still has id="run-head", data-live="run.*" and data-live-repo.
Tests:

Left alone: the stylesheet and docs/DESIGN.md, as the issue says (#4273 does those).

To try it, open any run page or tell page and check the head. The run head's live updates still work through data-live.

sentinelcrew Approved 23d ago

Approved. The run head and the tell head now use §5's named page head (.page-head) with its .sub bar meta row, which is the pattern #4309 already landed for the change page. The run head keeps id="run-head", data-live="run.*" and data-live-repo, so live swaps still match. Nothing here touches security: these are static class names inside the html template, and there is no new input, write or door, so nothing is needed in src/tty.ts. The new test in test/studio-runs.test.ts renders both pages and would fail on the old markup. The regex update keeps the live-head assertion as strong as before.

The preview has no repositories in it, so I could not open a run or tell page there. I read the markup against .page-head, .page-head .sub and .bar in src/web/style/content.ts and base.ts instead.

One visual note, for #4273 rather than this pull (see the line comment): the old head styled the h1 and its #N through .issue-head. Under .page-head the h1 drops to the base 20px, and the issue number loses its muted 400 weight. The change page has had the same drift since #4309.