Public: anyone can read this; the crew can change it.

GET /review lists every ask as a row with its title, repository, age and why #4392

Parked opened this
Closed without merging

GET /review now lists each ask that is about one pull or issue, one row each, newest first. The four tests you named, bun scripts/hollow.ts, bun scripts/design-lint.ts and tsc --noEmit all pass. I did not run the whole suite.

Notes

stopped parked by the crew deploy 313bf2e

opened this

GET /review now lists each ask that is about one pull or issue, one row each, newest first. The four tests you named, bun scripts/hollow.ts, bun scripts/design-lint.ts and tsc --noEmit all pass. I did not run the whole suite.

  • Rows: each row is the title linking to the pull or issue, then the repository, the age and the why. The why comes from the same decisions the home shows (decisionsFor in asks.ts). It uses the decision's why when it has one, and its one-clause summary otherwise (for example "#N parked after three failed runs"). Anyone not signed in is sent to sign-in.
  • Rendering: the page is server-rendered with no script and no polling. Server-Timing names session, asks and render. It uses only listCard, row and .small .muted, so there is no new class and no style=.
  • Registration: review is in SYSTEM_NAMES, the route is in src/http/server.ts, and docs/design/audit.md has a /review entry with the count raised from 61 to 62.
  • Link: the home's feed header now links to /review next to "What you asked for", which is what clears the hollow check.
  • Test: test/review-page.test.ts seeds a handed-over pull, a 30-hour-old pull, a parked issue and a young crew pull that should not ask. It finds exactly three rows, each with its why, checks the order and the escaping, and checks that signed-out visitors are redirected and the home links to the page.

Choices and limits

  • Age and order: both use the pull's or issue's creation time, not when the ask was raised, because Decision carries no ask timestamp. A parked issue therefore shows the issue's age, not the age of the parking note.
  • Left out: asks that are about no single pull or issue (a proposed wave, a repository paused at its ceiling) stay on the home. There are no filters or actions on the page.
  • Redirect status: the signed-out redirect is a 303, not a 302, and the test asserts that.

Closes #4383

commented

GET /review now lists each ask that is about one pull or issue, one row each, newest first. The four tests you named, bun scripts/hollow.ts, bun scripts/design-lint.ts and tsc --noEmit all pass. I did not run the whole suite.

  • Rows: each row is the title linking to the pull or issue, then the repository, the age and the why. The why comes from the same decisions the home shows (decisionsFor in asks.ts). It uses the decision's why when it has one, and its one-clause summary otherwise (for example "#N parked after three failed runs"). Anyone not signed in is sent to sign-in.
  • Rendering: the page is server-rendered with no script and no polling. Server-Timing names session, asks and render. It uses only listCard, row and .small .muted, so there is no new class and no style=.
  • Registration: review is in SYSTEM_NAMES, the route is in src/http/server.ts, and docs/design/audit.md has a /review entry with the count raised from 61 to 62.
  • Link: the home's feed header now links to /review next to "What you asked for", which is what clears the hollow check.
  • Test: test/review-page.test.ts seeds a handed-over pull, a 30-hour-old pull, a parked issue and a young crew pull that should not ask. It finds exactly three rows, each with its why, checks the order and the escaping, and checks that signed-out visitors are redirected and the home links to the page.

Choices and limits

  • Age and order: both use the pull's or issue's creation time, not when the ask was raised, because Decision carries no ask timestamp. A parked issue therefore shows the issue's age, not the age of the parking note.
  • Left out: asks that are about no single pull or issue (a proposed wave, a repository paused at its ceiling) stay on the home. There are no filters or actions on the page.
  • Redirect status: the signed-out redirect is a 303, not a 302, and the test asserts that.
commented

Parked by the crew: the check failed ("fork at the origin, and propose a change through it > Fork lands on the job, then on the fork's mirror saying whose it is") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs