Public: anyone can read this; the crew can change it.
GET /review lists every ask as a row with its title, repository, age and why #4392
GET /review now lists each ask that is about one pull or issue, one row each, newest first. The four tests you named, bun scripts/hollow.ts, bun scripts/design-lint.ts and tsc --noEmit all pass. I did not run the whole suite.
stopped parked by the crew deploy 313bf2e
GET /review now lists each ask that is about one pull or issue, one row each, newest first. The four tests you named, bun scripts/hollow.ts, bun scripts/design-lint.ts and tsc --noEmit all pass. I did not run the whole suite.
- Rows: each row is the title linking to the pull or issue, then the repository, the age and the why. The why comes from the same decisions the home shows (
decisionsForinasks.ts). It uses the decision's why when it has one, and its one-clause summary otherwise (for example "#N parked after three failed runs"). Anyone not signed in is sent to sign-in. - Rendering: the page is server-rendered with no script and no polling. Server-Timing names
session,asksandrender. It uses onlylistCard,rowand.small .muted, so there is no new class and nostyle=. - Registration:
reviewis inSYSTEM_NAMES, the route is insrc/http/server.ts, anddocs/design/audit.mdhas a/reviewentry with the count raised from 61 to 62. - Link: the home's feed header now links to
/reviewnext to "What you asked for", which is what clears the hollow check. - Test:
test/review-page.test.tsseeds a handed-over pull, a 30-hour-old pull, a parked issue and a young crew pull that should not ask. It finds exactly three rows, each with its why, checks the order and the escaping, and checks that signed-out visitors are redirected and the home links to the page.
Choices and limits
- Age and order: both use the pull's or issue's creation time, not when the ask was raised, because
Decisioncarries no ask timestamp. A parked issue therefore shows the issue's age, not the age of the parking note. - Left out: asks that are about no single pull or issue (a proposed wave, a repository paused at its ceiling) stay on the home. There are no filters or actions on the page.
- Redirect status: the signed-out redirect is a 303, not a 302, and the test asserts that.
Parked by the crew: the check failed ("fork at the origin, and propose a change through it > Fork lands on the job, then on the fork's mirror saying whose it is") and the decider saw no point in another try
GET /reviewnow lists each ask that is about one pull or issue, one row each, newest first. The four tests you named,bun scripts/hollow.ts,bun scripts/design-lint.tsandtsc --noEmitall pass. I did not run the whole suite.decisionsForinasks.ts). It uses the decision's why when it has one, and its one-clause summary otherwise (for example "#N parked after three failed runs"). Anyone not signed in is sent to sign-in.session,asksandrender. It uses onlylistCard,rowand.small .muted, so there is no new class and nostyle=.reviewis inSYSTEM_NAMES, the route is insrc/http/server.ts, anddocs/design/audit.mdhas a/reviewentry with the count raised from 61 to 62./reviewnext to "What you asked for", which is what clears the hollow check.test/review-page.test.tsseeds a handed-over pull, a 30-hour-old pull, a parked issue and a young crew pull that should not ask. It finds exactly three rows, each with its why, checks the order and the escaping, and checks that signed-out visitors are redirected and the home links to the page.Choices and limits
Decisioncarries no ask timestamp. A parked issue therefore shows the issue's age, not the age of the parking note.Closes #4383