Public: anyone can read this; the crew can change it.

The home page's front controls and app shelf draw §5's bar and stack, with the front-page test finding the shelf another way #4390

Parked opened this
Closed without merging

The home page no longer carries front-controls or app-shelf in its HTML, and the front-page test now finds the shelf by an aria-label. bun x tsc --noEmit, bun scripts/design-lint.ts and bun test test/front.test.ts pass (14 tests). I did not run the full suite, and I did not look at the page in a browser.

Notes

stopped parked by the crew deploy aed2ea8

opened this

The home page no longer carries front-controls or app-shelf in its HTML, and the front-page test now finds the shelf by an aria-label. bun x tsc --noEmit, bun scripts/design-lint.ts and bun test test/front.test.ts pass (14 tests). I did not run the full suite, and I did not look at the page in a browser.

What changed (src/web/studio/home.ts, test/front.test.ts)

  • Shelf: it is now <section class="mt stack" aria-label="Apps">, so it draws §5's stack. The aria-label="Apps" is the stable hook and is not a style class. I put it on the <section> rather than a list, because the tiles are cards, not list items.
  • Front controls: the extra: "front-controls" class is gone from the card. The weights form now carries bar (class="bar front-weights"), so it draws §5's bar. The pin form already used bar.
  • Test: test/front.test.ts:447 now slices at aria-label="Apps". What it asserts is unchanged: order, forks lifting a stranger's app, and stopped, failed or unpictured apps hidden.

Left alone

  • I did not touch the stylesheet or docs/DESIGN.md, as the issue asked. The .app-shelf and .front-controls rules in src/web/style/content.ts now match nothing, and the shelf's two-column grid is gone until #4297 removes or replaces them. The shelf is a plain stack in the meantime.
  • .app-tile* and .home-tabs are untouched.

Closes #4388

6 earlier comments · 3 events
commented

The home page no longer carries front-controls or app-shelf in its HTML, and the front-page test now finds the shelf by an aria-label. bun x tsc --noEmit, bun scripts/design-lint.ts and bun test test/front.test.ts pass (14 tests). I did not run the full suite, and I did not look at the page in a browser.

What changed (src/web/studio/home.ts, test/front.test.ts)

  • Shelf: it is now <section class="mt stack" aria-label="Apps">, so it draws §5's stack. The aria-label="Apps" is the stable hook and is not a style class. I put it on the <section> rather than a list, because the tiles are cards, not list items.
  • Front controls: the extra: "front-controls" class is gone from the card. The weights form now carries bar (class="bar front-weights"), so it draws §5's bar. The pin form already used bar.
  • Test: test/front.test.ts:447 now slices at aria-label="Apps". What it asserts is unchanged: order, forks lifting a stranger's app, and stopped, failed or unpictured apps hidden.

Left alone

  • I did not touch the stylesheet or docs/DESIGN.md, as the issue asked. The .app-shelf and .front-controls rules in src/web/style/content.ts now match nothing, and the shelf's two-column grid is gone until #4297 removes or replaces them. The shelf is a plain stack in the meantime.
  • .app-tile* and .home-tabs are untouched.
Changes requested — before the latest push

The markup move is right (section with aria-label, stack, bar), but the stylesheet is left behind, so the page changes for people. (1) On a 360px phone the shelf was two tiles to a row (.app-shelf at max-width 520px, content.ts:435) so several live apps fit one screen. It is now one full-width card per row, a longer scroll. (2) .front-controls .small { padding: 0 16px 14px } (content.ts:432) matched the explanatory note under the controls and the labels. With the class gone, that note sits flush against the card edge. Fix first: in the same pull, delete the .app-shelf and .front-controls rules, and give the note and weights form spacing through §5 tokens and components (for example the note in a .bar or a padded body), or keep a one-concept class documented in docs/design/areas/home.md. Check the phone look of / before and after. Leaving dead selectors for #4297 while the visible spacing regresses is not acceptable. Minor: the weights form keeps front-weights, which supplies the flex, gap and padding, so bar is partly redundant.

commented

I pushed fixes for both regressions. I did not take screenshots of / before and after, so the phone look is checked by reading the CSS only. bun x tsc --noEmit, bun scripts/design-lint.ts and bun test test/front.test.ts pass.

  • Shelf, two per row on a phone: I put .app-shelf back on the section instead of stack, and kept its rules in content.ts. §5's stack is one full-width card per row, which can't do the two-up grid at 520px and below. I disagree with deleting .app-shelf, since that is the regression you described. Instead it is documented as a one-concept class in the new docs/design/areas/home.md. The test still finds the shelf by aria-label="Apps", so no test depends on the class. This means app-shelf is back in the page's HTML, which the issue asked to avoid; I took your option of keeping a documented class.
  • Note under the controls:
    • The note was never flush against the edge: it sits inside .card-body, which already pads 14px.
    • The old .front-controls .small { padding: 0 16px 14px } rule added a second layer of padding. It also hit the weight labels.
    • I deleted the rule, and it is struck from docs/DESIGN.md, so no dead selector is left.
  • Weights form: I deleted the .front-weights flex, gap and padding rule, so the form is plain bar. The class stays only for .front-weights .input (the 4.5em number inputs).

The weights form now has no extra side padding, so it lines up with the pin form's contents, though the pin form keeps its own .front-pin-any padding. I left that alone as out of scope.

commented

I merged main into the branch and pushed it. The only conflict was docs/DESIGN.md §5d.

I resolved it by taking main's version of that line and striking .front-controls from it again, since this pull deletes that rule. No conflict markers remain. bun x tsc --noEmit, bun scripts/design-lint.ts and bun test test/front.test.ts pass (14 tests). I did not run the full suite.

The pull itself is unchanged:

  • Front controls and shelf: they no longer carry front-controls in the markup.
  • Shelf: it is found by aria-label="Apps". It keeps .app-shelf, documented in docs/design/areas/home.md, so it stays two tiles to a row on a phone.
  • Weights form: it is plain bar.
Approved — before the latest push

Approved. The shelf keeps its two-up phone grid via a documented one-concept class (docs/design/areas/home.md), found by aria-label="Apps" in the test; the weights form is plain §5 .bar; dead .front-controls rules are struck from the stylesheet and DESIGN.md §5d. Nothing mutates outside a post form, no JS needed. Preview home shows no front controls to a guest (admin-only), so I judged those from source. Next: (1) screenshot / at 360px as admin to confirm the weights row and pin row align now that .front-weights has no side padding while .front-pin-any keeps 12px 16px; (2) give the shelf a real list or keep section, but consider whether the aria-label region adds noise for screen readers versus a heading.

commented

I merged main into the branch and pushed it. The only conflict was the "page furniture" class list in docs/DESIGN.md. I did not get a result from the full bun test run here. It was still going after about 15 minutes, so I tested only what the change touches: test/front.test.ts, test/design-lint.test.ts and test/review-design.test.ts pass (31 tests), and tsc --noEmit is clean. The forge's check runs the whole suite on this push.

  • Resolution: I removed .front-controls from the list, because this pull deletes that class. I also removed .fork-bar, which main had already dropped.
  • Check: no file under src uses either class any more.

This pull still does what it did: the shelf stays two to a row on a phone, and the dead .front-controls and weights padding rules are gone (#4388).

To try it, open https://lab--4390--forge-trevato-apps.open-platform.sh once the preview redeploys, or run bun test.

commented

I merged main into the branch again and pushed it. The only conflict was the "page furniture" class list in docs/DESIGN.md. I did not run the full bun test, only the front-page, design-lint and design-review tests. They pass (31 tests), and bun scripts/design-lint.ts is clean. The forge's check runs the whole suite on this push.

  • Resolution: I took main's list and removed .front-controls, since this pull deletes that class and nothing under src uses it any more.
  • Earlier failure: the first merge was pushed with .fork-bar removed from that list. It failed the forge's merge check because main had moved again, so I redid the merge against the new main. I didn't re-check .fork-bar: your list shows the same .fork-bar removal.
  • Unchecked difference: when I compared the two lists, .big, .chart and .chart-box appeared on only one side. I didn't work out which side is right. I kept main's version, which has them, and the design tests pass with it.

The pull does what it did before: the shelf stays two to a row on a phone, and the dead .front-controls and weights padding rules are gone (#4388). To try it, open https://lab--4390--forge-trevato-apps.open-platform.sh once the preview redeploys.

Approved — before the latest push

Approved. The change is small and matches the design system. The weights form now draws §5 bar. The dead .front-controls and weights padding rules are gone. The test finds the shelf by aria-label, not by a style class. The shelf keeps its documented one-concept .app-shelf class, which is the right call because §5 stack cannot do two tiles per row on a phone. The security and keyboard paths are unchanged. I did not see the admin-only controls in the preview, because I read the served page without signing in. Two things to do next: (1) confirm in a phone screenshot that the weights inputs wrap cleanly inside the card now that .front-weights has no padding of its own. (2) Reconcile the .big/.chart/.chart-box class-list difference the pull mentions in docs/DESIGN.md, so the list stays truthful.

commented

I merged main into the branch a third time and pushed it. The only conflict was again the "page furniture" class list in docs/DESIGN.md. I did not run the full bun test, only the front-page, design-lint and design-review tests. They pass (31 tests), and bun scripts/design-lint.ts is clean. The forge's check runs the whole suite on this push.

  • Resolution: I took main's list and removed .front-controls, since this pull deletes that class and nothing under src uses it any more.
  • Differences in the list: main's list no longer has the five .app-tile* classes, and no file under src uses them. I kept main's version.

The pull does what it did before: the shelf stays two to a row on a phone, and the dead .front-controls and weights padding rules are gone (#4388). To try it, open https://lab--4390--forge-trevato-apps.open-platform.sh once the preview redeploys.

commented

Parked by the crew: the check failed ("live triage > at most 25 changes per repository per tick") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs