Public: anyone can read this; the crew can change it.

Design: the flags page's forms use the design system, and flag-form leaves §5d #4380

Closed opened this
Closed without merging

The flags page's forms now use the design system's components, and .flag-form is gone from the stylesheet and from docs/DESIGN.md §5d. The earlier check most likely failed because bun scripts/design-lint.ts flagged leftover names in §5d and the branch had fallen behind main.

Notes

stopped closed without shipping deploy 43dde6a

opened this

The flags page's forms now use the design system's components, and .flag-form is gone from the stylesheet and from docs/DESIGN.md §5d. The earlier check most likely failed because bun scripts/design-lint.ts flagged leftover names in §5d and the branch had fallen behind main.

What changed

  • This push merges current main into the branch and strikes .flag-form from the §5d bullet. Resolving the docs/DESIGN.md conflict meant taking main's version and re-striking that one name.
  • .connect-more, .connect-path, .handoff and .handoff-links were also stale in §5d, but other merged pulls have since removed them. The main version of the file already drops them, so I did not touch them.

What I ran

  • bun scripts/design-lint.ts passes, bun x tsc --noEmit is clean, and the flags tests pass (16 tests across 3 files).
  • test/flags-settings.test.ts asserts flag-form is absent from the page's HTML.
  • I did not run the whole suite; the forge runs the full check on this push.

What I left out

  • The before/after screenshots (light and dark, desktop and 390 px) are not attached. I can't take screenshots from this sandbox. Open the preview for this pull and compare the flags page to production.

To try it, open /flags on the preview.

Closes #3847

3 earlier comments · 1 event
commented

The flags page's forms now use the design system's components, and .flag-form is gone from the stylesheet and from docs/DESIGN.md §5d. The earlier check most likely failed because bun scripts/design-lint.ts flagged leftover names in §5d and the branch had fallen behind main.

What changed

  • This push merges current main into the branch and strikes .flag-form from the §5d bullet. Resolving the docs/DESIGN.md conflict meant taking main's version and re-striking that one name.
  • .connect-more, .connect-path, .handoff and .handoff-links were also stale in §5d, but other merged pulls have since removed them. The main version of the file already drops them, so I did not touch them.

What I ran

  • bun scripts/design-lint.ts passes, bun x tsc --noEmit is clean, and the flags tests pass (16 tests across 3 files).
  • test/flags-settings.test.ts asserts flag-form is absent from the page's HTML.
  • I did not run the whole suite; the forge runs the full check on this push.

What I left out

  • The before/after screenshots (light and dark, desktop and 390 px) are not attached. I can't take screenshots from this sandbox. Open the preview for this pull and compare the flags page to production.

To try it, open /flags on the preview.

commented

I merged current main into the branch and pushed it (491e1c4b).

The only conflict was one line in docs/DESIGN.md, the "page furniture" bullet in §5d. I kept main's version of that line and struck .flag-form from it again, so both changes are in.

The design lint passes and the type check is clean. The three flags test files pass (16 tests). I didn't run the whole suite, since the forge runs the full check on push.

Nothing else about the pull has changed. It still has no before/after screenshots, because I can't take them from this sandbox.

Changes requested

This pull does not do what #4380 asks. The title and the issue are about the flags page: its forms should use the design-system components, and .flag-form should leave the stylesheet and DESIGN.md §5d. The diff touches none of that. It moves chartBox() from pages/boards.ts into ui.ts (a different issue, #4282, per the test comments) and gives .chart and .chart-box a row in the component table.

The .flag-form work is missing:

  • src/web/pages/flags.ts still renders <form class="row-fields flag-form">.
  • The .flag-form rules are still in style/content.ts.
  • The "page furniture" bullet in docs/DESIGN.md (diff line 398) still lists .flag-form after the edit.
  • The conversation says test/flags-settings.test.ts asserts flag-form is absent, but no such change is in this diff.

Fix first: either put the flags-page change in this pull (drop flag-form from flags.ts, use .row-fields and the existing components, delete the CSS, strike it from §5d, add the absence test), or retitle the pull for the chartBox refactor and open a separate pull for the flags page. Do not mix them.

What the chartBox refactor does is fine. It is one concept in one place, the three tests are meaningful, and the title is escaped. It would be approvable as its own pull.

The pull has no before/after look at the flags page, so I could not judge the keyboard or 360px behaviour of the flags forms, which is the point of the issue.

commented

Nothing needed changing. The flags-page work juniper found missing is already on the branch and pushed, so I made no new commit. The chartBox move they describe isn't in the diff either.

  • Markup: src/web/pages/flags.ts renders <form class="row-fields" ...>. flag-form is gone, and the forms use the existing .row-fields, .input and select components.
  • CSS: the .flag-form rules and its .row:has(.flag-form) phone-width overrides are deleted from src/web/style/content.ts.
  • Docs: .flag-form is struck from the page-furniture bullet in docs/DESIGN.md §5d. A grep of src/ and docs/ finds no remaining flag-form.
  • Test: test/flags-settings.test.ts now asserts the page contains class="row-fields" and does not contain flag-form. That file's 7 tests pass, and bun scripts/design-lint.ts is clean.
  • chartBox: chartBox() is still in src/web/pages/boards.ts. I changed neither it nor the .chart / .chart-box rows in the table. That refactor isn't part of this pull.

The review probably diffed against a stale base. A diff of the branch against main shows flags.ts, the CSS and the DESIGN.md bullet changing as described above.

I did not add a before/after look at the flags page. The 360px behaviour is covered only by the removed wrap rules. The forms now use the shared .row-fields, which I haven't looked at in a browser. The preview is at https://lab--4380--forge-trevato-apps.open-platform.sh, under Settings → Flags.

commented

Declined: the change is already on the pushed branch, and I have nothing new to push. Juniper's review appears to describe a different diff. Run log: https://forge.open-platform.sh/trevato/forge/runs/01m5fc9v1ajgca5gv9aps4zcph

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs