Public: anyone can read this; the crew can change it.
Design: a pull's merge box uses §5's card and buttons, and the merge-* classes leave §5d #4378
The fix is committed on the branch but not pushed. git push fails because origin points at http://localhost:8080/trevato/forge.git and the sandbox can't reach that port. I tried twice, five seconds apart.
stopped parked by the crew deploy 9b284fd
The fix is committed on the branch but not pushed. git push fails because origin points at http://localhost:8080/trevato/forge.git and the sandbox can't reach that port. I tried twice, five seconds apart. Git config is read-only here and I wasn't given another push route, so I'm leaving it for a person to push or re-run.
Cause of the red check: the earlier work on this branch was already done: the merge box drawn from §5's card and buttons, the merge-* rules gone from the stylesheet, and tests asserting the old class names are absent. What failed was docs/DESIGN.md, which had a conflict block (<<<<<<< … >>>>>>> origin/main) committed into its §5d style/content.ts bullet. Design-lint also named .connect-more, .connect-path, .handoff and .handoff-links, which main had already removed from the stylesheet.
What I changed:
- Resolved the conflict in
docs/DESIGN.mdin favour of the side without.merge-box,.merge-form,.merge-headlineand.merge-sub. - Struck those four other classes from the same bullet.
Checks I ran:
bun scripts/design-lint.tspasses.bun x tsc --noEmitis clean afterbun install.test/pulls.test.tsand the design tests pass.- Across
test/web*andtest/studio*, 497 pass and 1 fails: the empty-state check on/alice/blank/mapexpects "No issues to map yet." and doesn't find it. I didn't run it onmain, and it isn't connected to the merge box (I didn't touch the map page).
Not done:
- The before/after screenshots in light and dark, at desktop and 390 px, that the issue asks for. I can't reach a preview from here to take them.
To try it: open any pull page, the browse view of a pull, or the studio change page. The Ship form posts the same fields as before.
Parked by the crew: the check stayed red through 2 automatic tries
The fix is committed on the branch but not pushed.
git pushfails becauseoriginpoints athttp://localhost:8080/trevato/forge.gitand the sandbox can't reach that port. I tried twice, five seconds apart. Git config is read-only here and I wasn't given another push route, so I'm leaving it for a person to push or re-run.Cause of the red check: the earlier work on this branch was already done: the merge box drawn from §5's card and buttons, the
merge-*rules gone from the stylesheet, and tests asserting the old class names are absent. What failed wasdocs/DESIGN.md, which had a conflict block (<<<<<<<…>>>>>>> origin/main) committed into its §5dstyle/content.tsbullet. Design-lint also named.connect-more,.connect-path,.handoffand.handoff-links, whichmainhad already removed from the stylesheet.What I changed:
docs/DESIGN.mdin favour of the side without.merge-box,.merge-form,.merge-headlineand.merge-sub.Checks I ran:
bun scripts/design-lint.tspasses.bun x tsc --noEmitis clean afterbun install.test/pulls.test.tsand the design tests pass.test/web*andtest/studio*, 497 pass and 1 fails: the empty-state check on/alice/blank/mapexpects "No issues to map yet." and doesn't find it. I didn't run it onmain, and it isn't connected to the merge box (I didn't touch the map page).Not done:
To try it: open any pull page, the browse view of a pull, or the studio change page. The Ship form posts the same fields as before.
Closes #3867