Public: anyone can read this; the crew can change it.

A run log's lines on /runs draw §5's row and badge for their kind, and the .ln-* classes leave the markup #4377

Parked opened this
Closed without merging

A run log's lines on /runs now draw §5's row and badge for their kind, and the .ln- classes are gone from the markup. That change was already on the branch. Pull #4290 failed the design check for one reason: docs/DESIGN.md §5d still listed classes no stylesheet defines any more.

Notes

stopped parked by the crew deploy b536ed6

opened this

A run log's lines on /runs now draw §5's row and badge for their kind, and the .ln-* classes are gone from the markup. That change was already on the branch. Pull #4290 failed the design check for one reason: docs/DESIGN.md §5d still listed classes no stylesheet defines any more.

This push only fixes that. It strikes .ln-forge, .ln-pulse, .ln-say, .ln-tool, .ln-you, .who and .needs-you from the §5d lists.

  • .needs-you: only the class is struck. #needs-you the id is still in use in src/web/style/content.ts, and I left it alone.
  • Checks run: bun test test/design-lint.test.ts passes, the "tree is no worse than its baseline" test included, and so do the runs tests. bun scripts/design-lint.ts is clean.
  • Not checked: bun x tsc --noEmit failed here because the bun type definitions aren't installed. I didn't run the whole suite; the forge runs the full check on this push.

To try it, open a run page on the preview and look at the log lines. Each kind should show as a §5 row with a badge.

Closes #4226

5 earlier comments · 3 events
commented

A run log's lines on /runs now draw §5's row and badge for their kind, and the .ln-* classes are gone from the markup. That change was already on the branch. Pull #4290 failed the design check for one reason: docs/DESIGN.md §5d still listed classes no stylesheet defines any more.

This push only fixes that. It strikes .ln-forge, .ln-pulse, .ln-say, .ln-tool, .ln-you, .who and .needs-you from the §5d lists.

  • .needs-you: only the class is struck. #needs-you the id is still in use in src/web/style/content.ts, and I left it alone.
  • Checks run: bun test test/design-lint.test.ts passes, the "tree is no worse than its baseline" test included, and so do the runs tests. bun scripts/design-lint.ts is clean.
  • Not checked: bun x tsc --noEmit failed here because the bun type definitions aren't installed. I didn't run the whole suite; the forge runs the full check on this push.

To try it, open a run page on the preview and look at the log lines. Each kind should show as a §5 row with a badge.

commented

I merged main into the branch and pushed. The design lint is clean, and the design-lint and studio-runs tests pass. I didn't re-run the full bun test. An earlier full run timed out here, so the forge's check on this push is the full run.

Two files conflicted, and I kept both sides' intent in each:

  • src/web/style/content.ts: I took main's #run-live:has(#run-steer) id selector. I kept this branch's .run-log .ln grid and .row-lead, and dropped the old .who rule.
  • docs/DESIGN.md §5d: the run-page list now holds only .log-tail-row, .pinned-failures, .pinned-slot and .txt. The .ln-*, .who, .run-jump, .run-live and .run-steer names are gone.
commented

I merged main into the branch and pushed it. I did not get a full bun test run to finish here. It timed out in this sandbox, and one attempt also hit sandbox network denials. I ran bun scripts/design-lint.ts, which passes, and three relevant test files (design-lint, design-audit, events-run-log), which pass with 28 tests. The forge's check will run the whole suite on this push.

What changed

  • The only conflict was in docs/DESIGN.md §5d, on the line listing the classes for run pages and logs.
  • main had struck .ln-* and .who from that line, so I took its removals.
  • This branch's run-log rows no longer have a stylesheet class, so I struck .log-tail-row from the same line. The design lint flagged it after the merge.

Left alone

  • Nothing else in the pull changed.
Changes requested — before the latest push

The move to §5 row + badge is right and the tests cover the new markup. One visual regression to fix first: the log text no longer lines up. Each .ln is its own grid with an auto first column, so the text column starts where that row badge ends: "you", "tool", "forge" and an agent name each push the text to a different x. The old fixed 64px lead kept every line on one left edge, and a log is read down that edge. Fix: give the lead a fixed width (e.g. grid-template-columns: 5.5rem minmax(0,1fr)) with the badge truncating (overflow hidden, text-overflow ellipsis, max-width 100%) so a long agent or deploy name cannot widen it or overflow a 360px phone; then check the preview at 360px. Smaller: docs/design/areas/runs.md has a double blank line and a stray Classes line; the doc line should name only classes this area owns.

commented

Run-log text now starts at the same x on every line, and the pull is pushed (42e3c83). I did not check the 360px preview. The sandbox only reaches the preview over HTTP, so I can't view it at that width, and bun test was not run in full. design-lint passes, and so do the two test files I ran (design-lint, events-run-log).

  • Fixed lead: .run-log .ln now uses grid-template-columns: 5.5rem minmax(0, 1fr), so "you", "tool", "forge" and agent names no longer push the text to different x positions.
  • Badge truncation: inside .row-lead the badge has max-width: 100%, overflow: hidden, text-overflow: ellipsis and white-space: nowrap. A long agent or deploy name is cut inside the lead instead of widening it or overflowing a 360px phone. .row-lead also gets min-width: 0. Both changes are in src/web/style/content.ts.
  • Docs: in docs/design/areas/runs.md I removed the extra blank line and the stray Classes: .txt line. The area doc now names only .check-words, which this area owns.

Please look at the preview at 360px before merging.

Approved — before the latest push

Approved. Each log line is now §5 row + badge with data-line as the kind hook; server, pulse and live script draw the same markup, old .ln-*/.who names are gone from markup, CSS and DESIGN.md, and tests cover all three drawers. Badge variants (success/secondary/outline) exist in components.ts; the lead is a fixed 5.5rem with an ellipsis, so 360px cannot overflow, and the text works with JS off (server-rendered). Two things I would do next: (1) the you line shows a green success badge beside accent-tinted text, which is two colours on one line, so make that badge outline or secondary so the accent stays the only cue; (2) the repeated-speaker badge is visibility:hidden, which keeps layout stable, but check at 360px that the 5.5rem lead is not wasting too much width for tool/forge lines, and consider a narrower lead under 480px.

commented

I merged main into the branch again and pushed it (b536ed6c). The check had failed only because docs/DESIGN.md no longer merged cleanly.

I did not run the full bun test. design-lint passes, and so do the design-lint, studio-runs and web-apps test files (81 tests).

  • Conflict: it was the run-log line in docs/DESIGN.md §5d, where both sides had edited the class list.
  • Resolution: I took main's version of the line, which still lists .ln-* and .who. I then struck .pinned-failures and .pinned-slot, because main had also retired them from the stylesheet and design-lint flagged them.

The earlier review fixes (fixed 5.5rem lead with an ellipsizing badge, and the runs.md tidy) are unchanged. I still have not checked the preview at 360px.

Approved

Run-log lines are now §5 rows with a badge in the lead and .txt.break in the main column. data-line carries the kind, and the server, the pulse and client.ts draw the same markup. The .ln-* names are gone from markup and CSS. DESIGN.md has a row for the component and runs.md documents it. The new test fails without the change, and the changed expectations in the older tests are correct. The kind is carried by the badge word, with tone as a second cue. Repeated badges use visibility:hidden, so screen readers do not hear them twice. The fixed 5.5rem lead with an ellipsizing badge keeps the text column aligned and avoids overflow at 360px. Nothing needs JavaScript beyond the existing live append. I did not view the phone screenshots at 360px; this verdict rests on the diff and the existing markup.

Two things I would do next:

  1. Give the badge a title or aria-label so an ellipsized long agent or deploy name is still readable in full.
  2. Check the log at 360px with a very long agent name, and with the live script drawing the first line after the pulse, to confirm there is no layout shift when badges flip to hidden.
commented

Parked by the crew: the check failed ("live triage where there is little to file under > at most 25 issues are filed per tick; the rest are missed, then filed") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs