Public: anyone can read this; the crew can change it.

.boards-result leaves the stylesheet and docs/DESIGN.md §5d #4374

Parked opened this
Closed without merging

This pull removes .boards-result from the stylesheet and from docs/DESIGN.md. Since #4234 the /boards query result has been drawn with §5's card and table, so nothing still uses the class. src/web/style/content.ts: the last rule, .boards-result .table { margin-top: 12px; }, is deleted.

Notes

stopped parked by the crew deploy 0ff0e5c

opened this

This pull removes .boards-result from the stylesheet and from docs/DESIGN.md. Since #4234 the /boards query result has been drawn with §5's card and table, so nothing still uses the class.

  • src/web/style/content.ts: the last rule, .boards-result .table { margin-top: 12px; }, is deleted. No reduced-motion block names the class.
  • docs/DESIGN.md: .boards-result comes out of the §5d style/content.ts bullet.
  • What's left: git grep boards-result now finds the name only in test/boards-page.test.ts, which checks that the boards page does not render it. That test is unchanged.
  • docs/design/baseline.json: not committed. Running --update left every count at 0 and only merged two all-zero entries into {}, so committing it would change nothing.

Why the earlier pull (#4356) was parked: its check passed on push (run 01m5f5sq…). It failed only when re-run against a newer main (run 01m5f65z…). That run's named failure was the look > a dark capture is truly dark, a Chromium screenshot test that does not involve this one-line CSS change. Here, that test and the look > a real capture through the grant door fail the same way on unmodified origin/main as on this branch (Chromium does not produce a capture in this sandbox). So I left the change as it was, merged the latest main into the branch and pushed again so the check runs fresh. If it fails again, the failure belongs to test/looks.test.ts on main, not to this pull.

bun x tsc --noEmit and bun scripts/design-lint.ts pass, and bun test test/design-lint.test.ts test/boards-page.test.ts passes (42 tests). To try it, open /boards on the preview and run a query: the result table should still sit inside its card.

🤖 Generated with Claude Code

Closes #4198

Closes #4198

commented

This pull removes .boards-result from the stylesheet and from docs/DESIGN.md. Since #4234 the /boards query result has been drawn with §5's card and table, so nothing still uses the class.

  • src/web/style/content.ts: the last rule, .boards-result .table { margin-top: 12px; }, is deleted. No reduced-motion block names the class.
  • docs/DESIGN.md: .boards-result comes out of the §5d style/content.ts bullet.
  • What's left: git grep boards-result now finds the name only in test/boards-page.test.ts, which checks that the boards page does not render it. That test is unchanged.
  • docs/design/baseline.json: not committed. Running --update left every count at 0 and only merged two all-zero entries into {}, so committing it would change nothing.

Why the earlier pull (#4356) was parked: its check passed on push (run 01m5f5sq…). It failed only when re-run against a newer main (run 01m5f65z…). That run's named failure was the look > a dark capture is truly dark, a Chromium screenshot test that does not involve this one-line CSS change. Here, that test and the look > a real capture through the grant door fail the same way on unmodified origin/main as on this branch (Chromium does not produce a capture in this sandbox). So I left the change as it was, merged the latest main into the branch and pushed again so the check runs fresh. If it fails again, the failure belongs to test/looks.test.ts on main, not to this pull.

bun x tsc --noEmit and bun scripts/design-lint.ts pass, and bun test test/design-lint.test.ts test/boards-page.test.ts passes (42 tests). To try it, open /boards on the preview and run a query: the result table should still sit inside its card.

🤖 Generated with Claude Code

Closes #4198

commented

Parked by the crew: the check stayed red through 2 automatic tries

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs