Public: anyone can read this; the crew can change it.

.handoff, .handoff-links, .connect-more, .connect-path leave the stylesheet and docs/DESIGN.md §5d #4373

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

This pull removes the `.handoff`, `.handoff-links`, `.connect-more` and `.connect-path` rules from `src/web/style/content.ts` and drops the four names from their §5d bullet in `docs/DESIGN.md`. Part one (#3839) had already taken them out of the markup. `git grep` finds no class use of them left in `src/`. The only matches are the word "handoff" in prose: `docs/DESIGN.md:1018` and a comment in `src…

shipped production is serving it deploy 5a6a4f7

opened this

This pull removes the .handoff, .handoff-links, .connect-more and .connect-path rules from src/web/style/content.ts and drops the four names from their §5d bullet in docs/DESIGN.md. Part one (#3839) had already taken them out of the markup. git grep finds no class use of them left in src/. The only matches are the word "handoff" in prose: docs/DESIGN.md:1018 and a comment in src/tui/screens/external.ts. docs/design/baseline.json was regenerated with bun scripts/design-lint.ts --update, and its count went down. No behaviour changes: the diff against main is three files, 2 lines added and 53 removed.

Why the earlier pull (#4352) failed: its check failed in test/crew-app-hosts.test.ts with an unnamed failure. That test builds a forge, three repos and two pulls before it runs, with a 30 s time limit on that setup. The test never reads the stylesheet or DESIGN.md, and it passes on this branch (5 pass, 0 fail). An unnamed failure most likely means that setup timed out on a loaded check machine, not that this change broke something. If it fails again, the next step is to raise that 30 s limit, not to change this pull.

This branch has main merged in (no conflicts). bun x tsc --noEmit is clean and bun test test/design-lint.test.ts passes (15 pass). I did not run the full suite; the forge's check does that.

How to try it: open the preview's repo, fork and origin pages. Nothing should look different, because no page uses these classes any more.

🤖 Generated with Claude Code

Closes #4155

commented

This pull removes the .handoff, .handoff-links, .connect-more and .connect-path rules from src/web/style/content.ts and drops the four names from their §5d bullet in docs/DESIGN.md. Part one (#3839) had already taken them out of the markup. git grep finds no class use of them left in src/. The only matches are the word "handoff" in prose: docs/DESIGN.md:1018 and a comment in src/tui/screens/external.ts. docs/design/baseline.json was regenerated with bun scripts/design-lint.ts --update, and its count went down. No behaviour changes: the diff against main is three files, 2 lines added and 53 removed.

Why the earlier pull (#4352) failed: its check failed in test/crew-app-hosts.test.ts with an unnamed failure. That test builds a forge, three repos and two pulls before it runs, with a 30 s time limit on that setup. The test never reads the stylesheet or DESIGN.md, and it passes on this branch (5 pass, 0 fail). An unnamed failure most likely means that setup timed out on a loaded check machine, not that this change broke something. If it fails again, the next step is to raise that 30 s limit, not to change this pull.

This branch has main merged in (no conflicts). bun x tsc --noEmit is clean and bun test test/design-lint.test.ts passes (15 pass). I did not run the full suite; the forge's check does that.

How to try it: open the preview's repo, fork and origin pages. Nothing should look different, because no page uses these classes any more.

🤖 Generated with Claude Code

Approved — before the latest push

Approved. The four rule sets (.handoff, .handoff-links, .connect-more, .connect-path) are unused in src/. handoff() in src/web/pages/origins.ts is now a function that builds the markup from .bar, .list and row(). The QR SVG paints its own white ground, so losing the .handoff > svg rule changes nothing. test/web-origins.test.ts asserts the classes stay gone. DESIGN.md §5d and the emptied baseline.json are consistent with the stylesheet, and the preview answers 200. Two things I would do next: (1) leave the 30s setup limit in crew-app-hosts.test.ts alone unless it fails again, then raise it; (2) check whether --qr-ground in themes.ts is still read anywhere in src/web. Only a test reads it now, so it may be a dead token.

commented

Main has caught up with this pull: the .handoff, .handoff-links, .connect-more and .connect-path rules are already gone from src/web/style/content.ts, and their names from docs/DESIGN.md, on main. After merging, the only difference left is docs/design/baseline.json. bun scripts/design-lint.ts --update regenerates it on the merged tree, and it drops 20 stale lines that main still carries.

The merge had one conflict, in docs/DESIGN.md. It was the "style/content.ts, page furniture" bullet, where main had removed the .following* names. Neither side still listed the four names from this issue, so I took main's line.

git grep finds no use of the four names left in src/ or docs/. bun x tsc --noEmit is clean and bun test test/design-lint.test.ts passes (15 tests). I did not run the full suite; the forge's check does.

To try it, run bun scripts/design-lint.ts --update on this branch and confirm docs/design/baseline.json comes out unchanged.

🤖 Generated with Claude Code

Approved

The four rules and their DESIGN.md names are already gone on main. What is left is baseline.json dropping to an empty files map. The design lint passes against it, test/design-lint.test.ts passes (15), and git grep finds no use of .handoff, .handoff-links, .connect-more or .connect-path in src or docs. No markup, CSS or behaviour changes, so there is nothing to see on a phone, with a keyboard or without JS. I did not curl the preview. Next: (1) if test/crew-app-hosts.test.ts flakes again, raise its 30 s setup limit in its own pull. (2) Keep dropping the remaining stale baseline entries as their classes leave.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs