Public: anyone can read this; the crew can change it.

The claim, everyday-account and first-admin passkey notes draw §5's muted text and error-note, and .passkey-note leaves their markup #4372

Parked opened this
Closed without merging

The claim, everyday-account and first-admin pages no longer use .passkey-note; grep passkey-note src/web/pages finds nothing. bun x tsc --noEmit and bun scripts/design-lint.ts are clean, and the claim, everyday and first-admin tests pass (54 tests).

Notes

stopped parked by the crew deploy 3c0ac3f

opened this

The claim, everyday-account and first-admin pages no longer use .passkey-note; grep passkey-note src/web/pages finds nothing. bun x tsc --noEmit and bun scripts/design-lint.ts are clean, and the claim, everyday and first-admin tests pass (54 tests).

  • Quiet state: each note is now muted small with data-fail="error-note" and role="status", the same pattern as /signin. say() in passkey-client.ts already toggles that class, so it needed no change.
  • Server error: on the claim and first-admin pages, an errors.passkey renders as error-note with role="alert" from the first paint. Both keep their mb spacing.
  • Tests: I added assertions to existing tests instead of writing new test files.
    • claim-link.test.ts: the taken-passkey 422 page has no passkey-note and shows the error in error-note.
    • first-admin.test.ts: the no-key 422 page has no passkey-note and shows the error in error-note.
    • everyday.test.ts: the home page has no passkey-note and shows the quiet note. The everyday note has no server-rendered error, so it has no danger-style case.
  • Left alone: the stylesheet and docs/DESIGN.md, since #4277 removes the rule.

To try it, open /claim or /first-admin and make a passkey fail. The note turns red. A cancel or a clear goes back to muted.

Closes #4370

2 earlier comments
commented

The claim, everyday-account and first-admin pages no longer use .passkey-note; grep passkey-note src/web/pages finds nothing. bun x tsc --noEmit and bun scripts/design-lint.ts are clean, and the claim, everyday and first-admin tests pass (54 tests).

  • Quiet state: each note is now muted small with data-fail="error-note" and role="status", the same pattern as /signin. say() in passkey-client.ts already toggles that class, so it needed no change.
  • Server error: on the claim and first-admin pages, an errors.passkey renders as error-note with role="alert" from the first paint. Both keep their mb spacing.
  • Tests: I added assertions to existing tests instead of writing new test files.
    • claim-link.test.ts: the taken-passkey 422 page has no passkey-note and shows the error in error-note.
    • first-admin.test.ts: the no-key 422 page has no passkey-note and shows the error in error-note.
    • everyday.test.ts: the home page has no passkey-note and shows the quiet note. The everyday note has no server-rendered error, so it has no danger-style case.
  • Left alone: the stylesheet and docs/DESIGN.md, since #4277 removes the rule.

To try it, open /claim or /first-admin and make a passkey fail. The note turns red. A cancel or a clear goes back to muted.

commented

I merged main into the branch and pushed it. The merge applied with no conflicts, including in docs/DESIGN.md. I never opened that file, and my change doesn't touch it.

After the merge, bun x tsc --noEmit and bun scripts/design-lint.ts are clean. The claim, everyday and first-admin tests pass (54 tests), and grep passkey-note src/web/pages still finds nothing. I did not run the full suite; the forge runs the whole check on the push.

The pull's description is unchanged: the three passkey notes use muted small with data-fail="error-note", and a server-rendered error shows in error-note from the first paint.

commented

Parked by the crew: the check failed ("web pages end to end > the home carries no error-note for a setting that is not the default") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs