Public: anyone can read this; the crew can change it.
The claim, everyday-account and first-admin passkey notes draw §5's muted text and error-note, and .passkey-note leaves their markup #4372
The claim, everyday-account and first-admin pages no longer use .passkey-note; grep passkey-note src/web/pages finds nothing. bun x tsc --noEmit and bun scripts/design-lint.ts are clean, and the claim, everyday and first-admin tests pass (54 tests).
stopped parked by the crew deploy 3c0ac3f
2 earlier comments
The claim, everyday-account and first-admin pages no longer use .passkey-note; grep passkey-note src/web/pages finds nothing. bun x tsc --noEmit and bun scripts/design-lint.ts are clean, and the claim, everyday and first-admin tests pass (54 tests).
- Quiet state: each note is now
muted smallwithdata-fail="error-note"androle="status", the same pattern as/signin.say()inpasskey-client.tsalready toggles that class, so it needed no change. - Server error: on the claim and first-admin pages, an
errors.passkeyrenders aserror-notewithrole="alert"from the first paint. Both keep theirmbspacing. - Tests: I added assertions to existing tests instead of writing new test files.
- claim-link.test.ts: the taken-passkey 422 page has no
passkey-noteand shows the error inerror-note. - first-admin.test.ts: the no-key 422 page has no
passkey-noteand shows the error inerror-note. - everyday.test.ts: the home page has no
passkey-noteand shows the quiet note. The everyday note has no server-rendered error, so it has no danger-style case.
- claim-link.test.ts: the taken-passkey 422 page has no
- Left alone: the stylesheet and
docs/DESIGN.md, since #4277 removes the rule.
To try it, open /claim or /first-admin and make a passkey fail. The note turns red. A cancel or a clear goes back to muted.
I merged main into the branch and pushed it. The merge applied with no conflicts, including in docs/DESIGN.md. I never opened that file, and my change doesn't touch it.
After the merge, bun x tsc --noEmit and bun scripts/design-lint.ts are clean. The claim, everyday and first-admin tests pass (54 tests), and grep passkey-note src/web/pages still finds nothing. I did not run the full suite; the forge runs the whole check on the push.
The pull's description is unchanged: the three passkey notes use muted small with data-fail="error-note", and a server-rendered error shows in error-note from the first paint.
Parked by the crew: the check failed ("web pages end to end > the home carries no error-note for a setting that is not the default") and the decider saw no point in another try
The claim, everyday-account and first-admin pages no longer use
.passkey-note;grep passkey-note src/web/pagesfinds nothing.bun x tsc --noEmitandbun scripts/design-lint.tsare clean, and the claim, everyday and first-admin tests pass (54 tests).muted smallwithdata-fail="error-note"androle="status", the same pattern as/signin.say()inpasskey-client.tsalready toggles that class, so it needed no change.errors.passkeyrenders aserror-notewithrole="alert"from the first paint. Both keep theirmbspacing.passkey-noteand shows the error inerror-note.passkey-noteand shows the error inerror-note.passkey-noteand shows the quiet note. The everyday note has no server-rendered error, so it has no danger-style case.docs/DESIGN.md, since #4277 removes the rule.To try it, open
/claimor/first-adminand make a passkey fail. The note turns red. A cancel or a clear goes back to muted.Closes #4370