Public: anyone can read this; the crew can change it.

.following, .following-actions, .following-eyebrow, .following-foot, .following-head, .following-sentence leave the stylesheet and docs/DESIGN.md §5d #4371

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

This removes the rules for `.following`, `.following-actions`, `.following-eyebrow`, `.following-foot`, `.following-head` and `.following-sentence` from `src/web/style/content.ts`, along with the comment above them. Since #4209 the fork's following panel uses §5's card, row and btn, so nothing in the markup uses these classes any more.

shipped production is serving it deploy 2d10bf9

opened this

This removes the rules for .following, .following-actions, .following-eyebrow, .following-foot, .following-head and .following-sentence from src/web/style/content.ts, along with the comment above them. Since #4209 the fork's following panel uses §5's card, row and btn, so nothing in the markup uses these classes any more.

  • Where they're still used: git grep finds no class use of any of the six names left in src/. What remains is the data-following- attributes, the /following/ form actions and the refs/following/… refs, none of which are classes. No reduced-motion block mentions them.
  • Docs: the six names leave the style/content.ts bullet in docs/DESIGN.md §5d, and "following" leaves that bullet's list of what the file styles.
  • Baseline: docs/design/baseline.json is not changed. Running bun scripts/design-lint.ts against the current baseline passes.
  • Why the last pull was parked: #4351's head commit passed its push check. The run after approval failed 6 tests, among them a chromium capture through the grant door, a webhook private-address refusal and an unnamed shard. A stylesheet deletion can't cause any of those, so this pull brings the branch up to date with main and changes nothing else. If the same tests fail again on this push, look at the check machine rather than the diff.

Checks, run after merging main: bun x tsc --noEmit is clean, bun test test/design-lint.test.ts passes 15/15, bun test test/webhook* passes 9/9, and bun scripts/design-lint.ts passes.

To try it, open a fork's repo page on the preview: the following card should look the same as on production.

🤖 Generated with Claude Code

Closes #4153

commented

This removes the rules for .following, .following-actions, .following-eyebrow, .following-foot, .following-head and .following-sentence from src/web/style/content.ts, along with the comment above them. Since #4209 the fork's following panel uses §5's card, row and btn, so nothing in the markup uses these classes any more.

  • Where they're still used: git grep finds no class use of any of the six names left in src/. What remains is the data-following- attributes, the /following/ form actions and the refs/following/… refs, none of which are classes. No reduced-motion block mentions them.
  • Docs: the six names leave the style/content.ts bullet in docs/DESIGN.md §5d, and "following" leaves that bullet's list of what the file styles.
  • Baseline: docs/design/baseline.json is not changed. Running bun scripts/design-lint.ts against the current baseline passes.
  • Why the last pull was parked: #4351's head commit passed its push check. The run after approval failed 6 tests, among them a chromium capture through the grant door, a webhook private-address refusal and an unnamed shard. A stylesheet deletion can't cause any of those, so this pull brings the branch up to date with main and changes nothing else. If the same tests fail again on this push, look at the check machine rather than the diff.

Checks, run after merging main: bun x tsc --noEmit is clean, bun test test/design-lint.test.ts passes 15/15, bun test test/webhook* passes 9/9, and bun scripts/design-lint.ts passes.

To try it, open a fork's repo page on the preview: the following card should look the same as on production.

🤖 Generated with Claude Code

commented

This removes the rules for .following, .following-actions, .following-eyebrow, .following-foot, .following-head and .following-sentence from src/web/style/content.ts, along with the comment above them. Since #4209 the fork's following panel uses §5's card, row and btn, so nothing in the markup uses these classes any more. Against main, the diff is still just these two files.

  • Where they're still used: git grep finds no class use of any of the six names left in src/. What remains is the data-following- attributes, the /following/ form actions and the refs/following/… refs, none of which are classes. No reduced-motion block mentions them.
  • Docs: the six names leave the style/content.ts, page furniture bullet in docs/DESIGN.md §5d, and "following" leaves that bullet's list of what the file styles.
  • Merge with main: that bullet was the only conflict. Main had taken .connect-more, .connect-path, .handoff and .handoff-links out of it. The resolution keeps main's line and removes only the six .following* names and the word "following".
  • Baseline: docs/design/baseline.json is not changed. Running bun scripts/design-lint.ts against the current baseline passes.
  • Why the earlier pull was parked: #4351's head commit passed its push check. The run after approval failed 6 tests, among them a chromium capture through the grant door, a webhook private-address refusal and an unnamed shard. A stylesheet deletion can't cause any of those. If they fail again, look at the check machine rather than the diff.

After the merge, bun x tsc --noEmit is clean, bun test test/design-lint.test.ts passes 15/15, and bun scripts/design-lint.ts passes. I did not rerun the webhook tests after this merge.

To try it, open a fork's repo page on the preview: the following card should look the same as on production.

🤖 Generated with Claude Code

Approved

Dead CSS removal, correct. No class use of the six names remains in src/ (only data-following-* attributes, /following/* actions, refs/following/*), test/following-card.test.ts already asserts the page carries none of the old classes, the preview answers 200, and the DESIGN.md §5d bullet drops exactly those names and the word following. Two things next: (1) the stale comment in test/following-card.test.ts header could name #4209 as the source of the card; (2) keep sweeping content.ts for other classes whose markup moved to §5 components so the §5d list keeps shrinking.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs