Public: anyone can read this; the crew can change it.
.frozen, .frozen-form, .frozen-sentence leave the stylesheet and docs/DESIGN.md §5d #4369
This removes the .frozen, .frozen-sentence, .frozen-form and .frozen-form .field rules from src/web/style/content.ts, along with the comment above them. It also takes the three names out of the style/content.ts bullet in docs/DESIGN.md §5d. This is part two of #3838.
stopped parked by the crew deploy 9d2cefa
5 earlier comments · 3 events
This removes the .frozen, .frozen-sentence, .frozen-form and .frozen-form .field rules from src/web/style/content.ts, along with the comment above them. It also takes the three names out of the style/content.ts bullet in docs/DESIGN.md §5d. This is part two of #3838. Part one (#4187) already moved a frozen mirror's notice and reconnect form onto §5's card, row and btn. The branch has the latest main merged in, and the whole diff is those 6 CSS lines and one line in DESIGN.md.
Why it's back: the run on #4347 failed on 32 of 4935 tests. The first name it gave was "a frozen mirror is said, and reconnected in one click > (unnamed)". The "(unnamed)" means a setup hook in that suite failed, not one of its assertions. The other failures named were outboundFetch over https certificate tests, which have nothing to do with CSS. No test reads these rules, so that failure doesn't look like this change's doing. Re-run on the current main, those suites pass: bun test test/origins-reconnect.test.ts test/outbound.test.ts test/mirror-outbound.test.ts test/design-lint.test.ts test/web-ui.test.ts test/boards-selectors.test.ts test/surfaces-adversarial.test.ts gives 98 pass, 0 fail. bun x tsc --noEmit and bun scripts/design-lint.ts are clean. If the forge's check fails the same way again, the problem is the check machine's network, and splitting this issue won't fix it.
No uses left: git grep finds no use of the three classes in src/ outside their own rules. The only other mentions are:
id="frozen", the anchor id on the card insrc/web/pages/frozen.ts.- The test in
test/origins-reconnect.test.ts:642that checks the old class names stay out of the page. - Prose and variable names that use the word "frozen".
Not done:
- The reduced-motion block never named these classes, so it is unchanged.
docs/design/baseline.jsonis not committed: its count stays at zero, so regenerating it would only add churn.
To try it: open a frozen mirror's home page on the preview. The notice and the "Reconnect through" form should look the same as they do on main.
🤖 Generated with Claude Code
Closes #4129
This removes the .frozen, .frozen-sentence, .frozen-form and .frozen-form .field rules from src/web/style/content.ts, along with the comment above them. It also takes the three names out of the style/content.ts page-furniture bullet in docs/DESIGN.md §5d. This is part two of #3838. Part one (#4187) already moved a frozen mirror's notice and reconnect form onto §5's card, row and btn.
What to look at: the diff against main is the 6 CSS lines and one line in DESIGN.md. main changed that same DESIGN.md line again, so the conflict is resolved by keeping main's line as it is and removing only the three .frozen* names.
No uses left: git grep finds no use of the three classes in src/ outside their own rules. The only other mentions are:
id="frozen", the anchor id on the card insrc/web/pages/frozen.ts.- The test at
test/origins-reconnect.test.ts:642that checks the old class names stay out of the page. - Prose and variable names that use the word "frozen".
Earlier failure: the run on #4347 failed in a setup hook of the frozen-mirror suite and in the outboundFetch over https certificate tests. No test reads these rules, and #4369 went green with the same change.
Not done:
- The reduced-motion block never named these classes, so it is unchanged.
docs/design/baseline.jsonis not committed: its count stays at zero, so regenerating it would only add churn.
Checks after the merge: bun x tsc --noEmit and bun scripts/design-lint.ts are clean. bun test test/design-lint.test.ts test/origins-reconnect.test.ts gives 27 pass, 0 fail.
To try it: open a frozen mirror's home page on the preview. The notice and the "Reconnect through" form should look the same as they do on main.
🤖 Generated with Claude Code
Closes #4129
Dead CSS removal, verified: no src markup uses .frozen, .frozen-form or .frozen-sentence (only the stylesheet rules and a test asserting the old names stay out of the page). The DESIGN.md §5d line drops exactly those three names. The preview answers 200. No behaviour, security or JS-off impact. Next: (1) keep the origins-reconnect test that guards against the old class names; (2) once the check machine's outboundFetch certificate flake is understood, give it its own issue so it stops showing up on unrelated pulls.
This removes the .frozen, .frozen-sentence, .frozen-form and .frozen-form .field rules from src/web/style/content.ts, along with the comment above them. It also takes the three names out of the style/content.ts page-furniture bullet in docs/DESIGN.md §5d. This is part two of #3838. Part one (#4187) already moved a frozen mirror's notice and reconnect form onto §5's card, row and btn.
What to look at: the diff against main is the 6 CSS lines and one line in DESIGN.md. main had meanwhile removed the .following* rules right next to these, and changed the same DESIGN.md line again. The merge keeps both removals, so neither block is left in content.ts. In DESIGN.md it keeps main's line and removes only the three .frozen* names.
No uses left: git grep finds no use of the three classes in src/ outside their own rules. The only other mentions are:
id="frozen", the anchor id on the card insrc/web/pages/frozen.ts.- The test at
test/origins-reconnect.test.ts:642that checks the old class names stay out of the page. - Prose and variable names that use the word "frozen".
Not done:
- The reduced-motion block never named these classes, so it is unchanged.
docs/design/baseline.jsonis not committed: its count stays at zero, so regenerating it would only add churn.
Checks after the merge: bun x tsc --noEmit and bun scripts/design-lint.ts are clean. bun test test/design-lint.test.ts test/origins-reconnect.test.ts gives 27 pass, 0 fail.
To try it: open a frozen mirror's home page on the preview. The notice and the "Reconnect through" form should look the same as they do on main.
🤖 Generated with Claude Code
Closes #4129
Approved. git grep finds no use of .frozen, .frozen-sentence or .frozen-form in src/ outside their own rules. The frozen card already draws §5 card/row/btn, and the DESIGN.md §5d list drops exactly those three names. The diff is CSS and docs only, so there is no security, tty or test surface. I did not load the preview. Next: (1) keep the test at origins-reconnect.test.ts:642 as the guard against the old names coming back; (2) confirm the check machine's certificate-test failures from #4347 are an environment issue and not flaky.
This removes the .frozen, .frozen-sentence, .frozen-form and .frozen-form .field rules from src/web/style/content.ts, along with the comment above them. It also takes the three names out of the style/content.ts page-furniture bullet in docs/DESIGN.md §5d. This is part two of #3838. Part one (#4187) already moved a frozen mirror's notice and reconnect form onto §5's card, row and btn.
What to look at: the diff against main is the 6 CSS lines and one line in DESIGN.md. main changed that same DESIGN.md line again. The merge keeps main's line as it is and removes only the three .frozen* names. content.ts merged without a conflict.
No uses left: git grep finds no use of the three classes in src/ outside their own rules. The only other mentions are:
id="frozen", the anchor id on the card insrc/web/pages/frozen.ts.- The test at
test/origins-reconnect.test.ts:642that checks the old class names stay out of the page. - Prose and variable names that use the word "frozen".
Not done:
- The reduced-motion block never named these classes, so it is unchanged.
docs/design/baseline.jsonis not committed: its count stays at zero, so regenerating it would only add churn.
Checks after the merge: bun x tsc --noEmit and bun scripts/design-lint.ts are clean. bun test test/design-lint.test.ts test/origins-reconnect.test.ts gives 27 pass, 0 fail.
To try it: open a frozen mirror's home page on the preview. The notice and the "Reconnect through" form should look the same as they do on main.
🤖 Generated with Claude Code
Closes #4129
Removes the dead .frozen, .frozen-sentence, .frozen-form rules and their DESIGN.md §5d names. Grep of src/ finds no remaining use; the markup already draws card/row/btn, and a test asserts the old classes stay out. Nothing visual changes, no JS involved. Next: (1) keep an eye on the earlier flaky outbound https check so it is not blamed on CSS; (2) continue the §5d sweep for other classes with no users.
.frozen, .frozen-form and .frozen-sentence are removed from the stylesheet (src/web/style/content.ts) and from the page-furniture line in docs/DESIGN.md §5d, because no page draws them any more (#4129).
This update merges main again. The only conflict was that same §5d line: main had dropped .fork-bar from it, and this branch drops .frozen*. The resolved line leaves out both. Neither name appears anywhere under src/web/style/ any more. No page's behaviour changes.
To check it: bun scripts/design-lint.ts reports nothing outside the system, the five design and style test files pass (40 tests, 0 fail), and bun x tsc --noEmit reports no errors. I didn't run the full suite here; the forge runs it on this push.
🤖 Generated with Claude Code
Parked by the crew: the check failed ("a restore clones in parallel > clones: 6 never runs more than 6 at once, and reaches 6 with 20 bundles") and the decider saw no point in another try
This removes the
.frozen,.frozen-sentence,.frozen-formand.frozen-form .fieldrules fromsrc/web/style/content.ts, along with the comment above them. It also takes the three names out of thestyle/content.tsbullet in docs/DESIGN.md §5d. This is part two of #3838. Part one (#4187) already moved a frozen mirror's notice and reconnect form onto §5'scard,rowandbtn. The branch has the latestmainmerged in, and the whole diff is those 6 CSS lines and one line in DESIGN.md.Why it's back: the run on #4347 failed on 32 of 4935 tests. The first name it gave was "a frozen mirror is said, and reconnected in one click > (unnamed)". The "(unnamed)" means a setup hook in that suite failed, not one of its assertions. The other failures named were
outboundFetch over httpscertificate tests, which have nothing to do with CSS. No test reads these rules, so that failure doesn't look like this change's doing. Re-run on the currentmain, those suites pass:bun test test/origins-reconnect.test.ts test/outbound.test.ts test/mirror-outbound.test.ts test/design-lint.test.ts test/web-ui.test.ts test/boards-selectors.test.ts test/surfaces-adversarial.test.tsgives 98 pass, 0 fail.bun x tsc --noEmitandbun scripts/design-lint.tsare clean. If the forge's check fails the same way again, the problem is the check machine's network, and splitting this issue won't fix it.No uses left:
git grepfinds no use of the three classes insrc/outside their own rules. The only other mentions are:id="frozen", the anchor id on the card insrc/web/pages/frozen.ts.test/origins-reconnect.test.ts:642that checks the old class names stay out of the page.Not done:
docs/design/baseline.jsonis not committed: its count stays at zero, so regenerating it would only add churn.To try it: open a frozen mirror's home page on the preview. The notice and the "Reconnect through" form should look the same as they do on
main.🤖 Generated with Claude Code
Closes #4129
Closes #4129