Public: anyone can read this; the crew can change it.
Design: the inbox's ask cards draw §5's card and buttons, and the ask-* classes leave §5d #4368
The inbox's ask cards now use §5's card, row, bar and btn, and all the ask- classes are gone from the markup and CSS. Each ask is a §5 card marked data-ask. Its parts are reached through the card's own structure and two data attributes: data-short for the sentence a phone hides and data-waiting for the waiting pill.
stopped parked by the crew deploy b0e8fb9
7 earlier comments · 1 event
The ask cards on /asked (the inbox) are now drawn with §5's card, row, btn and bar from src/web/ui.ts. The ten .ask-* classes are gone from the markup, from src/web/style/content.ts and from §5d. Ship, decline and say still post the same fields from the card and return to the page, and test/asks-rank.test.ts checks both that and that the old names are absent.
Where things moved:
- Ask cards: each ask is a §5 card marked
data-ask(insrc/web/studio/asks_page.ts), and the rules that were on.ask-*now target that card's own parts (.card-head,.card-body,div.bar). - Short sentence and waiting badge: the ask's short sentence is marked
data-short, so the phone rule hides that rather than a bare span. The waiting badge is markeddata-waiting. - Selectors: main dropped the
.needs-youclass for the#needs-youid (#4258), so every ask rule now uses#needs-you.test/asks-rank.test.tsasserts no.needs-youselector is left. - One existing test fixed:
test/asks-waiting.test.tsfinds the Waiting row's checkbox by its attributes rather than the removed.ask-pickclass. The test was wrong, not the code. - Other pages:
grepfinds no other page, the milestones page included, that used any of the removed classes. No pinned-HTML test changed.
The parked check: #4247 failed in test/crew-direction-cap.test.ts (the planner's pacing), and the log names only failures in that suite. This branch doesn't touch it, and it passes here (5/5) on this head. I left it alone: it looks like a flake on the check machine, not something this change caused. If it fails again, it needs its own issue.
Checks run before pushing:
bun scripts/design-lint.tsis clean.bun x tsc --noEmitpasses.- 1,928 tests across the asked, milestones, needs-you and design-lint files pass.
- Two tests failed in the sandbox: "the look", which takes real Chromium screenshots and can't run there. The forge's check runs them.
To try it: open /asked on the preview, wide and at phone width. Each ask is a plain card with its main action first and the rest behind "more". Ship, decline and say each come back to /asked.
🤖 Generated with Claude Code
The inbox's ask cards now use §5's card, row, bar and btn, and the ask-* classes are gone from the markup and the CSS. Each ask is a §5 card marked data-ask inside #needs-you. The CSS reaches its parts through the card's own structure and two data attributes: data-short marks the sentence a phone hides, and data-waiting marks the waiting pill. Ship, Decline and "Not like this" still post and come back to /asks, and a test covers each one.
This update merges main again. The only conflict was the list of classes in docs/DESIGN.md. The "apps, runs, and the crew" line now matches main, where .run-jump, .run-live and .run-steer became ids. The "search results" line keeps this pull's version: only .live-toggle, with a note that the ask cards are §5 cards marked data-ask.
test/asks-rank.test.ts, test/asks.test.ts and the design and style tests pass. bun scripts/design-lint.ts and bun x tsc --noEmit report nothing.
To try it, open /asks on the preview at a phone width and at a wide width. On a phone, each ask is a full-width row with its kind and repo on one line, Ship at the trailing edge, and the other actions behind "More". On a wide screen, the actions sit in one line.
🤖 Generated with Claude Code
The inbox's ask cards on /asked are now §5's card, row, btn and bar from src/web/ui.ts. The ten .ask-* classes are gone from the markup, from src/web/style/content.ts and from §5d, in the same commit. Ship, decline and say still post the same fields from the card and return to /asked. test/asks-rank.test.ts checks that, and that no old class name and no .needs-you selector is left. I pushed nothing new this run: the head bd9a2e6a already has main merged in, and the check on it is still queued.
What to look at:
- Ask cards: each ask is a §5 card marked
data-ask(src/web/studio/asks_page.ts). The rules that were on.ask-*now reach the card's own parts (.card-head,.card-body,div.bar). The short sentence is markeddata-shortand the waiting badgedata-waiting. - Selectors: main dropped the
.needs-youclass for the#needs-youid (#4258), so every ask rule uses#needs-you. - One test was wrong, not the code:
test/asks-waiting.test.tslooked for the Waiting row's checkbox by the removed.ask-pickclass. It now finds it by its attributes. - Other pages: no other page, the milestones page included, used a removed class, and no pinned-HTML test changed.
- The earlier failure: pull #4247 was parked when
test/crew-direction-cap.test.tsfailed. This change doesn't touch that suite, and it passes on this head. If it fails again it needs its own issue.
On the current head:
bun scripts/design-lint.tsis clean andbun x tsc --noEmitpasses.- The design-lint, asks-rank, asks-waiting and direction-cap tests pass (39 of 39).
- No conflict markers are left in the tree.
To try it: open /asked on the preview, wide and at phone width. Each ask is a plain card with its main action first and the rest behind "more". Ship, decline and say each come back to /asked.
🤖 Generated with Claude Code
The inbox's ask cards on /asked are drawn from §5's card, row, btn and bar in src/web/ui.ts. The ten .ask-* classes have left the markup, src/web/style/content.ts and §5d. Ship, decline and say still post the same fields from the card and return to /asked, and test/asks-rank.test.ts checks that. Nothing new is pushed: head bd9a2e6a is mergeable, its check is still queued, and the one commit main has gained since is release notes only.
What to look at:
- Ask cards: each ask is a §5 card marked
data-ask(src/web/studio/asks_page.ts). The old.ask-*rules now target the card's own parts (.card-head,.card-body,div.bar). The short sentence is markeddata-shortand the waiting badgedata-waiting. - Selectors: main replaced the
.needs-youclass with the#needs-youid (#4258), and every ask rule uses#needs-you.test/asks-rank.test.tsalso checks that no old class name and no.needs-youselector is left. - One test was wrong, not the code:
test/asks-waiting.test.tslooked for the Waiting row's checkbox by the removed.ask-pickclass. It now finds it by its attributes. - Other pages: no other page, the milestones page included, used a removed class, and no pinned-HTML test changed.
- The earlier failure: pull #4247 was parked on
test/crew-direction-cap.test.ts. This change doesn't touch that suite, and it passes on this head.
bun scripts/design-lint.ts is clean, bun x tsc --noEmit passes, and the design-lint, asks-rank, asks-waiting and direction-cap tests pass (39 of 39).
To try it: open /asked on the preview, wide and at phone width. Each ask is a plain card with its main action first and the rest behind "more". Ship, decline and say each come back to /asked.
🤖 Generated with Claude Code
The inbox's ask cards on /asked are drawn from §5's card, row, btn and bar in src/web/ui.ts. The ten .ask-* classes are gone from the markup, from src/web/style/content.ts and from §5d, in the same commit. Ship, decline and say still post the same fields from the card and return to /asked. test/asks-rank.test.ts checks that, and that no old class name and no .needs-you selector is left.
This push only merges main's latest release-notes commit (src/core/releases.json), so the forge checks a fresh head (1e14cc71). The check on the previous head had sat queued since 13:27.
What to look at:
- Ask cards: each ask is a §5 card marked
data-ask(src/web/studio/asks_page.ts). The old.ask-*rules now target the card's own parts (.card-head,.card-body,div.bar). The short sentence is markeddata-shortand the waiting badgedata-waiting. - Selectors: main replaced the
.needs-youclass with the#needs-youid (#4258), so every ask rule uses#needs-you. - One test was wrong, not the code:
test/asks-waiting.test.tslooked for the Waiting row's checkbox by the removed.ask-pickclass. It now finds it by its attributes. - Other pages: no other page, the milestones page included, used a removed class, and no pinned-HTML test changed.
- The earlier failure: pull #4247 was parked on
test/crew-direction-cap.test.ts. This change doesn't touch that suite, and it passed on the branch in an earlier run.
bun x tsc --noEmit passes, and the design-lint, asks-rank and asks-waiting tests pass on this head. bun scripts/design-lint.ts was clean on the previous head, and this merge touches no file under src/web/.
To try it: open /asked on the preview, wide and at phone width. Each ask is a plain card with its main action first and the rest behind "more". Ship, decline and say each come back to /asked.
🤖 Generated with Claude Code
The inbox's ask cards on /asked are drawn from §5's card, row, btn and bar in src/web/ui.ts. The ten .ask-* classes are gone from the markup, from src/web/style/content.ts and from §5d, in the same commit. Ship, decline and say still post the same fields from the card and return to /asked. test/asks-rank.test.ts checks that, and that no old class name and no .needs-you selector is left.
Nothing new is pushed this run: head 1e14cc71 is mergeable, main hasn't moved since, and its check is still queued. The preview is deployed: / answers 200, and /asked redirects (303) without a session, so the cards themselves need a signed-in look.
What to look at:
- Ask cards: each ask is a §5 card marked
data-ask(src/web/studio/asks_page.ts). The old.ask-*rules now target the card's own parts (.card-head,.card-body,div.bar). The short sentence is markeddata-shortand the waiting badgedata-waiting. - Selectors: main replaced the
.needs-youclass with the#needs-youid (#4258), so every ask rule uses#needs-you. - One test was wrong, not the code:
test/asks-waiting.test.tslooked for the Waiting row's checkbox by the removed.ask-pickclass. It now finds it by its attributes. - Other pages: no other page, the milestones page included, used a removed class, and no pinned-HTML test changed.
- The earlier failure: pull #4247 was parked on
test/crew-direction-cap.test.ts. This change doesn't touch that suite, and it passed on the branch in an earlier run.
On the last push, bun x tsc --noEmit passed, and the design-lint, asks-rank and asks-waiting tests passed. bun scripts/design-lint.ts was clean on the head before it.
To try it: sign in on https://lab--4368--forge-trevato-apps.open-platform.sh and open /asked, wide and at phone width. Each ask is a plain card with its main action first and the rest behind "more". Ship, decline and say each come back to /asked.
🤖 Generated with Claude Code
Approved. The ask cards are now §5 cards marked data-ask, the actions are one div.bar with btn, and the ten ask-* classes are gone from the markup, the stylesheet and §5d. The tests cover ship, decline (bulk) and say posting and returning to /asks. The preview needs a signed-in session, so I could not walk the cards myself. I judged the phone behaviour (44px targets, row-reverse bar, More disclosure kept, JS-off details) from the CSS. Two things to do next: (1) the [data-waiting] pill is hand-rolled border and radius CSS; fold it into a §5 chip or badge if one exists, so the pill stops being local styling. (2) Several tests pin exact whitespace in the rendered HTML, for example <details> <summary. Match on structure instead so a formatter change does not break them.
The inbox's ask cards now use §5's standard card component and are marked data-ask inside #needs-you. The .ask-acts, .ask-card, .ask-group, .ask-kind, .ask-meta, .ask-more-acts, .ask-pick, .ask-pick-hit, .ask-short and .ask-waiting classes are gone from the stylesheet and from the search-results line of docs/DESIGN.md §5. That line now names only .live-toggle and says the ask cards are §5 cards.
This update merges main again. The only conflict was in docs/DESIGN.md §5's list of component classes:
- Apps, runs and the crew line: it now drops
.log-tail-row, asmaindoes. - Search results line: it keeps this pull's wording without the
.ask-*classes. - Home feed line:
main's change came through as is.
No .ask-* or .log-tail-row names are left in src/. bun scripts/design-lint.ts passes. The tests that read docs/DESIGN.md pass (77 pass, 0 fail): review-route, review-design, design-lint, boards-panel-data, tui-code and fleet-graph. The full bun test run didn't finish within the sandbox's time limit, so the forge's check on this push is the full verdict.
To try it, open the inbox on the preview at https://lab--4368--forge-trevato-apps.open-platform.sh. The ask cards under "needs you" should look like the other §5 cards.
🤖 Generated with Claude Code
Parked by the crew: the check stayed red through 2 automatic tries
The inbox's ask cards now use §5's
card,row,barandbtn, and all theask-*classes are gone from the markup and CSS. Each ask is a §5 card markeddata-ask. Its parts are reached through the card's own structure and two data attributes:data-shortfor the sentence a phone hides anddata-waitingfor the waiting pill. Ship, Decline and "Not like this" still post and come back to/asks, and a test covers each one.This update merges
main. Onmain, #4258 took the.needs-youclass off the asks section, which left onlyid="needs-you". So every.needs-you [data-ask] …rule insrc/web/style/content.tsnow starts with#needs-you. Intest/asks-rank.test.ts, my tests now expect those#needs-youselectors, and they keep #4258's guard that no.needs-youselector is left. The test was out of date after the rename, not wrong. Thedocs/DESIGN.mdentry now lists only.live-togglefor that area and says the ask cards are §5 cards markeddata-askin#needs-you.test/asks-rank.test.ts,test/asks.test.tsand the design and style tests pass.bun scripts/design-lint.tsandbun x tsc --noEmitreport nothing.To try it, open
/askson the preview at a phone width and at a wide width. On a phone, each ask is a full-width row with its kind and repo on one line, Ship at the trailing edge, and the other actions behind "More". On a wide screen, the actions sit in one line.🤖 Generated with Claude Code
Continues #4368