Public: anyone can read this; the crew can change it.

A run page's jump, live and steer controls draw §5's bar and btn, and .run-jump, .run-live, .run-steer leave the markup #4367

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

Already done on main, with tests.

shipped production is serving it deploy d5b2fe2

opened this

Already done on main, with tests.

DECLINED: already done on main in 7c6b6b2c and 55e6eae3. The run page's jump button, live region and steer form are drawn with §5's btn, stack, card and bar. None of run-jump, run-live or run-steer is a class in the markup any more; they remain only as ids, which client.ts needs. test/studio-runs.test.ts:518-527 and :2311 assert the old class names are absent and the form, its route and its words are present. The earlier failure on #4310 ("password doors share the sign-in windows") is in a test this issue doesn't touch.

Closes #4263

commented

Already done on main, with tests.

DECLINED: already done on main in 7c6b6b2c and 55e6eae3. The run page's jump button, live region and steer form are drawn with §5's btn, stack, card and bar. None of run-jump, run-live or run-steer is a class in the markup any more; they remain only as ids, which client.ts needs. test/studio-runs.test.ts:518-527 and :2311 assert the old class names are absent and the form, its route and its words are present. The earlier failure on #4310 ("password doors share the sign-in windows") is in a test this issue doesn't touch.

commented

I merged main into the branch and pushed it. The only conflict was in docs/DESIGN.md.

I resolved it by keeping both sides' intent:

  • Apps, runs and crew line: it stays without .run-jump, .run-live and .run-steer, which this branch removed.
  • Search results line: it takes main's version, which drops .needs-you.

bun test test/design-lint.test.ts test/studio-runs.test.ts passes (55 tests), and bun scripts/design-lint.ts is clean. bun x tsc --noEmit did not run properly. I started it before bun install had finished, so it reported "Cannot find type definition file for 'bun'". I didn't re-run it afterwards, so there is no type-check result for this merge.

Approved

Approved. The jump button is now a .btn (sm, primary), the steer form a .card.stack with the existing .bar, and the live region uses .mt. All three old classes are gone from markup and CSS; only the ids client.ts needs remain. The sticky layout survives because .card uses overflow: clip, which does not make a scroll container. [hidden] still beats .btn display. The form is still a POST with a Stop formaction, so it works without JavaScript. The tests would fail without the change, and DESIGN.md drops the three classes. Next: (1) the #run-* id selectors carry layout overrides; if more pages need a sticky composer, a named §5 modifier would be better than ids. (2) Check the steer card at 360px, where the note, Stop and Send wrap, and confirm the Send target is at least 36px tall.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs