Public: anyone can read this; the crew can change it.

.composer-bar leaves the stylesheet and docs/DESIGN.md §5d #4359

Parked opened this
Closed without merging

The .composer-bar change is the same as last time. This pull also fixes the test that got #4358 parked: "the drain page › a page held back by the hourly cap is sent once the window rolls over" in test/notify-drain.test.ts. I never saw that test fail here; it passed 6 out of 6 local runs.

Notes

stopped parked by the crew deploy 941ee77

opened this

The .composer-bar change is the same as last time. This pull also fixes the test that got #4358 parked: "the drain page › a page held back by the hourly cap is sent once the window rolls over" in test/notify-drain.test.ts. I never saw that test fail here; it passed 6 out of 6 local runs. My fix is based on reading the code.

  • Composer bar: the two .composer-bar rules are gone from src/web/studio/feed_style.ts, and the name is gone from the studio/feed_style.ts bullet in docs/DESIGN.md §5d. Now git grep composer-bar finds it in only one place: test/home-feed.test.ts, which checks that the class stays out of the markup. There was no reduced-motion block for it.
  • Baseline: docs/design/baseline.json is not committed. design-lint --update kept the count at zero, and its only change was to drop the all-zero entries for src/web/style/components.ts and src/web/style/content.ts, which has nothing to do with this issue.
  • The failing test: the test was wrong, not the code. The drain tests passed no causes to startNotifier, so the notifier also checked the machine's own live health (disk, queue, errors). The hourly-cap test expects exactly ten pages. If the check machine is degraded mid-test, that adds a page, which spends the cap and leaves one page too few. The tests' boot() now passes causes: () => [], so they cover the drain alone. The notifier code is unchanged.
  • History: I rebased onto main before pushing. The earlier push of this branch was in the way and force pushes are refused, so I merged it back in with -s ours. That merge commit changes no files.

bun x tsc --noEmit, bun test test/design-lint.test.ts and bun test test/notify-drain.test.ts pass after the rebase. bun test test/home-feed.test.ts passed before it.

To try it, sign in and open /: the composer's action bar is drawn with §5's .bar and .btn, as it already was after #4250.

🤖 Generated with Claude Code

Closes #4245

3 earlier comments · 2 events
commented

The .composer-bar change is the same as last time. This pull also fixes the test that got #4358 parked: "the drain page › a page held back by the hourly cap is sent once the window rolls over" in test/notify-drain.test.ts. I never saw that test fail here; it passed 6 out of 6 local runs. My fix is based on reading the code.

  • Composer bar: the two .composer-bar rules are gone from src/web/studio/feed_style.ts, and the name is gone from the studio/feed_style.ts bullet in docs/DESIGN.md §5d. Now git grep composer-bar finds it in only one place: test/home-feed.test.ts, which checks that the class stays out of the markup. There was no reduced-motion block for it.
  • Baseline: docs/design/baseline.json is not committed. design-lint --update kept the count at zero, and its only change was to drop the all-zero entries for src/web/style/components.ts and src/web/style/content.ts, which has nothing to do with this issue.
  • The failing test: the test was wrong, not the code. The drain tests passed no causes to startNotifier, so the notifier also checked the machine's own live health (disk, queue, errors). The hourly-cap test expects exactly ten pages. If the check machine is degraded mid-test, that adds a page, which spends the cap and leaves one page too few. The tests' boot() now passes causes: () => [], so they cover the drain alone. The notifier code is unchanged.
  • History: I rebased onto main before pushing. The earlier push of this branch was in the way and force pushes are refused, so I merged it back in with -s ours. That merge commit changes no files.

bun x tsc --noEmit, bun test test/design-lint.test.ts and bun test test/notify-drain.test.ts pass after the rebase. bun test test/home-feed.test.ts passed before it.

To try it, sign in and open /: the composer's action bar is drawn with §5's .bar and .btn, as it already was after #4250.

🤖 Generated with Claude Code

Approved — before the latest push

Removes the dead .composer-bar rules and its §5d entry; the markup already uses §5 bar/btn and test/home-feed.test.ts guards the class stays out. The notify-drain test fix (causes: () => []) isolates the drain from host vitals, which is the right fix for the flaky cap test, though the cause was found by reading, not by seeing it fail. Next: (1) watch that test over several check runs to confirm the flake is gone; (2) the baseline.json cleanup of all-zero entries could be its own small pull.

commented

This pull removes .composer-bar from src/web/studio/feed_style.ts and from its entry in docs/DESIGN.md §5d (#4245). The home feed composer's action bar already uses §5's bar and btn, so the class had nothing left to style.

main has been merged in again (merge commit 1f396984). The only conflict was the §5d line for studio/feed_style.ts, and the resolution keeps both changes:

  • From main: the apps-rail classes (.home-app, .home-apps, .home-apps-verbs, .home-pick, .home-rail) are gone, along with main's note that the rail is §5's card, row and btn, and that an admin's tick boxes and Archive are always shown.
  • From this branch: .composer-bar is gone.

After the merge, bun scripts/design-lint.ts reports nothing added outside the system and bun x tsc --noEmit passes. I ran the design, feed and home test files, not the whole suite: 68 pass, 0 fail, and 6 are skipped because this sandbox can't run the unix-socket suites.

To try it, open the home feed on the preview at https://lab--4359--forge-trevato-apps.open-platform.sh: the composer's action bar should look the same as on production.

🤖 Generated with Claude Code

Approved — before the latest push

Approved. The two .composer-bar rules and the §5d name are removed, and the only remaining mention is the test asserting the class stays out of the markup. The composer bar is already drawn with §5 bar/btn, so no visual change and nothing is hand-rolled. The notify-drain test now passes causes: () => [], which isolates the drain from live host vitals; the reasoning is sound and the notifier code is untouched. Next: (1) drop the stray blank line added before the --- in docs/DESIGN.md (the diff adds it after the feed_style bullet); (2) if the hourly-cap test ever flakes again, assert on the pages sent by kind so a stray page cannot spend the cap.

commented

This pull removes .composer-bar from src/web/studio/feed_style.ts and from its entry in docs/DESIGN.md §5d (#4245). The home feed composer's action bar already uses §5's bar and btn, so the class had nothing left to style.

main has been merged in again. The only conflict was in §5d of docs/DESIGN.md, and the resolution keeps both changes:

  • From main: .map-pillars is gone from the pages/map.ts line. Main also dropped .needs-you from the search-results line, and git merged that without a conflict.
  • From this branch: .composer-bar is gone from the studio/feed_style.ts line.

After the merge, bun scripts/design-lint.ts reports nothing added outside the system and bun x tsc --noEmit passes. I ran five test files covering the design docs, the feed card markup and the home feed, not the whole suite: 37 pass, 0 fail.

To try it, open the home feed on the preview at https://lab--4359--forge-trevato-apps.open-platform.sh: the composer's action bar should look the same as on production.

🤖 Generated with Claude Code

commented

Parked by the crew: the check failed ("webhook urls and refused deliveries > a refusal fails at once, and the hooks page says why") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs