Public: anyone can read this; the crew can change it.

.composer-bar leaves the stylesheet and docs/DESIGN.md §5d #4358

Parked opened this
Closed without merging

I removed the two unused .composer-bar rules from src/web/studio/feedstyle.ts and took the name out of the studio/feedstyle.ts bullet in docs/DESIGN.md §5d. Part one (#4250) had already taken the class out of the markup.

Notes

stopped parked by the crew deploy ec2d25f

opened this

I removed the two unused .composer-bar rules from src/web/studio/feed_style.ts and took the name out of the studio/feed_style.ts bullet in docs/DESIGN.md §5d. Part one (#4250) had already taken the class out of the markup. Now git grep composer-bar finds it in only one place: test/home-feed.test.ts, which checks that the class stays out of the composer's markup. There was no reduced-motion block for it. The page should look the same as before.

bun scripts/design-lint.ts --update kept the count at zero. The only change it made was to drop the all-zero entries for src/web/style/components.ts and src/web/style/content.ts. That has nothing to do with this issue, so I didn't commit docs/design/baseline.json; the file is unchanged.

bun x tsc --noEmit, bun test test/design-lint.test.ts and bun test test/home-feed.test.ts pass. I rebased on main before pushing and ran the design-lint test again.

To try it: open / while signed in. The composer's action bar is drawn with §5's .bar/.btn, as it already was after #4250.

🤖 Generated with Claude Code

Closes #4245

1 earlier comment · 1 event
commented

I removed the two unused .composer-bar rules from src/web/studio/feed_style.ts and took the name out of the studio/feed_style.ts bullet in docs/DESIGN.md §5d. Part one (#4250) had already taken the class out of the markup. Now git grep composer-bar finds it in only one place: test/home-feed.test.ts, which checks that the class stays out of the composer's markup. There was no reduced-motion block for it. The page should look the same as before.

bun scripts/design-lint.ts --update kept the count at zero. The only change it made was to drop the all-zero entries for src/web/style/components.ts and src/web/style/content.ts. That has nothing to do with this issue, so I didn't commit docs/design/baseline.json; the file is unchanged.

bun x tsc --noEmit, bun test test/design-lint.test.ts and bun test test/home-feed.test.ts pass. I rebased on main before pushing and ran the design-lint test again.

To try it: open / while signed in. The composer's action bar is drawn with §5's .bar/.btn, as it already was after #4250.

🤖 Generated with Claude Code

Approved

Removes the two dead .composer-bar rules and the DESIGN.md §5d entry. The base has no markup using the class (only a test asserting its absence), and the preview / serves 200 with zero occurrences. No visual change, no behaviour change, no new scope, and the existing test still guards the markup. Next, if you want: (1) once the area docs no longer list it, run design-lint --update in a separate pull to drop the stale all-zero baseline entries; (2) keep the home-feed test that forbids the class so it cannot return.

commented

Parked by the crew: the check failed ("the drain page > a page held back by the hourly cap is sent once the window rolls over") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs