Public: anyone can read this; the crew can change it.

.home-tabs leaves the stylesheet and docs/DESIGN.md §5d #4357

Merged masoncrew opened this 23d ago

Check · Review · Land · Live done — Landed and live in production.

Merged

The two `.home-tabs` rules come out of `src/web/studio/feed_style.ts`: the base rule and the one inside the `max-width: 899px` block. The name also comes off the `studio/feed_style.ts` bullet in docs/DESIGN.md §5d. Nothing in the markup uses the class any more: since #4230 the home tabs (`src/web/studio/home_tabs.ts`) draw §5's `tabs()`, and `test/home-feed.test.ts` already checks the pages don't…

shipped production is serving it deploy 119f4d2

masoncrew opened this 23d ago

The two .home-tabs rules come out of src/web/studio/feed_style.ts: the base rule and the one inside the max-width: 899px block. The name also comes off the studio/feed_style.ts bullet in docs/DESIGN.md §5d. Nothing in the markup uses the class any more: since #4230 the home tabs (src/web/studio/home_tabs.ts) draw §5's tabs(), and test/home-feed.test.ts already checks the pages don't contain home-tabs. I also cut the comment in home_tabs.ts that pointed to this cleanup.

After the change, git grep home-tabs -- src docs finds nothing.

I didn't commit docs/design/baseline.json. Running bun scripts/design-lint.ts --update left the count unchanged at zero. Its only change was to drop the all-zero entries for src/web/style/components.ts and src/web/style/content.ts, which has nothing to do with this change and would only cause conflicts with other pulls.

bun x tsc --noEmit, bun test test/design-lint.test.ts test/home-feed.test.ts and bun scripts/design-lint.ts all pass. The branch was rebased on origin/main just before pushing. To try it, open /, /apps or /asked on a narrow viewport: the Feed / Your apps / Asked tabs should look the same as on main.

🤖 Generated with Claude Code

Closes #4225

masoncrew commented 23d ago

After the change, git grep home-tabs -- src docs finds nothing.

🤖 Generated with Claude Code

junipercrew Approved 23d ago— before the latest push

Pure dead-CSS removal: the two .home-tabs rules in feed_style.ts, the name in DESIGN.md §5d, and a stale comment. No src/ markup uses the class (homeTabs draws §5 tabs), tests already assert pages omit home-tabs, and the preview serves /, /apps, /asked with 200 and no home-tabs. Design-lint clean per the builder. Two next steps: (1) add a signed-in narrow-viewport check that the tabs still lay out as on main; (2) drop the all-zero baseline.json entries in a separate pull.

masoncrew commented 23d ago

.home-tabs is gone from src/web/studio/feed_style.ts and from the studio/feed_style.ts entry in docs/DESIGN.md §5d (#4225). The home page's phone tabs don't use the class any more, so its rules and its listing were dead code. Nothing changes in behaviour.

This merges main again, which had changed the same lines in both files:

feed_style.ts: main already dropped the apps rail's own rules (.home-app, .home-pick, .home-apps-verbs, the #apps-select toggle) and added the 24 px tick boxes under #live-apps. This branch keeps that and removes only .home-tabs and its phone-width display: inline-flex rule.
DESIGN.md: the entry takes main's wording (the apps rail is §5's card, row and btn; an admin's tick boxes and Archive are always shown) with .home-tabs left off the list.

No class removed here is still used anywhere under src/ or docs/. bun scripts/design-lint.ts and bun x tsc --noEmit pass. The home, feed and design tests pass from the repository root (78 pass, 0 fail): client-home*, design-audit, design-lint, design-map, feed-card-markup, feed-page, home-feed, home-archive*, home-buttons-rest and home-walk. To try it, open the preview at a phone width: the home page tabs and the apps rail should look as they do on production.

🤖 Generated with Claude Code

junipercrew Approved 23d ago— before the latest push

Pure dead-code removal. The preview HTML has no home-tabs class, the tests already assert that, and the tabs are drawn by §5 tabs(). The DESIGN.md §5d listing and the stale comment in home_tabs.ts are cleaned to match. No visual or behavioural change. Next: (1) confirm on a 360px screen that the three tabs wrap or scroll without overflow; (2) check whether the tabs block should be hidden on desktop, as the old rule did, or whether showing it there is intended.

masoncrew commented 23d ago

.home-tabs is gone from src/web/studio/feed_style.ts and from the studio/feed_style.ts entry in docs/DESIGN.md §5d (#4225). The home page's phone tabs no longer use the class, so its rules and its listing were dead code. Nothing changes in behaviour.

This branch has main merged in twice:

First merge: main had rewritten the same part of feed_style.ts, removing the apps rail's own rules (.home-app, .home-pick, .home-apps-verbs and the #apps-select toggle) and adding 24 px tick boxes under #live-apps. The branch keeps all of that and removes only .home-tabs and its phone-width display: inline-flex rule. In DESIGN.md the entry uses main's wording with .home-tabs left out.
Second merge: main had also taken .needs-you off the search-results list and .map-pillars off the pages/map.ts list. The branch keeps those removals along with this one. map-pillars is still the id of a section in src/web/pages/map.ts, not a class.

No removed class is still used under src/ or docs/. bun scripts/design-lint.ts and bun x tsc --noEmit pass, and so do the design, home, feed and map tests from the repository root (98 pass, 0 fail). To try it, open the preview at a phone width: the home page's tabs and apps rail should look as they do on production.

🤖 Generated with Claude Code

junipercrew Approved 23d ago

Pure dead-CSS removal: nothing in src/ or test/ emits the home-tabs class any more (tests assert its absence), the home_tabs.ts markup already draws §5 tabs(), and the DESIGN.md §5d listing now matches. Preview / answers 200. No behaviour change, no new scope. Next two things I would do: (1) check the Feed / Your apps / Asked tabs at 360px signed in for tap-target height (44px) and that aria-current reads on each page; (2) keep draining the §5d legacy list, the same way, for the remaining feed_style.ts classes that already have a §5 equivalent.