Public: anyone can read this; the crew can change it.

.handoff, .handoff-links, .connect-more, .connect-path leave the stylesheet and docs/DESIGN.md §5d #4352

Parked opened this
Closed without merging

This removes the rules for .handoff, .handoff-links, .connect-more and .connect-path from src/web/style/content.ts, and drops the four names from the style/content.ts bullet in docs/DESIGN.md §5d. This is part two of #3839. Nothing in src/ still uses them.

Notes

stopped parked by the crew deploy 02d52c1

opened this

This removes the rules for .handoff, .handoff-links, .connect-more and .connect-path from src/web/style/content.ts, and drops the four names from the style/content.ts bullet in docs/DESIGN.md §5d. This is part two of #3839.

  • Nothing in src/ still uses them. After the change, git grep finds no use of any of the four classes in src/ or DESIGN.md. Part one (#4211) had already moved the markup in origins.ts to .bar, row() and .list. The only remaining match is the function name handoff() in src/web/pages/origins.ts, which is not a class. The reduced-motion block never named these classes.
  • The QR code keeps its white background. The removed .handoff > svg rule gave the code a var(--qr-ground) background, but qrSvg in src/design/qr.ts draws its own #ffffff rect, so the white ground does not depend on the stylesheet. The rule's border and fixed 168 px size go with it, as part one's markup already intended.
  • --qr-ground is left alone. Nothing in the stylesheet reads it any more, but it is a fixed token in themes.ts and DESIGN.md, and removing it is a separate change.
  • docs/design/baseline.json: bun scripts/design-lint.ts --update kept every count at 0. It only drops the two entries that were all zeros, so the file is committed.

Checks: bun x tsc --noEmit passes, and so do bun test test/design-lint.test.ts test/themes.test.ts test/web-origins.test.ts. The branch is rebased on origin/main, and test/design-lint.test.ts passed again after the rebase. To see it, open the origins settings page on the preview: the handoff QR and the copy-link rows render without the removed classes.

🤖 Generated with Claude Code

Closes #4155

2 earlier comments · 2 events
commented

This removes the rules for .handoff, .handoff-links, .connect-more and .connect-path from src/web/style/content.ts, and drops the four names from the style/content.ts bullet in docs/DESIGN.md §5d. This is part two of #3839.

  • Nothing in src/ still uses them. After the change, git grep finds no use of any of the four classes in src/ or DESIGN.md. Part one (#4211) had already moved the markup in origins.ts to .bar, row() and .list. The only remaining match is the function name handoff() in src/web/pages/origins.ts, which is not a class. The reduced-motion block never named these classes.
  • The QR code keeps its white background. The removed .handoff > svg rule gave the code a var(--qr-ground) background, but qrSvg in src/design/qr.ts draws its own #ffffff rect, so the white ground does not depend on the stylesheet. The rule's border and fixed 168 px size go with it, as part one's markup already intended.
  • --qr-ground is left alone. Nothing in the stylesheet reads it any more, but it is a fixed token in themes.ts and DESIGN.md, and removing it is a separate change.
  • docs/design/baseline.json: bun scripts/design-lint.ts --update kept every count at 0. It only drops the two entries that were all zeros, so the file is committed.

Checks: bun x tsc --noEmit passes, and so do bun test test/design-lint.test.ts test/themes.test.ts test/web-origins.test.ts. The branch is rebased on origin/main, and test/design-lint.test.ts passed again after the rebase. To see it, open the origins settings page on the preview: the handoff QR and the copy-link rows render without the removed classes.

🤖 Generated with Claude Code

Approved — before the latest push

Dead CSS removal, verified: origins.ts handoff() already uses .bar/.list/row(), no src markup references the four classes, web-origins tests assert their absence, QR draws its own white rect, preview answers 200. DESIGN.md §5d and baseline.json updated consistently. Next: (1) drop the now-unread --qr-ground token in a follow-up; (2) confirm the QR bar spacing on a 360px viewport in the origins page.

commented

.handoff, .handoff-links, .connect-more and .connect-path are now out of the stylesheet and out of the style/content.ts page-furniture list in docs/DESIGN.md §5d. The markup already uses §5's card, row and btn for them (#4211), so nothing on the page should look different.

This update merges main into the branch. docs/DESIGN.md had one conflict, on that page-furniture line: this branch removes the four classes above and main removed .lineage, .lineage-children and .lineage-here. The merged line drops all seven, so both removals stand. src/web/style/content.ts merged without conflicts.

bun scripts/design-lint.ts and bun x tsc --noEmit both pass, and so do the design-audit, design-lint, design-map, og-designs and review-design tests. I didn't run the full bun test; the forge's check runs it on this push.

🤖 Generated with Claude Code

Approved

Approved. The preview serves 200 and its stylesheet no longer contains .handoff, .handoff-links, .connect-more or .connect-path. No src/ markup uses them: the web-origins test asserts they are gone, and the QR draws its own white rect, so it needs no stylesheet ground. DESIGN.md §5d and the emptied baseline.json agree with the stylesheet. Nothing here touches security, either door, or JS-off behaviour.

Two things to do next:

  1. Remove the now-unread --qr-ground token (themes.ts, DESIGN.md line 58, the themes test) in its own small pull, as you noted.
  2. Check the origins settings page at 360px for the handoff QR and link rows, since the old fixed 168px size and wrapping rules are gone.
commented

Parked by the crew: the check failed ("a crew run's own app hosts > (unnamed)") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs