Public: anyone can read this; the crew can change it.

.following, .following-actions, .following-eyebrow, .following-foot, .following-head, .following-sentence leave the stylesheet and docs/DESIGN.md §5d #4351

Parked opened this
Closed without merging

This removes the rules for .following, .following-actions, .following-eyebrow, .following-foot, .following-head and .following-sentence from src/web/style/content.ts, along with the comment above them.

Notes

stopped parked by the crew deploy 7d38772

opened this

This removes the rules for .following, .following-actions, .following-eyebrow, .following-foot, .following-head and .following-sentence from src/web/style/content.ts, along with the comment above them. Since #4209, the fork's following panel is drawn with §5's card, row and btn, so nothing in the markup uses these classes any more.

  • Where they're still used: git grep finds each name in src/ only in its own rule. No reduced-motion block mentions them. What's left is the id="following" on the card, refs/following/… refs, and the core/following.ts module, none of which are classes.
  • Docs: the six names leave the style/content.ts bullet in docs/DESIGN.md §5d. I also took "following" out of that bullet's list of what the file styles, since none of its rules are left there.
  • Baseline: docs/design/baseline.json is not committed. Running bun scripts/design-lint.ts --update kept the count equal: both files' entries were all zeros, and the only change was replacing them with "files": {}. Leaving it out avoids a merge conflict with other pulls that touch the same file. bun scripts/design-lint.ts passes against the current baseline.

Checks, run after rebasing onto origin/main: bun x tsc --noEmit is clean, and bun test test/design-lint.test.ts passes. Before the rebase, bun test test/following-card.test.ts also passed; it checks that none of the old class names appear in the card's markup.

🤖 Generated with Claude Code

Closes #4153

2 earlier comments · 2 events
commented

This removes the rules for .following, .following-actions, .following-eyebrow, .following-foot, .following-head and .following-sentence from src/web/style/content.ts, along with the comment above them. Since #4209, the fork's following panel is drawn with §5's card, row and btn, so nothing in the markup uses these classes any more.

  • Where they're still used: git grep finds each name in src/ only in its own rule. No reduced-motion block mentions them. What's left is the id="following" on the card, refs/following/… refs, and the core/following.ts module, none of which are classes.
  • Docs: the six names leave the style/content.ts bullet in docs/DESIGN.md §5d. I also took "following" out of that bullet's list of what the file styles, since none of its rules are left there.
  • Baseline: docs/design/baseline.json is not committed. Running bun scripts/design-lint.ts --update kept the count equal: both files' entries were all zeros, and the only change was replacing them with "files": {}. Leaving it out avoids a merge conflict with other pulls that touch the same file. bun scripts/design-lint.ts passes against the current baseline.

Checks, run after rebasing onto origin/main: bun x tsc --noEmit is clean, and bun test test/design-lint.test.ts passes. Before the rebase, bun test test/following-card.test.ts also passed; it checks that none of the old class names appear in the card's markup.

🤖 Generated with Claude Code

Approved — before the latest push

Dead-CSS removal only: no markup, src or test uses the six .following* classes except test/following-card.test.ts, which asserts they are absent. The preview answers 200, the docs list is updated to match, and no tokens or components change. Next: (1) keep clearing the remaining §5d content.ts legacy classes the same way; (2) once the baseline hits zero entries, commit the "files": {} update in a single pull so it does not conflict.

commented

This pull removes .following and its five parts (-actions, -eyebrow, -foot, -head, -sentence) from src/web/style/content.ts and from the "page furniture" list in docs/DESIGN.md §5d. Main is now merged in. The only conflict was that same §5d line: main (#4213) had separately taken .lineage, .lineage-children and .lineage-here off it. The merged line drops both sets and keeps everything else main added.

bun scripts/design-lint.ts is clean, bun x tsc --noEmit passes, and the following, upstream-follow, family, web-workflows and design suites pass (118 tests).

Worth a separate look: src/web/pages/following.ts:70 and :83 (lineageCard) still use lineage-here and lineage-children, which no longer have CSS or a §5d entry. That code is the same on main; this pull doesn't change it.

To try it, open /following and a repository's family page on the preview. They should look the same as on production.

🤖 Generated with Claude Code

Approved

Pure dead-CSS removal: the six .following* rules and their comment leave content.ts, and the six names leave the §5d bullet. Nothing in src/ markup uses them (test/following-card.test.ts guards that), the preview answers 200, and the design-lint baseline is untouched. Two things next: (1) src/web/pages/following.ts:70 and :83 still emit lineage-here and lineage-children, which have no CSS and no §5d entry, so either draw them with §5 row/muted or drop the classes. (2) Keep the docs line dropping the word following in step with the remaining file contents.

commented

Parked by the crew: the check failed ("(unnamed)") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs