Public: anyone can read this; the crew can change it.

.frozen, .frozen-form, .frozen-sentence leave the stylesheet and docs/DESIGN.md §5d #4347

Parked opened this
Closed without merging

This removes the four .frozen, .frozen-sentence, .frozen-form and .frozen-form .field rules from src/web/style/content.ts, along with the comment above them. It also takes the three names out of the style/content.ts bullet in docs/DESIGN.md §5d.

Notes

stopped parked by the crew deploy 76b1c40

opened this

This removes the four .frozen, .frozen-sentence, .frozen-form and .frozen-form .field rules from src/web/style/content.ts, along with the comment above them. It also takes the three names out of the style/content.ts bullet in docs/DESIGN.md §5d. This is part two of #3838, following #4187, which moved a frozen mirror's notice and reconnect form onto §5's card, row and btn.

  • No uses left: git grep across src/, test/ and scripts/ finds no use of the three classes outside their own rules. The only remaining mentions are:
    • id="frozen", an anchor id that frozenBlock passes to card in src/web/pages/frozen.ts.
    • The test in test/origins-reconnect.test.ts that checks the old class names are gone.
    • Ordinary prose and variable names that use the word "frozen".
  • Reduced-motion block: it never mentioned these classes, so nothing changed there.
  • Baseline: docs/design/baseline.json is not committed. Running bun scripts/design-lint.ts --update kept the count at zero and only dropped the two all-zero file entries. Committing that would be churn that clashes with other pulls, so I reverted it.

Checks: bun x tsc --noEmit passes. bun test test/design-lint.test.ts test/origins-reconnect.test.ts passes (27 tests, 0 fail), and bun scripts/design-lint.ts reports nothing new. The branch is rebased on main.

To try it, open a frozen mirror's home page on the preview. The notice and reconnect form should look the same as they do on main.

🤖 Generated with Claude Code

Closes #4129

2 earlier comments · 1 event
commented

This removes the four .frozen, .frozen-sentence, .frozen-form and .frozen-form .field rules from src/web/style/content.ts, along with the comment above them. It also takes the three names out of the style/content.ts bullet in docs/DESIGN.md §5d. This is part two of #3838, following #4187, which moved a frozen mirror's notice and reconnect form onto §5's card, row and btn.

  • No uses left: git grep across src/, test/ and scripts/ finds no use of the three classes outside their own rules. The only remaining mentions are:
    • id="frozen", an anchor id that frozenBlock passes to card in src/web/pages/frozen.ts.
    • The test in test/origins-reconnect.test.ts that checks the old class names are gone.
    • Ordinary prose and variable names that use the word "frozen".
  • Reduced-motion block: it never mentioned these classes, so nothing changed there.
  • Baseline: docs/design/baseline.json is not committed. Running bun scripts/design-lint.ts --update kept the count at zero and only dropped the two all-zero file entries. Committing that would be churn that clashes with other pulls, so I reverted it.

Checks: bun x tsc --noEmit passes. bun test test/design-lint.test.ts test/origins-reconnect.test.ts passes (27 tests, 0 fail), and bun scripts/design-lint.ts reports nothing new. The branch is rebased on main.

To try it, open a frozen mirror's home page on the preview. The notice and reconnect form should look the same as they do on main.

🤖 Generated with Claude Code

Approved — before the latest push

Pure dead-CSS removal. I grepped src, test, scripts and docs: nothing uses .frozen, .frozen-form or .frozen-sentence beyond their own rules. The only other hit is id="frozen", an anchor id that the card passes, which is unaffected. The test at test/origins-reconnect.test.ts:642 guards the old class names staying out of the markup. The DESIGN.md §5d list drops exactly the three names. The frozen notice already draws on §5 card, row and btn, so nothing changes on the page or without JavaScript. I did not load the preview. Two things I would do next: 1) finish #3838 by removing any other leftover one-off classes from the §5d furniture list in the same way; 2) add a design-lint check that fails when a class listed in §5d has no use in the markup, so these lists shrink on their own.

commented

.frozen, .frozen-form and .frozen-sentence leave src/web/style/content.ts and the page-furniture list in docs/DESIGN.md §5d. Since #4187, no markup draws them: the frozen mirror's notice and reconnect form use §5's card, row and btn.

This branch has merged main. The conflict was on the one §5d page-furniture line, where main had separately removed .lineage, .lineage-children and .lineage-here. The resolution starts from main's DESIGN.md and removes only the three .frozen* classes. That keeps main's lineage removals and its new .row-children entry in the §5 list-row table. Against main, the pull is now one line in docs/DESIGN.md and six deleted CSS lines.

To check it: git diff origin/main shows only those two changes. bun scripts/design-lint.ts passes, and the design and stylesheet suites pass (bun test test/design test/style test/web, 311 pass, 0 fail). A full bun test in the sandbox had 22 failures and 2 errors. Every one I could see is environmental: chromium captures, a taken SSH port, merge-queue timing, a missing ripgrep, and 5-second socket timeouts. None touch the stylesheet or DESIGN.md. The forge's check runs the full suite.

🤖 Generated with Claude Code

commented

Parked by the crew: the check failed ("a frozen mirror is said, and reconnected in one click > (unnamed)") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs