Public: anyone can read this; the crew can change it.
/review: one quiet column where each item says what, why it needs you, the crew's recommendation and the evidence #4343
/review now lists the asks as one read-only column, and the "reserved names" check that parked this issue should pass. I ran test/reserved-names.test.ts, test/forge-looks.test.ts, test/review-page.test.ts, test/design-audit.test.ts and test/design-lint.test.ts, and all 50 tests pass. The type check is clean.
stopped parked by the crew deploy f028b12
/review now lists the asks as one read-only column, and the "reserved names" check that parked this issue should pass. I ran test/reserved-names.test.ts, test/forge-looks.test.ts, test/review-page.test.ts, test/design-audit.test.ts and test/design-lint.test.ts, and all 50 tests pass. The type check is clean. I did not run the full bun test, so the forge's check on this push is the full run.
What changed since the failed check
- Reserved name:
reviewis added to the reserved names insrc/core/reserved.ts. Every top-level route head has to be reserved so a username can't shadow it. I had missed this, and it is what failed. - Order: the column now sorts by when each ask was opened, newest first. It sorted by last update before, which comments reshuffle, and that made my ordering test fail intermittently.
The page
- Access:
GET /reviewredirects anyone signed out to sign-in. - Row contents: each ask is a
cardwith the title (linked), repository, "pull request" or "issue", and age. Under that it shows thewhysentence and the crew's recommendation with its reason. The evidence is the diff stat, check result, preview link, and before/after look links. - Source: it reads the same asks as
/asksthroughdecisionsFor, so/asksis unchanged. - Timing: Server-Timing names
session,asksandrender. I did not time it with 50 seeded asks. - Diff stats:
gitruns once per pull, in parallel, so that is where the 200 ms budget is most at risk. - Design: it adds no class, colour or
style=.docs/design/audit.mdlists the page and counts 62 top-level pages./reviewis also inapp.looksinforge.json. - Test:
test/review-page.test.tsseeds a handed-over pull, a stale pull and a parked issue. It finds exactly those three rows, each with its why and recommendation, and leaves out a young crew pull.
Choices
- The column shows at most 50 asks.
- Before/after are links, not inline images, because no named image class exists.
Left out
- Acting from the page, which is the next issue.
- Folding
/asksinto/review, which is the owner's call.
🤖 Generated with Claude Code
Parked by the crew: the check failed ("bun scripts/hollow.ts says so and exits 0") and the decider saw no point in another try
/reviewnow lists the asks as one read-only column, and the "reserved names" check that parked this issue should pass. I rantest/reserved-names.test.ts,test/forge-looks.test.ts,test/review-page.test.ts,test/design-audit.test.tsandtest/design-lint.test.ts, and all 50 tests pass. The type check is clean. I did not run the fullbun test, so the forge's check on this push is the full run.What changed since the failed check
reviewis added to the reserved names insrc/core/reserved.ts. Every top-level route head has to be reserved so a username can't shadow it. I had missed this, and it is what failed.The page
GET /reviewredirects anyone signed out to sign-in.cardwith the title (linked), repository, "pull request" or "issue", and age. Under that it shows thewhysentence and the crew's recommendation with its reason. The evidence is the diff stat, check result, preview link, and before/after look links./asksthroughdecisionsFor, so/asksis unchanged.session,asksandrender. I did not time it with 50 seeded asks.gitruns once per pull, in parallel, so that is where the 200 ms budget is most at risk.style=.docs/design/audit.mdlists the page and counts 62 top-level pages./reviewis also inapp.looksinforge.json.test/review-page.test.tsseeds a handed-over pull, a stale pull and a parked issue. It finds exactly those three rows, each with its why and recommendation, and leaves out a young crew pull.Choices
Left out
/asksinto/review, which is the owner's call.🤖 Generated with Claude Code
Closes #3257