Public: anyone can read this; the crew can change it.

The map's pillars section draws §5's row and badge, and .map-pillars leaves the markup while its id stays #4330

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

The map's "By pillar" section now draws each pillar as a §5 `row` with a `badge` for its counts, and `.map-pillars` no longer appears in the markup. `id="map-pillars"` stays, and the section keeps `map-list` for #4292.

shipped production is serving it deploy e2a191c

opened this

The map's "By pillar" section now draws each pillar as a §5 row with a badge for its counts, and .map-pillars no longer appears in the markup. id="map-pillars" stays, and the section keeps map-list for #4292.

The checks I ran all passed: bun x tsc --noEmit, bun scripts/design-lint.ts, and bun test test/design-lint.test.ts test/limbs.test.ts test/pillars.test.ts test/map.test.ts (46 pass, 0 fail). test/limbs.test.ts was green, so the counts-line regex at :455 did not come up and I left it alone.

  • Pillar rows: each pillar's name is still a link to its milestone, or to its issue list when it has no umbrella. The "merged · ask to live" text, with its tooltip and the slowest-issue link, moved into the row's meta line.
  • Counts badge: the N open · N ready · N blocked text (or "nothing open") is now the badge, in the row's trailing slot.
  • "no pillar" row: it keeps its badge and its issue links, and still carries data-pillar="".
  • Stylesheet: I deleted no rules and did not touch docs/DESIGN.md. I added two rules to src/web/pages/map.ts's stylesheet, because the existing .map-list li span { display: block } would otherwise break the row layout inside the section. #4239 can drop both along with the rest.
  • Test change: the assertion at test/pillars.test.ts:403 expected the old <b>no pillar</b>. That markup is gone by design, so I replaced it. It now checks that no class contains map-pillars, that the row title and the badge render, and that data-pillar is present. The existing checks on the id, the milestone link, the count text and the issue links are unchanged.

To try it, open /<owner>/<repo>/map on a repository that has pillars, and look at the "By pillar" section.

🤖 Generated with Claude Code

Closes #4314

commented

The map's "By pillar" section now draws each pillar as a §5 row with a badge for its counts, and .map-pillars no longer appears in the markup. id="map-pillars" stays, and the section keeps map-list for #4292.

The checks I ran all passed: bun x tsc --noEmit, bun scripts/design-lint.ts, and bun test test/design-lint.test.ts test/limbs.test.ts test/pillars.test.ts test/map.test.ts (46 pass, 0 fail). test/limbs.test.ts was green, so the counts-line regex at :455 did not come up and I left it alone.

  • Pillar rows: each pillar's name is still a link to its milestone, or to its issue list when it has no umbrella. The "merged · ask to live" text, with its tooltip and the slowest-issue link, moved into the row's meta line.
  • Counts badge: the N open · N ready · N blocked text (or "nothing open") is now the badge, in the row's trailing slot.
  • "no pillar" row: it keeps its badge and its issue links, and still carries data-pillar="".
  • Stylesheet: I deleted no rules and did not touch docs/DESIGN.md. I added two rules to src/web/pages/map.ts's stylesheet, because the existing .map-list li span { display: block } would otherwise break the row layout inside the section. #4239 can drop both along with the rest.
  • Test change: the assertion at test/pillars.test.ts:403 expected the old <b>no pillar</b>. That markup is gone by design, so I replaced it. It now checks that no class contains map-pillars, that the row title and the badge render, and that data-pillar is present. The existing checks on the id, the milestone link, the count text and the issue links are unchanged.

To try it, open /<owner>/<repo>/map on a repository that has pillars, and look at the "By pillar" section.

🤖 Generated with Claude Code

Approved

The pillar rows now use the §5 row and badge, the map-pillars class is gone from the markup, and id=map-pillars stays. The pillar name stays a link, the counts moved into the badge, and the test pins all of it. I read the diff and the preview answers 200; I did not render the map section on a repo with pillars. Next: (1) delete the now-dead .map-ask and .map-pillars ul rules, and the .map-pillars and .map-ask entries in docs/DESIGN.md §5d, in the follow-up. (2) Replace the two display overrides added to fight .map-list li span with a scoped rule once .map-list is retired.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs