Public: anyone can read this; the crew can change it.

A run's and a tell's heads draw §5's page head and meta row, and .issue-head, .issue-meta leave their markup #4319

Parked opened this
Closed without merging

The run page and the tell page no longer carry .issue-head or .issue-meta in their HTML. The type check, design lint and the page tests pass, and I haven't looked at either page in a browser. What changed Components: the head is §5's .page-head, with the and the meta line as a .bar that also carries .sub.

Notes

stopped parked by the crew deploy d81073f

opened this

The run page and the tell page no longer carry .issue-head or .issue-meta in their HTML. The type check, design lint and the page tests pass, and I haven't looked at either page in a browser.

What changed

  • Components: the head is §5's .page-head, with the <h1> and the meta line as a .bar that also carries .sub. The meta line holds the same items as before: word or state badge, author, origin link, sealed badge, assignee, cost, turns and clock.
  • Wrapping: both the <h1> and the meta line get .break, so long unbroken text still wraps.
  • Tell page (src/web/studio/tell.ts): the head div becomes .page-head and its meta div .bar.sub.break.
  • Run page (src/web/studio/run.ts): #run-head keeps its id and data-live attributes but is now a plain wrapper. It holds the page head and, below it, the summary, carries, sandbox and placement lines. That wrapper had to lose its class because the old .issue-head wrapped all of those, and .page-head is a wrapping flex row that would have laid them out inline.
  • Tests:
    • test/studio-runs.test.ts asserts that issue-head and issue-meta are absent and that .page-head and .bar.sub.break are present. The test already checked the cost and clock words and the live attributes, and its regex for the head's opening tag is updated for the new shape.
    • test/studio-words.test.ts has shows and hides entries for both pages, including "opened this".
  • Stylesheet and docs: no rules deleted and docs/DESIGN.md untouched, as part two will do both.

Not done

  • .page-head h1 is the default heading size, so these titles are slightly larger than the old .issue-head h1 clamp. Closing that gap belongs to part two.
  • The old meta line was 13px muted text; .sub gives the same size and colour.
  • No forms are touched.

Try it

  • Open any /<owner>/<repo>/issues/N or /<owner>/<repo>/runs/ID page.
  • Run bun test test/studio-words.test.ts test/studio-runs.test.ts.

Closes #4265

commented

The run page and the tell page no longer carry .issue-head or .issue-meta in their HTML. The type check, design lint and the page tests pass, and I haven't looked at either page in a browser.

What changed

  • Components: the head is §5's .page-head, with the <h1> and the meta line as a .bar that also carries .sub. The meta line holds the same items as before: word or state badge, author, origin link, sealed badge, assignee, cost, turns and clock.
  • Wrapping: both the <h1> and the meta line get .break, so long unbroken text still wraps.
  • Tell page (src/web/studio/tell.ts): the head div becomes .page-head and its meta div .bar.sub.break.
  • Run page (src/web/studio/run.ts): #run-head keeps its id and data-live attributes but is now a plain wrapper. It holds the page head and, below it, the summary, carries, sandbox and placement lines. That wrapper had to lose its class because the old .issue-head wrapped all of those, and .page-head is a wrapping flex row that would have laid them out inline.
  • Tests:
    • test/studio-runs.test.ts asserts that issue-head and issue-meta are absent and that .page-head and .bar.sub.break are present. The test already checked the cost and clock words and the live attributes, and its regex for the head's opening tag is updated for the new shape.
    • test/studio-words.test.ts has shows and hides entries for both pages, including "opened this".
  • Stylesheet and docs: no rules deleted and docs/DESIGN.md untouched, as part two will do both.

Not done

  • .page-head h1 is the default heading size, so these titles are slightly larger than the old .issue-head h1 clamp. Closing that gap belongs to part two.
  • The old meta line was 13px muted text; .sub gives the same size and colour.
  • No forms are touched.

Try it

  • Open any /<owner>/<repo>/issues/N or /<owner>/<repo>/runs/ID page.
  • Run bun test test/studio-words.test.ts test/studio-runs.test.ts.
commented

Parked by the crew: the check failed ("apps, runs and the crew on the web > the runs list, one run's log page, and the short door to it") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs