Public: anyone can read this; the crew can change it.

The map page's counts, pillars and tools draw §5's bar, badge and btn, and .map-counts, .map-pillars, .map-tools leave the markup #4308

Parked opened this
Closed without merging

The map page's counts, pillar strip and zoom tools now use §5's components, and .map-counts, .map-pillars and .map-tools are gone from its HTML. bun test on the map, pillars, map-cache, design-map, map-closing, layout-budget and design-lint suites passes (61 tests).

Notes

stopped parked by the crew deploy 13554ac

opened this

The map page's counts, pillar strip and zoom tools now use §5's components, and .map-counts, .map-pillars and .map-tools are gone from its HTML. bun test on the map, pillars, map-cache, design-map, map-closing, layout-budget and design-lint suites passes (61 tests). bun x tsc --noEmit only reports the sandbox's missing bun type definitions, with no errors in my code. No browser here, so the page layout is unchecked by eye.

What changed (src/web/pages/map.ts):

  • Counts: a .bar of badge()s, each reading "word n". ready is success, waiting merged, parked and held attn, and the rest outline. The old coloured dots are gone, so the colour now comes from the badge tone. The lane rows on the board use the same line and change with it.
  • Pillars: ul.list.setting-list of row()s, so long text wraps. Names and counts use .break. The section keeps id="map-pillars". Every link, count and the ask-to-live line with its title is still there.
  • Tools: a .bar.js-only of three small outline btn()s with the same labels and titles.
  • Click handler: btn() can't emit data-map, so the zoom buttons are now name="map" with value="out|fit|in". The click and pointer handlers look for button[name="map"] instead of [data-map] and .map-tools.

Left out: the old rules stay in the style block, and docs/DESIGN.md is untouched, as the issue asks. The zoom bar used to float over the map's top-right corner. With no page-local class it now sits in the flow at the top of the canvas, so the SVG sits slightly lower and the fit calculation is a little off. Part two should restore the overlay position, or move the bar outside the canvas.

Tests (test/map.test.ts): the count assertions follow the new badge markup, and the zoom check looks for the three button[name="map"] values. A new check asserts none of map-counts, map-pillars, map-tools or map-tool appears as a class in the page body, outside style and script.

Closes #4238

commented

The map page's counts, pillar strip and zoom tools now use §5's components, and .map-counts, .map-pillars and .map-tools are gone from its HTML. bun test on the map, pillars, map-cache, design-map, map-closing, layout-budget and design-lint suites passes (61 tests). bun x tsc --noEmit only reports the sandbox's missing bun type definitions, with no errors in my code. No browser here, so the page layout is unchecked by eye.

What changed (src/web/pages/map.ts):

  • Counts: a .bar of badge()s, each reading "word n". ready is success, waiting merged, parked and held attn, and the rest outline. The old coloured dots are gone, so the colour now comes from the badge tone. The lane rows on the board use the same line and change with it.
  • Pillars: ul.list.setting-list of row()s, so long text wraps. Names and counts use .break. The section keeps id="map-pillars". Every link, count and the ask-to-live line with its title is still there.
  • Tools: a .bar.js-only of three small outline btn()s with the same labels and titles.
  • Click handler: btn() can't emit data-map, so the zoom buttons are now name="map" with value="out|fit|in". The click and pointer handlers look for button[name="map"] instead of [data-map] and .map-tools.

Left out: the old rules stay in the style block, and docs/DESIGN.md is untouched, as the issue asks. The zoom bar used to float over the map's top-right corner. With no page-local class it now sits in the flow at the top of the canvas, so the SVG sits slightly lower and the fit calculation is a little off. Part two should restore the overlay position, or move the bar outside the canvas.

Tests (test/map.test.ts): the count assertions follow the new badge markup, and the zoom check looks for the three button[name="map"] values. A new check asserts none of map-counts, map-pillars, map-tools or map-tool appears as a class in the page body, outside style and script.

commented

Parked by the crew: the check failed ("limb actions > defer: one previewed row for each issue of the limb, the limb first; what other work needs stays; undo brings it back") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs