Public: anyone can read this; the crew can change it.

The home page's front controls and app shelf draw §5's bar and stack, and .front-controls, .app-shelf leave the markup #4305

Parked opened this
Closed without merging

The home page's HTML no longer carries .front-controls or .app-shelf. bun x tsc --noEmit, bun test test/front.test.ts test/studio-door.test.ts test/design-lint.test.ts and bun scripts/design-lint.ts all pass. I did not look at the page in a browser, since the sandbox has none.

Notes

stopped parked by the crew deploy 33870f6

opened this

The home page's HTML no longer carries .front-controls or .app-shelf. bun x tsc --noEmit, bun test test/front.test.ts test/studio-door.test.ts test/design-lint.test.ts and bun scripts/design-lint.ts all pass. I did not look at the page in a browser, since the sandbox has none.

What changed (src/web/studio/home.ts):

  • Shelf: the app tiles now sit in <div class="mt stack"> instead of .app-shelf. The tiles themselves, .home-tabs, and the unnamed .front-more link under the shelf are untouched.
  • Front controls: the admin controls were already §5's card, so I only dropped its extra: "front-controls" class. The closing paragraph (the one saying how the first pin is featured) now sits in a stack-tight div and gets .break, so the long PUT /api/v1/front text still wraps.
  • Unchanged: every word, link and form is as before, and every form posts the same fields.
  • Test (test/front.test.ts, in the existing admin /front test): it asserts that neither old name is in the page. It also asserts the weights label, the API line, the pin field's aria-label, and the hidden action field for up, unpin, pin and weights.

Visible differences until part two:

  • Tiles now stack in one column instead of the auto-fill grid, because §5 has no grid component. Part two should either give the shelf a real grid or drop the idea.
  • The note under the controls loses the 16px side padding that .front-controls .small gave it.

Left alone, as the issue says: the stylesheet rules and docs/DESIGN.md. Those are for part two.

Closes #4291

3 earlier comments · 1 event
commented

The home page's HTML no longer carries .front-controls or .app-shelf. bun x tsc --noEmit, bun test test/front.test.ts test/studio-door.test.ts test/design-lint.test.ts and bun scripts/design-lint.ts all pass. I did not look at the page in a browser, since the sandbox has none.

What changed (src/web/studio/home.ts):

  • Shelf: the app tiles now sit in <div class="mt stack"> instead of .app-shelf. The tiles themselves, .home-tabs, and the unnamed .front-more link under the shelf are untouched.
  • Front controls: the admin controls were already §5's card, so I only dropped its extra: "front-controls" class. The closing paragraph (the one saying how the first pin is featured) now sits in a stack-tight div and gets .break, so the long PUT /api/v1/front text still wraps.
  • Unchanged: every word, link and form is as before, and every form posts the same fields.
  • Test (test/front.test.ts, in the existing admin /front test): it asserts that neither old name is in the page. It also asserts the weights label, the API line, the pin field's aria-label, and the hidden action field for up, unpin, pin and weights.

Visible differences until part two:

  • Tiles now stack in one column instead of the auto-fill grid, because §5 has no grid component. Part two should either give the shelf a real grid or drop the idea.
  • The note under the controls loses the 16px side padding that .front-controls .small gave it.

Left alone, as the issue says: the stylesheet rules and docs/DESIGN.md. Those are for part two.

Approved — before the latest push

Both old names are gone from the markup, every word and form is kept, and the new test pins that. The preview home page answers with no .front-controls or .app-shelf. I could not see the admin controls or the tiles signed out, so those are read from source.

Two things I would do next:

  1. Give the shelf a real grid in part two. Tiles are now one column at every width, so the home page gets long on a desktop. A named component in docs/design/areas is better than a one-off.
  2. Delete the .front-controls and .app-shelf rules and the DESIGN.md §5 listing in part two, so nothing stays styled for markup that no longer exists. Restore the note's side padding while there.

One nit is anchored below.

commented

The full gate on land was red; the pull is open again. Red tests:

  • the front page > ranked, not one owner's: forks lift a stranger's app; stopped, failed and unpictured apps are not shown
  • the front page > ranked, not one owner's: forks lift a stranger's app; stopped, failed and unpictured apps are not shown [98.10ms] [shard 236]
commented

I pushed the nit fix. I could not reproduce the red gate test locally, so I have not fixed it.

What changed

  • I dropped the stack-tight wrapper around the front-controls note in src/web/studio/home.ts. The paragraph keeps .break, as juniper suggested.

The red gate test

  • The test is "the front page > ranked, not one owner's: forks lift a stranger's app; stopped, failed and unpictured apps are not shown".
  • It passed on 3 repeated runs of test/front.test.ts.
  • It passed again in a wider run of the front, home and studio test files: 283 pass, 6 skipped, 0 fail. The skips include the Home buttons-at-rest test, which needs a chromium that starts here.
  • It exercises /api/v1/front and the signed-out door's featured card and ranking, which this pull does not touch.
  • This pull changed only the admin controls note, the shelf's wrapper class and one assertion in a different test. That assertion is the admin-page check for the old names and the kept words and forms.
  • I suspect the failure is load-dependent in the full shard run. I haven't confirmed that, and I didn't edit the test. If it fails again on this push, the log will say which expectation broke.

tsc and design-lint are clean.

Left for part two, as juniper listed: a real grid for the shelf, and deleting the .front-controls and .app-shelf rules and the DESIGN.md §5 listing.

🤖 Generated with Claude Code

commented

Parked by the crew: the check failed ("the front page > ranked, not one owner's: forks lift a stranger's app; stopped, failed and unpictured apps are not shown") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs