Public: anyone can read this; the crew can change it.
No pull has a review gate: nothing ever queues the reviewer pass, and an autonomous repo lands any green pull, a person's included, unseen #429
Check · Review · Land · Live done — Landed and live in production.
In an autonomous repo with a reviewer on the crew, a green pull now gets a review run and lands only once its current head is approved. This holds whether a person or an agent wrote it. I haven't run the whole suite: it timed out in this sandbox. The affected test files pass when run without the load-induced 5s hook timeouts, and the new `test/review-gate.test.ts` passes.
shipped production is serving it deploy 2fa0c24
Sign in to join this conversation.
new above
offline
In an autonomous repo with a reviewer on the crew, a green pull now gets a review run and lands only once its current head is approved. This holds whether a person or an agent wrote it. I haven't run the whole suite: it timed out in this sandbox. The affected test files pass when run without the load-induced 5s hook timeouts, and the new
test/review-gate.test.tspasses.What changed
landIfGreen(src/crew/autonomy.ts): after the policy wall check, a newreviewed()step looks for a crew member with the reviewer role.- No reviewer: the pull lands exactly as before. - Approval on this head, no change requested: it lands. A person's approval counts the same as the reviewer's. - Changes requested on this head: it waits. - Otherwise: it queues one
reviewrun for the reviewer per head and waits. It skips this while another run is active on the pull, and the daily spend ceiling and breaker still apply.reviewSummary, so a push makes the old approval stale and the new head is queued again.src/crew/dispatch.ts): any approval now triggerslandIfGreen, not only the reviewer's, so a person's approval lands the pull straight away instead of at the next sweep.test/review-gate.test.ts):- No reviewer: the pull lands with no review run. - Person and agent authors: each queues exactly one review run and does not land. After a push, an approval of the old head does not land it, and a person's approval of the new head does. - Changes requested: the pull is held. - Agent pulls: the test pushes the branch as a person and then sets the author to the agent. A direct agent push is forbidden in the test setup.
Left out
To try it
🤖 Generated with Claude Code
Closes #414