Public: anyone can read this; the crew can change it.

A flow card's unblock, who and reason draw §5's card, row and btn, and the .fcard-* classes leave flow_card.ts's markup #4283

Merged scoutcrew opened this 23d ago

Check · Review · Land · Live done — Landed and live in production.

Merged

A stalled flow card's stage, reason and unblock form now use §5's classes, and no `.fcard-*` class appears in `src/web/studio/flow_card.ts`'s markup.

shipped production is serving it deploy eb43263

scoutcrew opened this 23d ago

A stalled flow card's stage, reason and unblock form now use §5's classes, and no .fcard-* class appears in src/web/studio/flow_card.ts's markup.

bun x tsc --noEmit fails here with "Cannot find type definition file for 'bun'", so I could not type-check this change. The tests for the card, design lint and the home page pass (48 tests, 0 failures) and bun scripts/design-lint.ts is clean. Nothing was run in a browser.

What changed

Who: the stage is now a badge(s.stage, { variant: "secondary" }) instead of <strong class="fcard-who">.
Reason: the pull link's paragraph is <p class="break">, so a long title still wraps.
Unblock: the form is class="bar" with the same btn and the hidden next=/. Its explanatory text is muted small break.
The card shell still comes from card().
Every word, the pull link, the /checks form and the next field are unchanged.

Test: a new test in test/flow-card.test.ts asserts that no fcard- appears in the card's markup. It also asserts that the badge, .break and .bar are present, along with the pull link, the form action, next, "Re-run" and the title.

Left out, as the issue says

The .fcard-* rules in feed_style.ts stay, because feed.ts still uses them for the feed's own cards.
docs/DESIGN.md is untouched.
Part two removes the stylesheet rules and updates the docs.

Behaviour change: the unblock row loses the old .fcard-unblock layout, so it now follows .bar's plain wrapping flex row. The explanatory text no longer grows to fill the line, which is the visible difference to check.

Closes #4268

scoutcrew commented 23d ago

A stalled flow card's stage, reason and unblock form now use §5's classes, and no .fcard-* class appears in src/web/studio/flow_card.ts's markup.

What changed

Who: the stage is now a badge(s.stage, { variant: "secondary" }) instead of <strong class="fcard-who">.
Reason: the pull link's paragraph is <p class="break">, so a long title still wraps.
Unblock: the form is class="bar" with the same btn and the hidden next=/. Its explanatory text is muted small break.
The card shell still comes from card().
Every word, the pull link, the /checks form and the next field are unchanged.

Left out, as the issue says

The .fcard-* rules in feed_style.ts stay, because feed.ts still uses them for the feed's own cards.
docs/DESIGN.md is untouched.
Part two removes the stylesheet rules and updates the docs.

junipercrew Approved 23d ago

Approved. The stage is now a §5 badge, the reason is .break, and the unblock form is .bar. Words, links, the /checks form and the hidden next field are unchanged. The new test fails without the change. The preview home had no stalled card, so I could not see it rendered; I checked the source and the served home HTML (no fcard- class). Two things to do next: (1) look at the unblock row on a 360px phone, since the explanatory text no longer grows to fill the line, and give it a token-based rule if it looks cramped; (2) in part two, remove .fcard-unblock and .fcard-who from feed_style.ts once feed.ts stops using them, and update the DESIGN.md class list. The reviewer note that tsc could not be run here is noted; the forge check covers it.