Public: anyone can read this; the crew can change it.

A repository's about column draw §5's card, and .about leave the markup #4248

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

A repository's About column, on both the local repo home and the live-browse page, no longer uses `.about`. It is now a plain `<aside>` holding §5's `card()` with an `<h2>About</h2>` head.

shipped production is serving it deploy 78f82e5

opened this

A repository's About column, on both the local repo home and the live-browse page, no longer uses .about. It is now a plain <aside> holding §5's card() with an <h2>About</h2> head.

The facts (visibility, default branch, protection, branches, tags, fork of, origin, last fetch, last push) are <ul class="list"> rows from a new factList() in src/web/ui.ts. The <dl> is gone. Descriptions, clone URLs, the sealed-report link, the "Where it lives" block, and the Sync now and Mirror it forms are unchanged and post the same fields.

Left out:

  • Stylesheet: I did not delete any rules from src/web/style/content.ts, and I did not touch docs/DESIGN.md. That is part two.
  • Sticky rule: the sticky rule was keyed on .about, so I added .repo-layout > aside beside it. The About column stays sticky from 960px wide. Part two can drop the .about half of that selector.
  • .about dl styling: it now matches nothing, since the <dl> is gone. No screenshots were possible, so I haven't seen how the rows look inside the card.

Tests: the new test/repo-about-card.test.ts checks the local repo home. A test added to test/web-browse.test.ts checks the live-browse rail. Each asserts that .about and <dl are absent and that the words, links and forms are present.

bun x tsc --noEmit is clean. test/design-lint.test.ts, test/web-browse.test.ts, test/repo-about-card.test.ts and test/make-it-yours.test.ts pass.

To try it: open any repository's home page, or a live-browse page. The About card sits beside the code.

🤖 Generated with Claude Code

Closes #4144

commented

A repository's About column, on both the local repo home and the live-browse page, no longer uses .about. It is now a plain <aside> holding §5's card() with an <h2>About</h2> head.

The facts (visibility, default branch, protection, branches, tags, fork of, origin, last fetch, last push) are <ul class="list"> rows from a new factList() in src/web/ui.ts. The <dl> is gone. Descriptions, clone URLs, the sealed-report link, the "Where it lives" block, and the Sync now and Mirror it forms are unchanged and post the same fields.

Left out:

  • Stylesheet: I did not delete any rules from src/web/style/content.ts, and I did not touch docs/DESIGN.md. That is part two.
  • Sticky rule: the sticky rule was keyed on .about, so I added .repo-layout > aside beside it. The About column stays sticky from 960px wide. Part two can drop the .about half of that selector.
  • .about dl styling: it now matches nothing, since the <dl> is gone. No screenshots were possible, so I haven't seen how the rows look inside the card.

Tests: the new test/repo-about-card.test.ts checks the local repo home. A test added to test/web-browse.test.ts checks the live-browse rail. Each asserts that .about and <dl are absent and that the words, links and forms are present.

bun x tsc --noEmit is clean. test/design-lint.test.ts, test/web-browse.test.ts, test/repo-about-card.test.ts and test/make-it-yours.test.ts pass.

To try it: open any repository's home page, or a live-browse page. The About card sits beside the code.

🤖 Generated with Claude Code

commented

I merged main into the branch and pushed it. The two About-column test files pass, tsc --noEmit is clean, and design-lint passes. I didn't run the full bun test, which the forge's check runs.

Main had already landed the same change in #4050: the About column built from card and row, with .about gone from the markup. In src/web/pages/browse.ts, src/web/pages/repo.ts and src/web/style/content.ts I took main's version and dropped mine. That also removes the factList helper I had added in src/web/ui.ts, which nothing uses any more.

What this pull now adds is two tests for the About card. One is in test/repo-about-card.test.ts and one in test/web-browse.test.ts. They check that no .about or <dl> is left and that the rail still has its card, its words and the mirror form. Main's rail is <aside aria-label="About">, so I loosened the tests' selector to <aside[^>]*>.

Approved

After the merge of main (#4050 already landed the card), this pull is two regression tests: no .about class, no <dl>, the About card keeps its words, clone URL, sealed-report link and the mirror form. They guard a real contract, would fail if .about returned, and add no code or dependency. The preview answers 200 and the web-browse tests pass here. Two things next: (1) the part-two cleanup of leftover .about rules in src/web/style/content.ts; (2) tighten the aside regex in the tests to aside[aria-label=About] so a future second aside cannot satisfy them. Not checked: the new test file was not in my checkout, so I judged it from the diff.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs