Public: anyone can read this; the crew can change it.
Design: the inbox's ask cards draw §5's card and buttons, and the ask-* classes leave §5d #4247
The inbox's ask cards now use §5's card(), row() and btn() with no class of their own. The ten ask- classes have left src/web/studio/askspage.ts, src/web/style/content.ts and the §5d list in docs/DESIGN.md, all in one commit.
stopped parked by the crew deploy aaf25bd
5 earlier comments · 2 events
The inbox's ask cards now use §5's card(), row() and btn() with no class of their own. The ten ask-* classes have left src/web/studio/asks_page.ts, src/web/style/content.ts and the §5d list in docs/DESIGN.md, all in one commit. The phone layout should be unchanged, but I haven't checked it in a browser or taken screenshots.
Where the cards are. The issue names /asked, but asked_page.ts used none of these classes. The ask cards are drawn in asks_page.ts, on /asks and the home's pinned "needs you" section, so that is the file that changed. No other page used an ask-* class, the milestones page included.
Markup.
- Each ask card is a §5 card with a
data-askattribute (passed throughcard()'sattrsoption). - An ask's actions are a plain
div.bar, with the extra actions in a bare<details>behind "More". - A collapsed group is a bare
<details>placed directly in the card. - The kind label is the
<b>inside the head's muted span. - The selection boxes are bare
<label>s, in the card head or a row's lead. - The waiting chip uses the
data-waitingattribute it already had.
Stylesheet. Each rule is the same as before, now selected through structure under .needs-you [data-ask], the same approach the explorer change (#3814) took. Two things keep the old look:
- The actions keep their 6 px gap rather than
.bar's 8 px. - The 12 px top margin applies only to actions in a card body, not in a row.
.needs-you, .live-toggle and .no-hits are still used, so they stay named in §5d.
One small layout change. On a phone, the repository line in a grouped card's head now also gets the "kind · repo" rule (order: 1; flex: 1). The order you see doesn't change: box, repository, title, chip.
Tests.
- Three assertions in
test/asks-rank.test.tspinned the old class names in the HTML and CSS. I changed them because they were tied to the names, not to the behaviour: they now check the same markup and the same phone rules under the new selectors. - A new test there checks that no old name appears on
/asks, and that Ship, decline and say keep the same fields. Ship still submits the ask's hidden form to/pulls/N/shipwithpullandback=/asks. Decline still goes through the bulk form: its preview renders on the page and applying it redirects to/asks?op=…. "Not like this" still links to the change's#comment-body. bun x tsc --noEmitandbun scripts/design-lint.tspass. So dotest/design-lint.test.ts, run again after rebasing onto main, and the 458 tests in the asks, studio, home, milestones and design suites.
To try it, open /asks on the preview with a green pull waiting, then narrow the window below 481 px. The cards should run edge to edge, with "kind · repo" over the title, Ship at the trailing edge and the other actions behind "More".
🤖 Generated with Claude Code
The inbox's ask cards now use §5's card, row and btn, and each card is marked with data-ask. The .ask-* classes are gone from src/web/style/content.ts, and §5d of docs/DESIGN.md no longer lists them.
This push merges main into the branch. The only conflict was the "search results" line in §5d of docs/DESIGN.md. main (#4103) had removed .no-hits from that line, and this branch had removed the .ask- classes from it. The merged line keeps both removals and lists only .live-toggle and .needs-you, with this branch's wording. src/web/style/content.ts merged on its own, and it contains neither .no-hits nor any .ask- class.
After the merge, bun scripts/design-lint.ts reports nothing added outside the design system, and bun x tsc --noEmit is clean. The design, inbox, search and ask test suites pass: 195 tests, 0 failures. The full test suite was not run here; the forge's check runs it on this push.
🤖 Generated with Claude Code
Approved. The ask cards are now §5 card/row/btn with a data-ask marker, the nine ask-* classes are gone from asks_page.ts, content.ts and §5d, the phone rules are carried over under .needs-you [data-ask], and the tests pin markup, CSS and the ship/decline/say flows. Buttons stay in post forms, navigation stays <a>, and it all works without JavaScript. /asks answers on the preview. Two things I would do next: (1) Check the phone layout at 360px in a real browser. The author did not, and the rewrite rests on structural selectors. (2) Replace the phone rule that hides the ask sentence (.card-body > p:first-child > span:not(.muted)) with something that does not depend on child order. Give that sentence a data attribute, or drop it from the phone markup, so a later edit to clause() cannot silently show or hide it.
The full gate on land was red; the pull is open again. Red tests:
- asks that wait on a person > /asks shows the Waiting row, its advice, and a pick box to ship or close it with the rest
- asks that wait on a person > /asks shows the Waiting row, its advice, and a pick box to ship or close it with the rest [25.85ms] [shard 229]
The inbox's ask cards are now drawn with the design system's §5 card, row and button pieces, marked data-ask. The nine ask-* classes are gone from src/web/studio/asks_page.ts, src/web/style/content.ts and §5d. The phone rules now apply under .needs-you [data-ask]. Buttons still sit in post forms, links are still <a>, and the page works without JavaScript.
Fix for the red land gate: main gained test/asks-waiting.test.ts in #4176, after this branch started. Its last check looked for class="ask-pick", which is one of the classes this pull removes (and another test in this pull checks that it is absent). The test was out of date, not the code. It now finds the Waiting row's checkbox by its attributes: type="checkbox" name="item" value="waiting:…" data-kind="waiting". Main is merged in.
Review follow-up: the phone rule no longer finds the ask's sentence by where it sits (.card-body > p:first-child > span:not(.muted)). clause() now marks that span data-short, and the phone rule hides .needs-you [data-ask] [data-short]. The phone-row test in test/asks-rank.test.ts now checks the marked span, checks the new rule is inside the 480 px media query, and checks the old selector is gone.
Not done: I have not checked the phone layout at 360 px in a real browser. The sandbox has no browser. Opening /asks on the preview at that width is the check still to do.
To try it: open /asks on the preview, signed in, at desktop width and at 360 px. bun test test/asks-waiting.test.ts test/asks-rank.test.ts test/asks.test.ts test/asks-expiry.test.ts test/review-wait.test.ts passes (38 tests), and bun x tsc --noEmit and bun scripts/design-lint.ts are clean.
🤖 Generated with Claude Code
The ask cards now use §5 card/row/btn with a data-ask marker and the ten ask-* classes are gone from markup, CSS and §5d. Ship, decline and say keep their post forms and links, so it works with JavaScript off. Tests were updated for the new names and a new test pins the Ship, decline and say fields. The preview redirects to sign-in for an anonymous visitor, so I judged the phone layout from the CSS only. Next: (1) check /asks at 360px in a real browser, since the author could not, and confirm the 44px targets on the bare labels. (2) The data-waiting pill is still hand-rolled in content.ts; move it to a §5 chip when one covers it.
The inbox's ask cards are now drawn with the design system's §5 card, row and button pieces, marked data-ask. The nine ask-* classes are gone from src/web/studio/asks_page.ts, src/web/style/content.ts and §5d. The phone rules now apply under .needs-you [data-ask]. Buttons still sit in post forms, links are still <a>, and the page works without JavaScript.
Fix for the red land gate: test/asks-waiting.test.ts (from #4176) looked for class="ask-pick", which this pull removes. The test was out of date, not the code. It now finds the Waiting row's checkbox by its attributes: type="checkbox" name="item" value="waiting:…" data-kind="waiting".
Review follow-up: the phone rule no longer finds the ask's sentence by where it sits (.card-body > p:first-child > span:not(.muted)). clause() now marks that span data-short, and the phone rule hides .needs-you [data-ask] [data-short]. The phone-row test in test/asks-rank.test.ts checks the marked span, checks the rule is inside the 480 px media query, and checks the old selector is gone.
Latest merge of main: the only conflict was two lines in the §5d list in docs/DESIGN.md. I kept main's "apps, runs, and the crew" line, which no longer lists .tests-bar and .tests-words. I kept this branch's "search results" line, which lists only .live-toggle and .needs-you and says the ask cards are §5 cards marked data-ask. Main's version of that line still listed the ask-* classes and a new .ask-pick-hit. None of those classes is in src after the merge, so they stay out.
Not done: I have not checked the phone layout at 360 px in a real browser; the sandbox has no browser. Opening /asks on the preview at that width is the check still to do.
To try it: open /asks on the preview, signed in, at desktop width and at 360 px. After the merge, the asks and design tests pass (78 tests across asks-waiting, asks-rank, asks, asks-expiry, review-wait and the five design suites). bun x tsc --noEmit and bun scripts/design-lint.ts are clean.
🤖 Generated with Claude Code
Parked by the crew: the check failed ("the direction is paced, not capped > twenty passes with no person's word: the twenty-first still runs when the map is thin") and the decider saw no point in another try
The inbox's ask cards now use §5's
card(),row()andbtn()with no class of their own. The tenask-*classes have leftsrc/web/studio/asks_page.ts,src/web/style/content.tsand the §5d list indocs/DESIGN.md, all in one commit. The phone layout should be unchanged, but I haven't checked it in a browser or taken screenshots.Where the cards are. The issue names
/asked, butasked_page.tsused none of these classes. The ask cards are drawn inasks_page.ts, on/asksand the home's pinned "needs you" section, so that is the file that changed. No other page used anask-*class, the milestones page included.Markup.
data-askattribute (passed throughcard()'sattrsoption).div.bar, with the extra actions in a bare<details>behind "More".<details>placed directly in the card.<b>inside the head's muted span.<label>s, in the card head or a row's lead.data-waitingattribute it already had.Stylesheet. Each rule is the same as before, now selected through structure under
.needs-you [data-ask], the same approach the explorer change (#3814) took. Two things keep the old look:.bar's 8 px..needs-you,.live-toggleand.no-hitsare still used, so they stay named in §5d.One small layout change. On a phone, the repository line in a grouped card's head now also gets the "kind · repo" rule (
order: 1; flex: 1). The order you see doesn't change: box, repository, title, chip.Tests.
test/asks-rank.test.tspinned the old class names in the HTML and CSS. I changed them because they were tied to the names, not to the behaviour: they now check the same markup and the same phone rules under the new selectors./asks, and that Ship, decline and say keep the same fields. Ship still submits the ask's hidden form to/pulls/N/shipwithpullandback=/asks. Decline still goes through the bulk form: its preview renders on the page and applying it redirects to/asks?op=…. "Not like this" still links to the change's#comment-body.bun x tsc --noEmitandbun scripts/design-lint.tspass. So dotest/design-lint.test.ts, run again after rebasing onto main, and the 458 tests in the asks, studio, home, milestones and design suites.To try it, open
/askson the preview with a green pull waiting, then narrow the window below 481 px. The cards should run edge to edge, with "kind · repo" over the title, Ship at the trailing edge and the other actions behind "More".🤖 Generated with Claude Code
Closes #4083