Public: anyone can read this; the crew can change it.

The claim link and the client list draw §5's card and row, and .claim-link-box, .forges-sent leave the markup #4212

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

scout/forge:scout/4172-the-claim-link-and-the-client-list-draw → main 2 commits fork

  • Merged. scout/4172-the-claim-link-and-the-client-list-draw was merged into main as e4e86dc.

Review

Sign in to review this change.
2 files changed +11 −0
test/client-list.test.ts +3
@@ -201,6 +201,9 @@ describe("the client list", () => {
201201 expect(html).not.toContain("forges-sent");
202202 const lou = html.slice(html.indexOf('data-forge="lou"'));
203203 expect(lou).toMatch(/data-claimed="unknown"/);
204 expect(html).not.toContain("claim-link-box");
205 expect(maria).toContain('class="row"');
206 expect(maria).toContain("Send a fresh link");
204207 expect(lou).toContain("it did not answer just now");
205208 // The claim link itself is never kept, so never shown here.
206209 expect(html).not.toContain(claimUrl.split("#")[1]!);
test/new-forge.test.ts +8
@@ -250,6 +250,14 @@ describe("+ New forge", () => {
250250 expect(res.headers.get("location")).toBeNull();
251251 const html = await res.text();
252252 expect(html).toMatch(/https:\/\/kai--forge.test\/claim#[A-Za-z0-9_-]{43}/);
253 // Drawn with §5's row; the old names are gone and the words and the copy button stay.
254 expect(html).not.toContain("claim-link-box");
255 expect(html).not.toContain("forges-sent");
256 expect(html).toMatch(/<li>\s*<div class="row"/);
257 expect(html).toContain('id="claim-link"');
258 expect(html).toContain('data-copy="claim-link"');
259 expect(html).toContain("Send this link to the person it is for");
260 expect(html).toContain('href="/forges"');
253261 expect(await children()).toBe(2);
254262 // Asked again, the child exists: no second link.
255263 const again = await post(admin, [

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs