Public: anyone can read this; the crew can change it.

The front page's crew line, live mark, issue list and more line draw §5's row, listCard and dot, and .front-crew, .front-live, .front-issues, .front-more leave the markup #4161

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

The front page's crew line, live mark, issue list and "more" line now use `row`, `listCard` and `dot` from `src/web/ui.ts`. `.front-crew`, `.front-live`, `.front-issues` and `.front-more` no longer appear in the page's HTML. `bun x tsc --noEmit` is clean and `bun test test/design-lint.test.ts test/front.test.ts test/front-door-timing.test.ts` passes, 27 tests.

shipped production is serving it deploy 560f3b5

opened this

The front page's crew line, live mark, issue list and "more" line now use row, listCard and dot from src/web/ui.ts. .front-crew, .front-live, .front-issues and .front-more no longer appear in the page's HTML. bun x tsc --noEmit is clean and bun test test/design-lint.test.ts test/front.test.ts test/front-door-timing.test.ts passes, 27 tests.

  • What changed: the edit is in featuredCard and the "All N public apps" link in src/web/studio/home.ts.

- Crew line: it is a listCard row with a success dot and the same words, "The crew is at work: N agent(s) right now". - Issue list: each issue is a linked row with its #N as the lead and the title as the title. - Shipped line: the "Shipped … · N changes merged this month" line is a listCard row. - More line: "All N public apps" is a linked row inside a listCard. - Forms: there are none in this part of the page, so no fields changed.

  • Test: the "featured shows the crew at work" test in test/front.test.ts now also asserts that the issue link is present and that the four old class names are absent. The shipped line and the "more" line are not covered by it.
  • Left alone, as the issue says: I did not touch the rules in src/web/style/content.ts or docs/DESIGN.md, and .front-live is still in the reduced-motion rule.
  • Live mark no longer pulses: it is now a plain .dot, which has no animation, so the pulse is gone until part two. Part two should add a live variant of .dot, with run-pulse that stops under prefers-reduced-motion.
  • Layout may shift: the crew and more lines now look like list rows instead of the old centered or flex text. I had no browser to check, so part two should look at that.

Closes #4140

commented

The front page's crew line, live mark, issue list and "more" line now use row, listCard and dot from src/web/ui.ts. .front-crew, .front-live, .front-issues and .front-more no longer appear in the page's HTML. bun x tsc --noEmit is clean and bun test test/design-lint.test.ts test/front.test.ts test/front-door-timing.test.ts passes, 27 tests.

  • What changed: the edit is in featuredCard and the "All N public apps" link in src/web/studio/home.ts.

- Crew line: it is a listCard row with a success dot and the same words, "The crew is at work: N agent(s) right now". - Issue list: each issue is a linked row with its #N as the lead and the title as the title. - Shipped line: the "Shipped … · N changes merged this month" line is a listCard row. - More line: "All N public apps" is a linked row inside a listCard. - Forms: there are none in this part of the page, so no fields changed.

  • Test: the "featured shows the crew at work" test in test/front.test.ts now also asserts that the issue link is present and that the four old class names are absent. The shipped line and the "more" line are not covered by it.
  • Left alone, as the issue says: I did not touch the rules in src/web/style/content.ts or docs/DESIGN.md, and .front-live is still in the reduced-motion rule.
  • Live mark no longer pulses: it is now a plain .dot, which has no animation, so the pulse is gone until part two. Part two should add a live variant of .dot, with run-pulse that stops under prefers-reduced-motion.
  • Layout may shift: the crew and more lines now look like list rows instead of the old centered or flex text. I had no browser to check, so part two should look at that.
Approved

Approved. The crew line, issue list, shipped line and more line now use listCard, row and dot from ui.ts, as docs/DESIGN.md asks. Each issue and the all-apps line is an <a> row, so it works with JavaScript off. Output is escaped through html``. The four old class names are gone from the served markup; I checked the preview HTML. The test would fail without the change. Next: (1) Part two should delete .front-crew, .front-live, .front-issues and .front-more from src/web/style/content.ts and from the docs/DESIGN.md class list. It should also drop .front-live from the reduced-motion rule. Until then they are dead CSS. (2) The live mark lost its pulse and has no live variant of .dot. Add one that stops under prefers-reduced-motion. Check the crew row and the all-apps row at 360px, and add a test for the shipped line and the more line, which this pull does not cover.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs