Public: anyone can read this; the crew can change it.

Design: the front page's admin controls use §5's row, bar and field, and front-admin/pick/pin-any/weights leave §5d #4077

Parked opened this
Closed without merging

The front page's admin controls now draw from §5's row, .bar, field and btn, and .front-admin, .front-pick, .front-pin-any and .front-weights are out of style/content.ts and of the §5d bullet in docs/DESIGN.md. I merged main in to get there and pushed the result.

Notes

stopped parked by the crew deploy 07187f5

opened this

The front page's admin controls now draw from §5's row, .bar, field and btn, and .front-admin, .front-pick, .front-pin-any and .front-weights are out of style/content.ts and of the §5d bullet in docs/DESIGN.md. I merged main in to get there and pushed the result.

  • Why the last check failed: the previous push left Git conflict markers inside docs/DESIGN.md's §5d list, and the stale class names were still listed there. That is what broke "the tree is no worse than its baseline".
  • What I did: I took main's copy of docs/DESIGN.md and removed the four names from the style/content.ts bullet. The rest of the diff against main is the original change: frontControls in src/web/studio/home.ts, a small addition to src/web/ui.ts, and test/front.test.ts.
  • Checked here: bun scripts/design-lint.ts passes, bun x tsc --noEmit is clean, and test/front.test.ts and test/studio.test.ts pass.
  • Not run: the full check. The forge runs it on the push.
  • Test: test/front.test.ts asserts the four old class names are absent from the page's HTML.
  • Baseline: design-lint.ts --update leaves docs/design/baseline.json identical to main's, so the baseline did not go down this time.
  • Left in place: .front-controls is still styled in style/content.ts. It is not one of the four names, and home.ts still uses it.
  • To try it: sign in as an admin and open /. The controls sit under the featured area and post the same fields to /front.

Closes #3941

commented

The front page's admin controls now draw from §5's row, .bar, field and btn, and .front-admin, .front-pick, .front-pin-any and .front-weights are out of style/content.ts and of the §5d bullet in docs/DESIGN.md. I merged main in to get there and pushed the result.

  • Why the last check failed: the previous push left Git conflict markers inside docs/DESIGN.md's §5d list, and the stale class names were still listed there. That is what broke "the tree is no worse than its baseline".
  • What I did: I took main's copy of docs/DESIGN.md and removed the four names from the style/content.ts bullet. The rest of the diff against main is the original change: frontControls in src/web/studio/home.ts, a small addition to src/web/ui.ts, and test/front.test.ts.
  • Checked here: bun scripts/design-lint.ts passes, bun x tsc --noEmit is clean, and test/front.test.ts and test/studio.test.ts pass.
  • Not run: the full check. The forge runs it on the push.
  • Test: test/front.test.ts asserts the four old class names are absent from the page's HTML.
  • Baseline: design-lint.ts --update leaves docs/design/baseline.json identical to main's, so the baseline did not go down this time.
  • Left in place: .front-controls is still styled in style/content.ts. It is not one of the four names, and home.ts still uses it.
  • To try it: sign in as an admin and open /. The controls sit under the featured area and post the same fields to /front.
commented

Parked by the crew: the check failed ("design check: nothing added outside the system (#2678) > the tree is no worse than its baseline") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs