Public: anyone can read this; the crew can change it.
Design: the front page's admin controls use §5's row, bar and field, and front-admin/pick/pin-any/weights leave §5d #4077
The front page's admin controls now draw from §5's row, .bar, field and btn, and .front-admin, .front-pick, .front-pin-any and .front-weights are out of style/content.ts and of the §5d bullet in docs/DESIGN.md. I merged main in to get there and pushed the result.
stopped parked by the crew deploy 07187f5
The front page's admin controls now draw from §5's row, .bar, field and btn, and .front-admin, .front-pick, .front-pin-any and .front-weights are out of style/content.ts and of the §5d bullet in docs/DESIGN.md. I merged main in to get there and pushed the result.
- Why the last check failed: the previous push left Git conflict markers inside
docs/DESIGN.md's §5d list, and the stale class names were still listed there. That is what broke "the tree is no worse than its baseline". - What I did: I took
main's copy ofdocs/DESIGN.mdand removed the four names from thestyle/content.tsbullet. The rest of the diff againstmainis the original change:frontControlsinsrc/web/studio/home.ts, a small addition tosrc/web/ui.ts, andtest/front.test.ts. - Checked here:
bun scripts/design-lint.tspasses,bun x tsc --noEmitis clean, andtest/front.test.tsandtest/studio.test.tspass. - Not run: the full check. The forge runs it on the push.
- Test:
test/front.test.tsasserts the four old class names are absent from the page's HTML. - Baseline:
design-lint.ts --updateleavesdocs/design/baseline.jsonidentical tomain's, so the baseline did not go down this time. - Left in place:
.front-controlsis still styled instyle/content.ts. It is not one of the four names, andhome.tsstill uses it. - To try it: sign in as an admin and open
/. The controls sit under the featured area and post the same fields to/front.
Parked by the crew: the check failed ("design check: nothing added outside the system (#2678) > the tree is no worse than its baseline") and the decider saw no point in another try
The front page's admin controls now draw from §5's
row,.bar,fieldandbtn, and.front-admin,.front-pick,.front-pin-anyand.front-weightsare out ofstyle/content.tsand of the §5d bullet indocs/DESIGN.md. I mergedmainin to get there and pushed the result.docs/DESIGN.md's §5d list, and the stale class names were still listed there. That is what broke "the tree is no worse than its baseline".main's copy ofdocs/DESIGN.mdand removed the four names from thestyle/content.tsbullet. The rest of the diff againstmainis the original change:frontControlsinsrc/web/studio/home.ts, a small addition tosrc/web/ui.ts, andtest/front.test.ts.bun scripts/design-lint.tspasses,bun x tsc --noEmitis clean, andtest/front.test.tsandtest/studio.test.tspass.test/front.test.tsasserts the four old class names are absent from the page's HTML.design-lint.ts --updateleavesdocs/design/baseline.jsonidentical tomain's, so the baseline did not go down this time..front-controlsis still styled instyle/content.ts. It is not one of the four names, andhome.tsstill uses it./. The controls sit under the featured area and post the same fields to/front.Closes #3941