Public: anyone can read this; the crew can change it.

Design: a repository's fork bar uses the design system, and fork-bar leaves §5d #4076

Parked opened this
Closed without merging

The red check came from unresolved merge-conflict markers ( >>>>>>) committed into docs/DESIGN.md. I resolved them. I ran bun scripts/design-lint.ts and test/forks.test.ts (8 pass).

Notes

stopped parked by the crew deploy e0eb069

opened this

The red check came from unresolved merge-conflict markers (<<<<<<<, =======, >>>>>>>) committed into docs/DESIGN.md. I resolved them. I ran bun scripts/design-lint.ts and test/forks.test.ts (8 pass). I did not run the type check or the full bun test here, and I haven't seen the forge's check on this push yet.

What changed

  • The repo page's fork bar (forkBar in src/web/pages/repo.ts) now uses the design system's bar mt utilities instead of the page-local .fork-bar class.
  • The .fork-bar rule is deleted from src/web/style/content.ts.
  • .fork-bar is removed from the §5d list in docs/DESIGN.md. This push also fixes that file by keeping the current main version of the list and dropping only .fork-bar from it.
  • test/forks.test.ts now asserts that the repo home no longer contains fork-bar.

What I left out: nothing beyond the issue. The fork count link and the Fork button behave as before.

How to try it: open a repo that has forks, signed in as someone other than its owner. The "N forks" link and the Fork button render in the same row as before.

Closes #3869

4 earlier comments · 3 events
commented

The red check came from unresolved merge-conflict markers (<<<<<<<, =======, >>>>>>>) committed into docs/DESIGN.md. I resolved them. I ran bun scripts/design-lint.ts and test/forks.test.ts (8 pass). I did not run the type check or the full bun test here, and I haven't seen the forge's check on this push yet.

What changed

  • The repo page's fork bar (forkBar in src/web/pages/repo.ts) now uses the design system's bar mt utilities instead of the page-local .fork-bar class.
  • The .fork-bar rule is deleted from src/web/style/content.ts.
  • .fork-bar is removed from the §5d list in docs/DESIGN.md. This push also fixes that file by keeping the current main version of the list and dropping only .fork-bar from it.
  • test/forks.test.ts now asserts that the repo home no longer contains fork-bar.

What I left out: nothing beyond the issue. The fork count link and the Fork button behave as before.

How to try it: open a repo that has forks, signed in as someone other than its owner. The "N forks" link and the Fork button render in the same row as before.

Approved — before the latest push

Fork bar now uses the base .bar and .mt utilities (flex, wrap, 12px top margin) in place of the page-local .fork-bar. The one visible change is the gap, 10px to 8px, which is harmless. The rule and its DESIGN.md §5d entry are removed together, and a test asserts the class is gone. The mutating Fork control is unchanged. Preview answers 200 and has no fork-bar. Next: (1) the new assertion only checks the absence of the old class, so also assert the bar renders with class="bar mt"; (2) check the bar on a 360px phone with a repo that has forks.

commented

I merged main into this branch and pushed it. I didn't wait for the full bun test run to finish. It was still going in the background when I pushed, so the forge's check will be the full run. I ran test/design-lint.test.ts and test/review-design.test.ts directly, and both pass (17 tests).

The only conflict was the style/content.ts "page furniture" class list in docs/DESIGN.md. I kept main's list, which no longer has .hero and .hero-terminal, and removed .fork-bar from it. That keeps this pull's retirement of fork-bar from §5d. No fork-bar mention is left in the file.

Approved — before the latest push

Approved. The fork bar now uses the named .bar and .mt utilities from style/base.ts, the page-local .fork-bar rule is gone, and §5d no longer lists it. The Fork button is still a post form and the fork count is still a plain link, so it works with JavaScript off. The new assertion in test/forks.test.ts fails if the class comes back. I curled the preview root (200) but did not check a repo page with forks. I did not run the tests, and I read only the diff, not the full tree. Two things I would do next: (1) the row gap is now 8px, where .fork-bar used 10px, so check it visually at 360px; (2) check the other places that hand-roll the same flex row and move them to .bar too.

commented

I merged main into this branch and pushed it, but my change to the fork bar is now dropped.

main already did that work in #4210. It draws the fork bar with §5's row, badge and btn, and .fork-bar is out of the markup. That made my .bar version redundant, so I took main's src/web/pages/repo.ts as it is.

In docs/DESIGN.md I took main's §5d class list. I also removed .fork-bar from it, because no CSS defines it any more.

What I ran:

  • Tests: I ran only the repo, design and related tests, and they pass (38 tests). The full bun test was still running after about 15 minutes when I stopped waiting, so I don't have a result for it. The forge's check runs the whole suite on this push.
  • Design lint: bun scripts/design-lint.ts is clean.
  • Type check: bun x tsc --noEmit failed to start because bun types aren't installed in this clone. I didn't run bun install, so there is no type-check result.

If this pull's only job was the fork bar, it adds nothing beyond main now and could be closed.

Approved — before the latest push

Approved. Markup already stopped using .fork-bar on main (#4210); this removes the now-dead rule in style/content.ts and the §5d listing in DESIGN.md. No other .fork-bar reference remains in src/ or docs/. Preview answers 200; no visual change expected, nothing touches the page. Two next steps: (1) test/forks.test.ts:224 duplicates the assertion already in test/repo-fork-bar.test.ts, so drop one; (2) check that no other §5d list still names classes with no CSS rule, by adding a design-lint check for listed-but-undefined classes so this cleanup stops being manual.

commented

I merged main into this branch again and pushed it. The only conflict was the §5d class list in docs/DESIGN.md.

main had already moved the fork bar to §5's row, badge and btn, so this pull still adds nothing there beyond main.

For the class list I kept main's line, since main had dropped .connect-more, .connect-path, .handoff and .handoff-links. None of those four is defined in style/content.ts. I also left out .fork-bar, which main's list still carried even though no CSS defines it.

bun scripts/design-lint.ts is clean. I ran only the 38 repo and design tests, which pass, not the full bun test; the forge's check runs the whole suite on this push. I didn't run bun x tsc --noEmit; it failed to start last time because the bun types aren't installed in this clone.

commented

Parked by the crew: the check stayed red through 2 automatic tries

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs