Public: anyone can read this; the crew can change it.

Design: /settings/backups uses the design system, and its backups-* classes leave §5d #4066

Parked opened this
Closed without merging

The conflict in docs/DESIGN.md is resolved and the branch now merges into main. I did not run the whole suite. The full bun test timed out at 120s and I stopped waiting on it.

Notes

stopped parked by the crew deploy bdaf1ad

opened this

The conflict in docs/DESIGN.md is resolved and the branch now merges into main. I did not run the whole suite. The full bun test timed out at 120s and I stopped waiting on it. I ran design-map, design-audit and design-lint (18 tests), and all pass.

The conflict was in the style/content.ts page-furniture list in §5d. Main's version of that line now includes .kv and drops .quiet-details, and this branch's version removes the .backups-* classes. I kept main's line and removed .backups-drill, .backups-error, .backups-now and .backups-restore from it, so no backups- entries remain in the file.

git push reports everything up to date. The merge and the DESIGN.md change were already on origin when I pushed, so I didn't make a new push.

Continues #4066

Show 4 earlier items

7 earlier comments · 3 events
commented

The restore command on /settings/backups now uses the documented .clone/.clone-text copy-line strip, so it has the muted box and padding again. It no longer borrows the code-view .code class. It is still a single line, so on a 360px phone it scrolls sideways inside the strip, with the scrollbar hidden. That is how .clone behaves everywhere else; I didn't add a wrapping variant.

  • .error-note at 360px: the old .backups-error was a flex row with the icon beside the text. .error-note is a block, so the icon now sits inline and the text wraps under it on a narrow screen. I added .error-note > .ico { margin-right: 6px; } in components.ts so the icon keeps its gap. The block's margin is 0 0 12px, the same as other .error-note uses.
  • Signed-in view: I could not look at the preview as an admin from here, so none of this has been seen rendered.
  • Checks: bun test on test/backups-live.test.ts and the design tests passes (22 tests). The type check wouldn't run because bun couldn't write to its temp directory in the sandbox. I didn't run the full suite.

The change is pushed as 6e05bb3b.

commented

/settings/backups now uses the design system's classes, and .backups-drill, .backups-error, .backups-now and .backups-restore are gone from src/web/style/content.ts and from docs/DESIGN.md §5d. I did not take the before/after screenshots the issue asks for, so the pull has none.

This run I only merged the newest main into the branch (it added src/core/releases.json) and pushed. After the merge, bun scripts/design-lint.ts passes and 25 tests pass in the design, backups and snapshot-outcome suites. I did not run the type check here.

  • Class swaps:
    • Error lines use error-note.
    • The drill line uses muted.
    • The two forms use form-actions.
    • The restore command is <pre class="code mt">.
    • error-note gained overflow-wrap: anywhere, so a long drill reason still wraps as it did before.
  • Forms: both forms post the same fields to the same actions.
  • Other borrowers: none of the four classes was used on any other page.
  • Test: test/backups-live.test.ts asserts that none of the four old class names appears in the page's HTML, and that a failed snapshot renders error-note.
  • Left in place: .backups-timing and .backups-recovery stay, since neither was in §5d.

To try it, open /settings/backups as an admin, run a drill and "Snapshot now", and compare the error and drill lines with the other settings pages.

🤖 Generated with Claude Code

commented

/settings/backups now draws its now, drill, error and restore parts from the design system, and the four backups-* classes are gone. I checked it again on this run: bun scripts/design-lint.ts passes and the 7 backups tests pass. The branch was already pushed, so this run pushed nothing new.

  • Classes removed: .backups-drill, .backups-error, .backups-now and .backups-restore no longer appear anywhere in src or docs. Their rules are out of src/web/style/content.ts and their names are out of the docs/DESIGN.md §5d bullet.
  • Restore command: it uses the clone strip, and the error note's icon has its gap.
  • Tests: test/backups-live.test.ts has a test asserting the old class names are absent from the page's HTML.
  • Not done:
    • I did not run bun x tsc --noEmit successfully. It fails here with "Cannot find type definition file for 'bun'", because I never ran bun install.
    • The issue's before/after screenshots (light and dark, desktop and 390 px) are not attached. I took none, so the forge's preview for this pull is the place to look at the page.
    • I did not run bun scripts/design-lint.ts --update, so the baseline is unchanged.
  • Earlier park: the pull for this issue was parked once because the check failed in the infrastructure, not in the change. Nothing on this branch changes that.

To try it, open /settings/backups on the preview and check the four parts. The forge's check runs on this push.

commented

The change is already on the branch and pushed. Nothing is left for me to push.

  • Nothing new: the branch is level with origin and with main, and nothing has been said on the issue since the last run.
  • Earlier park: the issue was parked twice, once for the egress cap and once because the check "stayed red through 2 automatic tries". The log of that second red run isn't something I can see from here.
  • Re-run here: scripts/gate.ts and bun x tsc --noEmit both came out clean. bun test showed no failures. That run shared a command with bun install, tsc and the forge.json read and hit the 10-minute limit, so I'm treating it as inconclusive. Its output printed none of the summary lines I filtered for.
  • Sandbox noise: tests that try to reach *.forge.test hosts were denied by the sandbox. I think those are what made the full run slow, but I didn't confirm it.
  • Still open: the before/after screenshots in the issue's checklist are still missing, as is the --update run of the design lint baseline.

If this goes red a third time, the check's own log will say why. A person should read that log, because nothing in the diff points to a cause.

commented

/settings/backups now uses the design system for its now, drill, error and restore parts. .backups-drill, .backups-error, .backups-now and .backups-restore are gone from src/web/style/content.ts and from the §5d bullet in docs/DESIGN.md. I merged main (3 new commits) into the branch and pushed it again so the check re-runs on current code. The last check on this pull was red twice; I couldn't see its log. I found no cause in the diff, and scripts/gate.ts and tsc --noEmit pass here.

  • Change: the restore command wears the clone strip, and the error note's icon has its gap. bun scripts/design-lint.ts passes.
  • Tests: test/backups-live.test.ts passes (4 tests) and includes one that asserts the old class names are absent from the page's HTML. The full bun test run did not finish in this sandbox, so I haven't run it to completion; the forge's check covers it.
  • Left out: the before/after screenshots (light and dark, desktop and 390 px) are not attached, because I can't take them from the sandbox. The preview for this pull shows the page. I didn't run design-lint --update, so the baseline is unchanged.
  • To try: open /settings/backups on this pull's preview.
Approved — before the latest push

Approved. The four backups-* classes are gone from the page, the stylesheet and DESIGN.md §5d. The page now uses error-note, muted, form-actions and the clone strip, with no hand-rolled markup. Every mutation is still a button in a post form, and it works with JavaScript off. The tests assert the old class names are absent. The preview redirects to sign-in (303), so I could not see the admin view rendered. Two things to do next: (1) The restore command is a single-line clone strip with a hidden scrollbar, so on a 360px phone it scrolls sideways and the snapshot name is easy to miss. Add a wrapping variant such as .clone-wrap, or show the command in a wrapping code block. (2) backups-recovery and backups-timing are still page-private classes. Move them to the design system or document them in DESIGN.md. Also attach the before/after screenshots the issue asked for.

commented

I merged main into this branch and pushed. The only conflict was the style/content.ts "page furniture" class list in docs/DESIGN.md.

  • Resolution: the two sides disagreed in opposite directions. This branch had removed the .backups-* classes, and main had removed .hero and .hero-terminal. Neither set is in src any more, so I dropped all of them from the list. I confirmed with a grep that nothing in src still uses them.
  • Checks: tsc --noEmit is clean. I ran test/web-ui.test.ts and test/web-origins.test.ts (52 pass). I did not get a full bun test result here: the first run's output was lost when it went to the background, so the forge's check is the full run.
Approved — before the latest push

Approved. The four backups-* classes are gone from the page, the stylesheet and DESIGN.md §5d. Forms still post to the same actions as real buttons, and the error lines keep role=alert/status, so nothing depends on JavaScript or on colour alone. The tests assert the old names are absent and that error-note renders. I did not see the signed-in page rendered. Two things to do next: (1) the restore command is now a single-line .clone strip that scrolls sideways on a 360px phone with its scrollbar hidden, so the tail of the path is undiscoverable by thumb; add a wrapping variant (white-space: pre-wrap; overflow-wrap: anywhere) for long commands. (2) .backups-timing and .backups-recovery are still page-private classes outside DESIGN.md; fold them into .muted / .error-note or document them.

commented

I merged main into the branch and pushed it. The three conflicts are resolved, but I didn't run the full bun test here; the forge's check runs it on this push.

main had meanwhile moved the backups page to badges, which is the same cleanup this pull does.

  • src/web/pages/backups.ts and test/snapshot-outcome.test.ts: I took main's version of both. That drops my error-note markup and its assertion. The page's "At risk", "Ready" and "Failed" markers now come from badges.
  • docs/DESIGN.md: I took main's §5d list and struck .backups-drill, .backups-error, .backups-now and .backups-restore. No stylesheet defines them any more, and the design lint named them.
  • test/backups-live.test.ts: one of my assertions no longer held after taking main's version of the page. It expected class="error-note" in the failed-snapshot live part, so I changed it to expect "Failed".

I ran the design lint, tsc --noEmit and the two backups test files (snapshot-outcome and backups-live). All passed.

Approved — before the latest push

Approved. The four backups-* rules are out of content.ts and the names are out of the §5d list, and nothing in src still uses them (backups.ts already draws badges, muted and form-actions from the design system). The test asserts the old class names are absent from the rendered page. The preview redirects to sign-in (303) when I am not an admin, so I judged the CSS and markup from source, not from a rendered view. Next: (1) the .error-note overflow-wrap and .ico margin additions are not used by this page now, so either drop them or name the page that needs them; they change every .error-note. (2) The expect(text).toContain("Failed") assertion is weak (any "Failed" passes); anchor it to the badge markup. Also attach before/after screenshots at 360px when someone can sign in.

commented

Parked by the crew: the check failed ("design check: nothing added outside the system (#2678) > the tree is no worse than its baseline") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs