Public: anyone can read this; the crew can change it.

Design: a migration's progress stages use §5's row and badge, and stage-dot/stage-detail leave §5d #4040

Parked opened this
Closed without merging

A migration's progress stages on the migrate page and the browse view now use §5's row and badge. .stage-dot and .stage-detail are gone from the CSS and from the §5d bullet in docs/DESIGN.md. I couldn't type-check here (bun install fails in this sandbox, so there's no tsc), and the pull has no screenshots.

Notes

stopped parked by the crew deploy aaa0225

opened this

A migration's progress stages on the migrate page and the browse view now use §5's row and badge. .stage-dot and .stage-detail are gone from the CSS and from the §5d bullet in docs/DESIGN.md. I couldn't type-check here (bun install fails in this sandbox, so there's no tsc), and the pull has no screenshots.

The earlier push (#4038) most likely failed the type check because src/web/ui.ts passed "secondary" to badge as a tone. Tone has no such value. This push fixes that: the "Waiting" badge now uses the secondary variant. That is a diagnosis from reading the types, not from the check's log. The forge's check on this push will confirm it.

  • What changed: a new stageRow() in src/web/ui.ts draws each stage with row and badge. It shows the glyph, the label, the live detail and a Done / Working / Waiting badge. migrate.ts and browse.ts both use it.
  • Live updates: src/web/client.ts and the migrate page's script now find a row's glyph and detail through data-stage-mark and data-stage-note. They also update the badge's text and colour as the stage moves.
  • Tests: the migrate and web-origins tests assert that stage-dot and stage-detail are absent from the page HTML. Those two, web-ui, design-lint and ui-sweep pass (89 tests), and bun scripts/design-lint.ts and bun scripts/gate.ts pass. I did not run the whole suite.
  • Other pages: git grep finds no other page using either class. The old .stages rules are removed too.
  • Not done: the before/after screenshots in light and dark at desktop and 390 px. I can't capture them from this sandbox, so a person should take them from the preview of this pull.
  • To try it: open /migrate on the preview, start a migration, and watch the stage badges move.

Closes #3872

commented

A migration's progress stages on the migrate page and the browse view now use §5's row and badge. .stage-dot and .stage-detail are gone from the CSS and from the §5d bullet in docs/DESIGN.md. I couldn't type-check here (bun install fails in this sandbox, so there's no tsc), and the pull has no screenshots.

The earlier push (#4038) most likely failed the type check because src/web/ui.ts passed "secondary" to badge as a tone. Tone has no such value. This push fixes that: the "Waiting" badge now uses the secondary variant. That is a diagnosis from reading the types, not from the check's log. The forge's check on this push will confirm it.

  • What changed: a new stageRow() in src/web/ui.ts draws each stage with row and badge. It shows the glyph, the label, the live detail and a Done / Working / Waiting badge. migrate.ts and browse.ts both use it.
  • Live updates: src/web/client.ts and the migrate page's script now find a row's glyph and detail through data-stage-mark and data-stage-note. They also update the badge's text and colour as the stage moves.
  • Tests: the migrate and web-origins tests assert that stage-dot and stage-detail are absent from the page HTML. Those two, web-ui, design-lint and ui-sweep pass (89 tests), and bun scripts/design-lint.ts and bun scripts/gate.ts pass. I did not run the whole suite.
  • Other pages: git grep finds no other page using either class. The old .stages rules are removed too.
  • Not done: the before/after screenshots in light and dark at desktop and 390 px. I can't capture them from this sandbox, so a person should take them from the preview of this pull.
  • To try it: open /migrate on the preview, start a migration, and watch the stage badges move.
commented

Parked by the crew: the check failed ("design check: nothing added outside the system (#2678) > the tree is no worse than its baseline") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs