Public: anyone can read this; the crew can change it.

Design: a migration's progress stages use §5's row and badge, and stage-dot/stage-detail leave §5d #4038

Parked opened this
Closed without merging

The migration progress stages now use §5's row and badge, and .stage-dot and .stage-detail are gone from the CSS and from §5d. I did not take the before/after screenshots, which the issue asks for. The sandbox has no browser.

Notes

stopped parked by the crew deploy 34ac78a

opened this

The migration progress stages now use §5's row and badge, and .stage-dot and .stage-detail are gone from the CSS and from §5d. I did not take the before/after screenshots, which the issue asks for. The sandbox has no browser. I also could not run bun x tsc --noEmit: bun can't write to its temp directory here, so the type check is left to the forge's check.

  • Markup: a new stageRow() in src/web/ui.ts builds each stage on §5's row(). It has a glyph as the lead, the label as the title, and the live detail as the meta line. A badge on the right says the state in a word: Done (success), Working (attn) or Waiting (secondary).
  • Where it's used: both the migrate job page and the browse mirror-job page call stageRow(). Their lists now use class="list" instead of .stages, so those rules left src/web/style/content.ts too.
  • Live updates: src/web/client.ts and the inline script in migrate.ts now select [data-stage-mark] and [data-stage-note], and also update the badge's word and tone. An empty detail is a non-breaking space, so a row doesn't change height when the detail appears.
  • Other users: git grep found no other page using either class, so both are removed.
  • Docs and lint: I took .stage-detail and .stage-dot out of §5d. bun scripts/design-lint.ts passes, and --update left docs/design/baseline.json unchanged.
  • Tests: I added assertions that the old class names are absent and the new hooks are present, in test/migrate.test.ts (the migrate job page) and test/web-origins.test.ts (the mirror-job page). The six suites that touch these pages pass (107 tests).
  • Not done: the stage rows are now taller than the old single-line rows, and the glyph no longer changes colour by state, because the badge carries that. Nothing a person reads is lost.

To try it, start a migration at /migrate or a mirror from /settings/origins, and watch the stage list on the job page.

🤖 Generated with Claude Code

Closes #3872

commented

The migration progress stages now use §5's row and badge, and .stage-dot and .stage-detail are gone from the CSS and from §5d. I did not take the before/after screenshots, which the issue asks for. The sandbox has no browser. I also could not run bun x tsc --noEmit: bun can't write to its temp directory here, so the type check is left to the forge's check.

  • Markup: a new stageRow() in src/web/ui.ts builds each stage on §5's row(). It has a glyph as the lead, the label as the title, and the live detail as the meta line. A badge on the right says the state in a word: Done (success), Working (attn) or Waiting (secondary).
  • Where it's used: both the migrate job page and the browse mirror-job page call stageRow(). Their lists now use class="list" instead of .stages, so those rules left src/web/style/content.ts too.
  • Live updates: src/web/client.ts and the inline script in migrate.ts now select [data-stage-mark] and [data-stage-note], and also update the badge's word and tone. An empty detail is a non-breaking space, so a row doesn't change height when the detail appears.
  • Other users: git grep found no other page using either class, so both are removed.
  • Docs and lint: I took .stage-detail and .stage-dot out of §5d. bun scripts/design-lint.ts passes, and --update left docs/design/baseline.json unchanged.
  • Tests: I added assertions that the old class names are absent and the new hooks are present, in test/migrate.test.ts (the migrate job page) and test/web-origins.test.ts (the mirror-job page). The six suites that touch these pages pass (107 tests).
  • Not done: the stage rows are now taller than the old single-line rows, and the glyph no longer changes colour by state, because the badge carries that. Nothing a person reads is lost.

To try it, start a migration at /migrate or a mirror from /settings/origins, and watch the stage list on the job page.

🤖 Generated with Claude Code

commented

Parked by the crew: the check failed and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs