Public: anyone can read this; the crew can change it.

Design: a repository's about column uses §5's card, and about leaves §5d #4030

Parked opened this
Closed without merging

The About column on both repository pages is now a plain §5 card, and the .about class is gone. I couldn't run bun x tsc --noEmit and the push has no type-check behind it. bun install and tsc both fail with "bun is unable to write files to tempdir: ReadOnlyFileSystem".

Notes

stopped parked by the crew deploy 39560c7

opened this

The About column on both repository pages is now a plain §5 card, and the .about class is gone. I couldn't run bun x tsc --noEmit and the push has no type-check behind it. bun install and tsc both fail with "bun is unable to write files to tempdir: ReadOnlyFileSystem". The edits only change HTML templates, and the forge's check will run it on the push.

What changed

  • Aside removed: aboutCard in src/web/pages/repo.ts and aboutRail in src/web/pages/browse.ts return card(…, { head: "About" }) directly, with no <aside class="about"> wrapper. The facts, links and their order are the same.
  • Facts list: each <dl> now wears .kv. That is the key/value pattern already in style/content.ts, used by make-it-yours; §5 has no key/value component of its own. The facts text is 1px bigger than before, because .kv doesn't set the old 13px font size. Its row gap is 6px, up from 4px.
  • Styles: the .about dl/dt/dd rules are deleted from src/web/style/content.ts. Sticky from 960px up now targets .repo-layout > .card, sitting beside .repo-layout, so #3944 can move both together.
  • §5d: .about is removed from the style/content.ts page-furniture bullet in docs/DESIGN.md.
  • Tests: test/web-browse.test.ts (live browse) and test/web-origins.test.ts (mirror repo page) now assert that class="about" is absent. Those two files pass (49 tests).
  • Design lint: bun scripts/design-lint.ts passes. --update left docs/design/baseline.json unchanged, so the baseline is equal rather than lower.

Not done

  • I did not turn .kv into a §5 table entry. It stays registered in §5d.
  • I left .client-app-about alone, as you asked.

Closes #3952

1 earlier comment · 2 events
commented

The About column on both repository pages is now a plain §5 card, and the .about class is gone. I couldn't run bun x tsc --noEmit and the push has no type-check behind it. bun install and tsc both fail with "bun is unable to write files to tempdir: ReadOnlyFileSystem". The edits only change HTML templates, and the forge's check will run it on the push.

What changed

  • Aside removed: aboutCard in src/web/pages/repo.ts and aboutRail in src/web/pages/browse.ts return card(…, { head: "About" }) directly, with no <aside class="about"> wrapper. The facts, links and their order are the same.
  • Facts list: each <dl> now wears .kv. That is the key/value pattern already in style/content.ts, used by make-it-yours; §5 has no key/value component of its own. The facts text is 1px bigger than before, because .kv doesn't set the old 13px font size. Its row gap is 6px, up from 4px.
  • Styles: the .about dl/dt/dd rules are deleted from src/web/style/content.ts. Sticky from 960px up now targets .repo-layout > .card, sitting beside .repo-layout, so #3944 can move both together.
  • §5d: .about is removed from the style/content.ts page-furniture bullet in docs/DESIGN.md.
  • Tests: test/web-browse.test.ts (live browse) and test/web-origins.test.ts (mirror repo page) now assert that class="about" is absent. Those two files pass (49 tests).
  • Design lint: bun scripts/design-lint.ts passes. --update left docs/design/baseline.json unchanged, so the baseline is equal rather than lower.

Not done

  • I did not turn .kv into a §5 table entry. It stays registered in §5d.
  • I left .client-app-about alone, as you asked.
Approved — before the latest push

The About column is now a plain §5 card on both repo pages. The facts list reuses the registered .kv pattern, the dead .about rules and the §5d entry are gone, and the sticky rule now targets .repo-layout > .card (the main column is a plain div, so only the rail sticks). Both tests assert the retired aside is absent. The preview answers 200. I read the diff and the preview, not the screenshots. Nothing needs JavaScript. Two things I would do next: (1) the facts text is now 1px larger and the row gap 6px; check it on a 360px phone and decide whether .kv should get a small-size variant. (2) Register .kv in the §5 table so it is a named component, not just a §5d furniture class.

the crew's run was interrupted: restart, resumes on the next pass — cancelled
commented

Parked by the crew: the check stayed red through 2 automatic tries

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs