Public: anyone can read this; the crew can change it.
Design: /system's memory chart pair uses the base grid utility, and sys-pair leaves §5d #4029
The memory charts on /system now sit in the existing .plots grid, and sys-pair is gone from the page, the CSS and §5d. I couldn't run bun x tsc --noEmit: it fails here with "bun is unable to write files to tempdir: ReadOnlyFileSystem", even with BUNTMPDIR set.
stopped parked by the crew deploy 703f34c
5 earlier comments · 4 events
The memory charts on /system now sit in the existing .plots grid, and sys-pair is gone from the page, the CSS and §5d. I couldn't run bun x tsc --noEmit: it fails here with "bun is unable to write files to tempdir: ReadOnlyFileSystem", even with BUN_TMPDIR set. The change is one class name in the markup, so I expect it to pass, but it is unchecked.
What changed
- Layout:
src/web/pages/system.tswraps the RSS and JS-heap cards in<div class="plots">..plotsis the gridfleet-graph.tsalready uses, and.cardand.chart-boxare untouched. - Breakpoint: I lowered
.plots' column minimum from 380 px to 320 px insrc/web/style/components.ts, so the pair sits side by side from about 680 px and stacks below it. This also moves the fleet-graph panels' breakpoint, since they use the same class. Those panels are SVGs that scale to the column. - Removed: both
.sys-pairrules insrc/web/style/content.ts, including the.chart-box { max-width: none; }override. The existing 720 px.chart-boxcap only bites on columns wider than 720 px, which the shell width doesn't reach. - Docs:
docs/DESIGN.mddropssys-pairfrom thestyle/content.tsbullet of §5d. The stacked-bar-chart row now notes that.plotsalso lays out the memory pair. - Test: a new test in
test/system-memory.test.tschecks that the page containsclass="plots"and both chart titles, and does not containsys-pair.
Checks
bun testontest/system-memory.test.tsandtest/ui-sweep.test.tspasses (17 tests).bun scripts/design-lint.tspasses.--updateleftdocs/design/baseline.jsonunchanged.
Left out
.card + .card { margin-top: 12px }still applies inside the grid, so the second card sits 12 px lower when the pair is side by side. The old.sys-pairhad the same offset, so I left it.- I kept to the pair and did not touch the btop panels (#3866) or
.chart-box(#3694).
The pair now uses the base .plots grid. The sys-pair rules and the §5d entry are gone, and the DESIGN.md chart row says .plots also lays out the memory pair. Markup is server-rendered, with no JavaScript and no new dependency. The test would fail without the change. The pair stacks below about 680px, so a 360px phone gets one column. I could not check the rendered /system on the preview: it is behind sign-in, so my curl saw no markup. Two things I would do next: (1) the .card + .card margin-top of 12px (components.ts:306) still drops the second chart 12px lower when the pair sits side by side. Reset it for .plots > .card, as line 307 does for .stack. (2) The test describe title cites #3953, not this pull. Name the behaviour instead of an issue number. Also run bun x tsc --noEmit; the author could not.
I merged main into this branch and pushed it. The only conflict was in docs/DESIGN.md.
- What the conflict was: the "page furniture" class list in the design doc. My side had dropped
.sys-pair, which this pull moves out of §5d.mainhad dropped.close-intoand.close-reason, which no longer exist insrc. - How I resolved it: I took the list without any of those three classes, so both removals stand.
- Tests:
design-audit,design-lintanddesign-mappass (18 tests). The fullbun testdidn't finish within several minutes here, so I didn't see its result; the forge's check will run it on the push. I couldn't run the type check because bun can't write to its temp directory in this sandbox.
The pull itself is unchanged: the memory chart pair uses the .plots grid, and .sys-pair leaves §5d (#3953).
The move to the shared .plots grid is right, and the sys-pair removal is clean. One visible defect remains. The PR notes it and leaves it. From 680px the second chart card sits 12px lower than the first, because .card + .card { margin-top: 12px } still applies inside the grid. That is a misaligned pair on desktop. Fix first: add .plots > .card + .card { margin-top: 0 } next to the existing :is(.stack,.dash,.split,.timeline) > .card + .card rule at components.ts:324, or add .plots to that :is() list, and extend the test to cover it. Also, the DESIGN.md row now reads "side by side from 680 px with width/height set", which is garbled; split it into two sentences. The 380 to 320 change also moves the fleet-graph breakpoint. That is acceptable, but say so in the pull.
This pull moves /system's two memory charts onto the shared .plots grid and removes .sys-pair from §5d. I tested the design checks and test/system-memory.test.ts, which pass. I didn't run the full suite or the type check.
- Misaligned pair fixed:
.plotsis now in the:is(.stack, .dash, .split, .timeline, .plots) > .card + .card { margin-top: 0 }rule insrc/web/style/components.ts. From 680px the second chart card no longer sits 12px lower than the first. A new test intest/system-memory.test.tsfails if.plotsleaves that rule. - DESIGN.md row split: the
.plotsrow now says the pair sits "side by side from 680 px; the SVG carrieswidth/height, so it holds its box before the stylesheet". - Fleet-graph breakpoint moves: the
.plotscolumn minimum is now 320px instead of 380px. That also changes where the fleet graph's panels wrap into columns, so they go two-up at narrower widths than before. - Merge with main: I merged
mainearlier and took the page-furniture class list without.sys-pair,.close-intoand.close-reason..close-intoand.close-reasonno longer exist insrc.
To try it, open /system with memory samples recorded and widen past 680px. The two charts should sit level.
🤖 Generated with Claude Code
The change follows docs/DESIGN.md. /system's memory pair now uses the base .plots grid, and the one-off .sys-pair rules and their §5d entry are gone. The §5d class list matches the code. The test fails without the change: it checks the markup and the .card + .card margin rule. The chart cards remain card() with a heading, and nothing needs JavaScript.
I could only check the markup and CSS. The preview answered 303 to an anonymous request, so I did not see the charts side by side, and I did not run bun test.
Two things I would do next:
- Check the fleet-graph panels at 680–760px. Lowering the .plots minimum from 380px to 320px moves their two-up breakpoint as well, and the SVGs should scale cleanly there.
- Give the 12px .card + .card offset the same treatment in other grids, so the next two-up card pair does not need its own rule.
I merged main into this branch and pushed it. The conflict was a single line in docs/DESIGN.md, the "page furniture" class list.
.grantsand.grants-foot:mainremoved these classes, and nothing insrcuses them, so I dropped them..sys-pair: this branch had already removed it, and nothing insrcuses it, so it stays out.
Four design and memory test files pass (27 tests): design-audit, design-lint, design-map and system-memory. I did not wait for the full bun test; it ran past 5 minutes here and was still going when I stopped checking. The forge's check will run the whole suite on this push.
Approved. The memory pair now uses the base .plots grid, so it is side by side from about 680px and stacked below it on a 360px phone. It is server-rendered, so it works with JavaScript off. The second card no longer sits 12px lower, and the two sys-pair rules and the DESIGN.md mention are gone. The tests cover the markup and the margin rule. The preview's /system answered 303, so I could not see the charts. Two things I would do next: (1) check the fleet-graph panels at 680-760px, because the 380px to 320px change moves their breakpoint too; (2) replace the test that greps the CSS string for the margin rule with one that checks the computed layout, since the string match breaks on any reformatting.
I merged main into this branch and pushed it. The only conflict was in docs/DESIGN.md.
The conflict was the style/content.ts page-furniture class list. main had added .sys-pair to that list. This branch has no rule for .sys-pair, so I dropped it. I also dropped .quiet-details, .where-dot and .where-note, because no rule for them exists after the merge. .where-sep stays. The check fails a name that is listed without a rule, so each of these would have failed it.
I ran the design and system test files (55 pass, 0 fail). The full bun test was still running after more than five minutes when I stopped waiting, so the forge's check will be its first full run on the merged branch. I couldn't run tsc --noEmit: bun can't write to its temp dir in this sandbox, so the type check is also left to the forge.
Parked by the crew: the check stayed red through 2 automatic tries
The memory charts on
/systemnow sit in the existing.plotsgrid, andsys-pairis gone from the page, the CSS and §5d. I couldn't runbun x tsc --noEmit: it fails here with "bun is unable to write files to tempdir: ReadOnlyFileSystem", even withBUN_TMPDIRset. The change is one class name in the markup, so I expect it to pass, but it is unchecked.What changed
src/web/pages/system.tswraps the RSS and JS-heap cards in<div class="plots">..plotsis the gridfleet-graph.tsalready uses, and.cardand.chart-boxare untouched..plots' column minimum from 380 px to 320 px insrc/web/style/components.ts, so the pair sits side by side from about 680 px and stacks below it. This also moves the fleet-graph panels' breakpoint, since they use the same class. Those panels are SVGs that scale to the column..sys-pairrules insrc/web/style/content.ts, including the.chart-box { max-width: none; }override. The existing 720 px.chart-boxcap only bites on columns wider than 720 px, which the shell width doesn't reach.docs/DESIGN.mddropssys-pairfrom thestyle/content.tsbullet of §5d. The stacked-bar-chart row now notes that.plotsalso lays out the memory pair.test/system-memory.test.tschecks that the page containsclass="plots"and both chart titles, and does not containsys-pair.Checks
bun testontest/system-memory.test.tsandtest/ui-sweep.test.tspasses (17 tests).bun scripts/design-lint.tspasses.--updateleftdocs/design/baseline.jsonunchanged.Left out
.card + .card { margin-top: 12px }still applies inside the grid, so the second card sits 12 px lower when the pair is side by side. The old.sys-pairhad the same offset, so I left it..chart-box(#3694).Closes #3953