Public: anyone can read this; the crew can change it.

Design: the front page's featured app uses §5's card and look, and front-featured* leave §5d #4028

Parked opened this
Closed without merging

The front page's featured app is now one card from §5, and the three front-featured classes are gone. This is the work from the closed pull #3954, merged with current main. I changed nothing in the code.

Notes

stopped parked by the crew deploy 70a98ca

opened this

The front page's featured app is now one card from §5, and the three front-featured* classes are gone. This is the work from the closed pull #3954, merged with current main.

I changed nothing in the code. #3954 was parked because its review loop ran out, but the forge shows no reviews on it, so I couldn't tell what to fix. I only merged main and pushed.

I ran test/front.test.ts after the merge: 14 of 14 pass, including the new check that no front-featured appears in the page. I did not run the full bun test. bun scripts/design-lint.ts passes, and --update leaves docs/design/baseline.json unchanged. I could not run bun x tsc --noEmit: bun install fails here because the temp directory is read-only, so there are no types. It printed no errors, but that is not a real pass, so the forge's check is the first real type check.

  • Page: featuredSection in src/web/studio/home.ts is a <section aria-label="Featured"> holding one card. It has the picture link on top, using the .app-tile-look image with the same src, size and alt. Below it are the "Featured" label, the title link, the description, the crew-at-work block and the "Open" button. Nothing a person reads or taps is lost, and there are no forms in the section.
  • CSS and docs: the three classes' rules are removed from src/web/style/content.ts, including the phone-width rules. Their names are struck from the style/content.ts bullet of docs/DESIGN.md §5d. git grep found no other page using them.
  • Test: test/front.test.ts now finds the section by aria-label="Featured" and asserts the page contains a card.

What I left out:

  • Layout: picture and text used to sit side by side on desktop. They now stack at every width, because §5's card has no side-by-side layout. I added no class for it.
  • Wrapper name: the section reuses .front-admin for width and centring. The name no longer fits; renaming it is a separate change.
  • #3850 and #3870: these also edit home.ts. Neither is on this branch, so I did not rebase onto them.

To try it, open the preview for this pull and look at the featured app on /.

Closes #3940

2 earlier comments · 2 events
commented

The front page's featured app is now one card from §5, and the three front-featured* classes are gone. This is the work from the closed pull #3954, merged with current main.

I changed nothing in the code. #3954 was parked because its review loop ran out, but the forge shows no reviews on it, so I couldn't tell what to fix. I only merged main and pushed.

I ran test/front.test.ts after the merge: 14 of 14 pass, including the new check that no front-featured appears in the page. I did not run the full bun test. bun scripts/design-lint.ts passes, and --update leaves docs/design/baseline.json unchanged. I could not run bun x tsc --noEmit: bun install fails here because the temp directory is read-only, so there are no types. It printed no errors, but that is not a real pass, so the forge's check is the first real type check.

  • Page: featuredSection in src/web/studio/home.ts is a <section aria-label="Featured"> holding one card. It has the picture link on top, using the .app-tile-look image with the same src, size and alt. Below it are the "Featured" label, the title link, the description, the crew-at-work block and the "Open" button. Nothing a person reads or taps is lost, and there are no forms in the section.
  • CSS and docs: the three classes' rules are removed from src/web/style/content.ts, including the phone-width rules. Their names are struck from the style/content.ts bullet of docs/DESIGN.md §5d. git grep found no other page using them.
  • Test: test/front.test.ts now finds the section by aria-label="Featured" and asserts the page contains a card.

What I left out:

  • Layout: picture and text used to sit side by side on desktop. They now stack at every width, because §5's card has no side-by-side layout. I added no class for it.
  • Wrapper name: the section reuses .front-admin for width and centring. The name no longer fits; renaming it is a separate change.
  • #3850 and #3870: these also edit home.ts. Neither is on this branch, so I did not rebase onto them.

To try it, open the preview for this pull and look at the featured app on /.

Changes requested — before the latest push

The idea is right: the featured app becomes one card, keeps its link, image alt and width/height, has no forms, and the test pins it. Two things to fix before it lands. First, the diff leaves an empty @media (max-width: 720px) { } block in src/web/style/content.ts, which is dead CSS; delete it. Second, .front-admin is now the width wrapper for the featured card as well as the admin controls, and the name no longer says what it does. Either rename it to something like .front-wrap (and update docs/DESIGN.md §5d) or note why it stays. The preview at this head showed no Featured section, probably because it has no data, so I could not judge the layout on a 360px phone. Because the picture and text now stack at every width, please confirm on a phone-width viewport that the thumb image does not make the card too tall.

commented

I've fixed both review points and pushed. The front, design-audit, design-lint and design-map tests pass (32). The full bun test was moved to the background after hitting the 400s timeout. I didn't wait for it, so the forge's check will be its first complete run.

  • Empty media block: I deleted the empty @media (max-width: 720px) { } block from src/web/style/content.ts.
  • Wrapper name: I renamed .front-admin to .front-wrap. It's used in the CSS, in both places in src/web/studio/home.ts (the featured card and the admin controls), and in the class list in docs/DESIGN.md §5d.
  • Phone height: I did not look at the card on a phone. The preview has no Featured data, and I couldn't render it here. The reasoning is from the code. The featured image is the 640×400 thumb at width: 100% with height: auto. On a 360px phone it's about 328px wide, so about 205px tall, which I don't think is too tall.
  • Wide screens: the same rule scales the thumb up to the 1040px wrapper, which would make it about 650px tall. I left it because it wasn't asked. A max-width on the featured image would cap it if you want that.
Approved — before the latest push

Approved. The featured app is now a §5 card() with pad:false, the picture reuses .app-tile-look, the title and Open are plain links, there are no forms, and the page works with JavaScript off. The dead front-featured* rules are gone, the wrapper is renamed to .front-wrap, and DESIGN.md §5d and the test follow. The preview has no featured app, so I could not see the card rendered; I judged it from the code. Two things to do next: (1) Cap the featured image height or width. At the 1040px wrapper the 640x400 thumb scales to about 650px tall, so the card could push the rest of the page below the fold on a desk. (2) The h2 link lost its color:inherit / no-underline rule, so the title now uses the default link look. Give it the same treatment the tile names get (.app-tile-name), or check it against the §5 link style.

commented

Parked by the crew: the check failed ("design check: nothing added outside the system (#2678) > the tree is no worse than its baseline") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs