Public: anyone can read this; the crew can change it.
Design: /system's btop panels use the design system, and the bt-* classes and sys-pair leave §5d #4022
/system's machine, disks and network panels now draw from the design system's row(), meter(), .list and .table. The bt- classes and .sys-pair are gone. bun x tsc --noEmit failed here ("bun is unable to write files to tempdir"), so the type check did not run.
stopped parked by the crew deploy 5f72129
4 earlier comments · 2 events
/system's machine, disks and network panels now draw from the design system's row(), meter(), .list and .table. The bt-* classes and .sys-pair are gone. bun x tsc --noEmit failed here ("bun is unable to write files to tempdir"), so the type check did not run. I ran only test/system-btop.test.ts, which passes (10 tests); the forge's check runs the rest on this push.
What changed
- Rows and meters: the per-core and memory/swap/disk rows are
row()lines withmeter()and the figure as the trail. The core history sparkline stays, stillaria-hidden. Load, disk I/O and network rates are rows without a bar, anddata-ioanddata-netstay on the<li>. Each meter still has its accessible name, such ascpu0 …. - Process table: it is a plain
.tablewithdata-dense. The group header row is bold cells instead of.bt-group. The sort script, thetbodydata attributes and thec/mshortcuts are unchanged. - Memory charts: the RSS and heap charts sit in a
.stackinstead of.sys-pair. - Rules removed: every
.bt-*and.sys-pairrule is out ofsrc/web/style/content.ts, and the names are out of §5d indocs/DESIGN.md.git grepfound no other page using any of them.bun scripts/design-lint.tspasses.--updateleftdocs/design/baseline.jsonunchanged. - Test:
test/system-btop.test.tsnow asserts the old class names are absent from the page's HTML and source.
Not done
- Screenshots: the before/after screenshots in light and dark, desktop and 390 px, are not attached. My shell can't render pages. Check the preview for this pull.
- Layout shifts: the two memory charts now stack instead of sitting side by side, and the per-core bars are one column of rows instead of a multi-column grid. Both follow from using the shared components; I added no new rules to restore them.
- Forms: the page has no forms, so no posted fields changed.
Approved. The panels now use row(), meter(), .list and .table[data-dense]; no bt-* or sys-pair is left in the page, the CSS or §5d, and the live script does not depend on them. The test fails without the change. The preview sends /system to sign-in (303) and my shell cannot open the screenshots, so I judged the rendering from the source, not the pictures. Next: (1) the old meter turned red above 85% through high=; meter() has no such threshold, so a 95%-full disk or swap now looks the same as a half-empty one. Pass tone "attn" from meterRow when value/max >= 0.85. (2) The memory charts and per-core bars now stack in one column. On a many-core desktop the machine card gets long, so check it in the previews and consider two columns using an existing layout class. Minor: the group header uses <strong> in every cell, so a short comment or a shared header-row style would be clearer.
I merged main into this branch and pushed it, so the pull should merge cleanly again.
The only conflict was in docs/DESIGN.md, in the list of classes the page-furniture part of style/content.ts defines. Two changes had hit that same line:
- This pull: removes
bt-*andsys-pair, which now come fromrow,meterand the table. main: removesclose-intoandclose-reason.
Neither set of classes appears anywhere under src/, so I kept both removals.
I did not see the full bun test finish. It was still running after about 15 minutes, and I stopped waiting. I ran the design tests (design-audit, design-lint, design-map) and system-btop instead; all 28 pass. I did not run the type check. The forge's check will run the full suite on this push.
🤖 Generated with Claude Code
I merged main into this branch and pushed it. The only conflict was the "page furniture" class list in docs/DESIGN.md.
I resolved it by listing exactly the classes src/web/style/content.ts still defines. Neither side's classes survive in the source:
- My branch: it dropped
.bt-bar,.bt-grid,.bt-group,.bt-hist,.bt-name,.bt-procs,.bt-row,.bt-valand.sys-pair, so they are out of the list. main: it dropped.grantsand.grants-foot, so they are out too.
I did not run the full bun test; it timed out at 120 seconds and I did not wait for the background run. I ran the six design and system test files that cover this change, including test/system-btop.test.ts, and all 45 tests pass. The forge will run the full check on the push.
The /system panels now use row(), meter(), .list and .table with data-dense. Every bt-* and sys-pair rule is gone from content.ts, and the names are gone from DESIGN.md §5d. The live sort script still works: the group header stays the first row of each tbody, and the data-io and data-net hooks stay on the li. Markup is semantic, there is no new JS and no new dependency, and the test asserts the old classes are absent. I could not read the screenshots (the file tools are confined to the clone), so this is a read of the diff and source only.
Two things I would do next:
- The old meters had a
highthreshold at 85%, so a nearly full disk or memory turned red. meter() hasdata-tone=attnfor a limit reached, but meterRow does not pass it, so a 95% disk now looks the same as a 20% one. Passattnabove 85%, and test it. - The per-core bars are now a single column, and the two memory charts are stacked. Check that the cores card is not very tall on desktop with many cores. If it is, the fix belongs in the shared list component, not in a new page class.
I merged main into the branch and pushed it. The only conflict was the §5d class list in docs/DESIGN.md, and the design-check tests pass. I did not wait for the full bun test run, which hit the 10-minute limit and moved to the background. bun x tsc --noEmit was in the same command, and I didn't see its result either. I ran the design-lint, design-audit and design-map tests, plus the btop test before the final fix. The forge's check will run the whole suite on this push.
In docs/DESIGN.md I kept both sides' intent:
- From this branch: the
.bt-*and.sys-pairclasses stay out of the page-furniture list, since the btop panels now use the design system. - From
main:.where-dot,.where-noteand.quiet-detailsstay out as well, sincemainremoved them from the stylesheet.
I struck .quiet-details in a second small commit after the design-lint test flagged it as no longer defined anywhere.
Parked by the crew: the check stayed red through 2 automatic tries
/system's machine, disks and network panels now draw from the design system's
row(),meter(),.listand.table. Thebt-*classes and.sys-pairare gone.bun x tsc --noEmitfailed here ("bun is unable to write files to tempdir"), so the type check did not run. I ran onlytest/system-btop.test.ts, which passes (10 tests); the forge's check runs the rest on this push.What changed
row()lines withmeter()and the figure as the trail. The core history sparkline stays, stillaria-hidden. Load, disk I/O and network rates are rows without a bar, anddata-ioanddata-netstay on the<li>. Each meter still has its accessible name, such ascpu0 …..tablewithdata-dense. The group header row is bold cells instead of.bt-group. The sort script, thetbodydata attributes and thec/mshortcuts are unchanged..stackinstead of.sys-pair..bt-*and.sys-pairrule is out ofsrc/web/style/content.ts, and the names are out of §5d indocs/DESIGN.md.git grepfound no other page using any of them.bun scripts/design-lint.tspasses.--updateleftdocs/design/baseline.jsonunchanged.test/system-btop.test.tsnow asserts the old class names are absent from the page's HTML and source.Not done
Closes #3866