Public: anyone can read this; the crew can change it.

Design: search results use §5's row and empty state, and no-hits leaves §5d #4017

Parked opened this
Closed without merging

Search results now use §5's row() and its empty state, and .no-hits is gone from the stylesheet and from §5d. I did not take screenshots, so that item in the issue is not met. Page: every hit, including code hits, goes through row() in src/web/pages/search.ts.

Notes

stopped parked by the crew deploy ced8960

opened this

Search results now use §5's row() and its empty state, and .no-hits is gone from the stylesheet and from §5d. I did not take screenshots, so that item in the issue is not met.

  • Page: every hit, including code hits, goes through row() in src/web/pages/search.ts. A search with no hits renders §5's empty state with its words, and an empty section carries a short note.
  • CSS and docs: the .no-hits rules are removed from src/web/style/content.ts. The name is struck from the "search results" bullet in docs/DESIGN.md §5d, and the other classes in that bullet stay. I merged 37 new commits from main into the branch and resolved a conflict in that file by keeping main's version of the lines and removing .no-hits.
  • Test: test/studio-search.test.ts checks that a no-hit search says so in the empty state and that no page contains no-hits.
  • Checks: bun scripts/design-lint.ts passes, and the 49 tests in the search and design suites pass. I did not run the whole suite. bun x tsc --noEmit failed here with "bun is unable to write files to tempdir: ReadOnlyFileSystem", so the type check did not run.
  • Not done: the before/after screenshots (hits and no hits, light and dark) are not attached, because I can't take screenshots from this shell. Please capture them from this branch's preview.

To try it, open the pull's preview, search for a term that matches something, then search for gibberish.

🤖 Generated with Claude Code

Closes #3649

commented

Search results now use §5's row() and its empty state, and .no-hits is gone from the stylesheet and from §5d. I did not take screenshots, so that item in the issue is not met.

  • Page: every hit, including code hits, goes through row() in src/web/pages/search.ts. A search with no hits renders §5's empty state with its words, and an empty section carries a short note.
  • CSS and docs: the .no-hits rules are removed from src/web/style/content.ts. The name is struck from the "search results" bullet in docs/DESIGN.md §5d, and the other classes in that bullet stay. I merged 37 new commits from main into the branch and resolved a conflict in that file by keeping main's version of the lines and removing .no-hits.
  • Test: test/studio-search.test.ts checks that a no-hit search says so in the empty state and that no page contains no-hits.
  • Checks: bun scripts/design-lint.ts passes, and the 49 tests in the search and design suites pass. I did not run the whole suite. bun x tsc --noEmit failed here with "bun is unable to write files to tempdir: ReadOnlyFileSystem", so the type check did not run.
  • Not done: the before/after screenshots (hits and no hits, light and dark) are not attached, because I can't take screenshots from this shell. Please capture them from this branch's preview.

To try it, open the pull's preview, search for a term that matches something, then search for gibberish.

🤖 Generated with Claude Code

commented

Parked by the crew: the check failed ("what you asked for > the page leads each row with what became of it, so a narrow screen cuts where and who, not that") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs